"WebContentsImplBrowserTest.PausePageScheduledTasks" is flaky |
|||||
Issue description"WebContentsImplBrowserTest.PausePageScheduledTasks" is flaky. This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label. We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyPQsSBUZsYWtlIjJXZWJDb250ZW50c0ltcGxCcm93c2VyVGVzdC5QYXVzZVBhZ2VTY2hlZHVsZWRUYXNrcww. Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
,
Apr 12 2018
,
Apr 12 2018
This test was added in https://chromium-review.googlesource.com/952642 gyuyoung.kim@lge.com: could you take a look? Can't assign because not a project member, assigning to kinuko@ in the mean time who reviewed the CL.
,
Apr 12 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/737264b8ff36928c14c39024e3c82dad66973eee commit 737264b8ff36928c14c39024e3c82dad66973eee Author: Kevin Marshall <kmarshall@chromium.org> Date: Thu Apr 12 21:59:44 2018 Disable WebContentsImplBrowserTest.PausePageScheduledTasks due to flakes TBR=piman@chromium.org Bug: 832191 Change-Id: I8fae4dd27cad4dea281e8198fa878d9a8cab3a94 Reviewed-on: https://chromium-review.googlesource.com/1010981 Reviewed-by: Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#550377} [modify] https://crrev.com/737264b8ff36928c14c39024e3c82dad66973eee/content/browser/web_contents/web_contents_impl_browsertest.cc
,
Apr 13 2018
Sorry for late reply. I didn't find this issue. Anyway, it seems to me that the flaky failure of the test seems to be due to not waiting long enough after resuming work again. So I tried to increase the waiting time further. But I think I need to find a better way to spend the waiting time. Once I just uploaded a new CL for it - https://chromium-review.googlesource.com/c/chromium/src/+/1011744
,
Apr 17 2018
,
Apr 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/737264b8ff36928c14c39024e3c82dad66973eee commit 737264b8ff36928c14c39024e3c82dad66973eee Author: Kevin Marshall <kmarshall@chromium.org> Date: Thu Apr 12 21:59:44 2018 Disable WebContentsImplBrowserTest.PausePageScheduledTasks due to flakes TBR=piman@chromium.org Bug: 832191 Change-Id: I8fae4dd27cad4dea281e8198fa878d9a8cab3a94 Reviewed-on: https://chromium-review.googlesource.com/1010981 Reviewed-by: Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#550377} [modify] https://crrev.com/737264b8ff36928c14c39024e3c82dad66973eee/content/browser/web_contents/web_contents_impl_browsertest.cc
,
Apr 26 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5f7ad25811b1aa0ae732b6a220c7fadb1abd6bf3 commit 5f7ad25811b1aa0ae732b6a220c7fadb1abd6bf3 Author: Gyuyoung Kim <gyuyoung.kim@lge.com> Date: Thu Apr 26 05:43:24 2018 Fix the flaky failure of WebContentsImplBrowserTest.PausePageScheduledTasks The flaky failure of the test seems to be due to not waiting long enough after resuming work again. This Cl changes the workaround logic to actually wait until the javascript work again (or let the test fail by timing out otherwise). Bug: 832191 Change-Id: I3c2f04ccf4d00cee6505e607566628d690f4ef00 Reviewed-on: https://chromium-review.googlesource.com/1011744 Commit-Queue: Gyuyoung Kim <gyuyoung.kim@lge.com> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#553927} [modify] https://crrev.com/5f7ad25811b1aa0ae732b6a220c7fadb1abd6bf3/content/browser/web_contents/web_contents_impl_browsertest.cc
,
Apr 26 2018
Still flaky on ASAN/LSAN: https://ci.chromium.org/buildbot/chromium.memory/Linux%20ASan%20LSan%20Tests%20%281%29/45077 [ RUN ] WebContentsImplBrowserTest.PausePageScheduledTasks Xlib: extension "RANDR" missing on display ":99". DevTools listening on ws://127.0.0.1:43655/devtools/browser/2f1c9d54-a532-4743-9488-dde7245b0025 ../../content/browser/web_contents/web_contents_impl_browsertest.cc:2256: Failure Expected: (text_length) > (0), actual: 0 vs 0 Stack trace: #0 0x000008aeb71c (/b/s/w/ir/out/Release/content_browsertests+0x8aeb71b) #1 0x000008b11f90 (/b/s/w/ir/out/Release/content_browsertests+0x8b11f8f) #2 0x000008b10b07 (/b/s/w/ir/out/Release/content_browsertests+0x8b10b06) #3 0x000006c2281d (/b/s/w/ir/out/Release/content_browsertests+0x6c2281c) #4 0x00000e754352 (/b/s/w/ir/out/Release/content_browsertests+0xe754351) #5 0x00000ea03f2c (/b/s/w/ir/out/Release/content_browsertests+0xea03f2b) #6 0x00000c84ba45 (/b/s/w/ir/out/Release/content_browsertests+0xc84ba44) #7 0x00000d954108 (/b/s/w/ir/out/Release/content_browsertests+0xd954107) #8 0x00000c8479a5 (/b/s/w/ir/out/Release/content_browsertests+0xc8479a4) #9 0x00000c8549f5 (/b/s/w/ir/out/Release/content_browsertests+0xc8549f4) #10 0x00000ea02583 (/b/s/w/ir/out/Release/content_browsertests+0xea02582) #11 0x00000e8ecc52 (/b/s/w/ir/out/Release/content_browsertests+0xe8ecc51) #12 0x00000c48cf95 (/b/s/w/ir/out/Release/content_browsertests+0xc48cf94) #13 0x00000c490a96 (/b/s/w/ir/out/Release/content_browsertests+0xc490a95) #14 0x000013e24864 (/b/s/w/ir/out/Release/content_browsertests+0x13e24863) #15 0x000009b91e11 (/b/s/w/ir/out/Release/content_browsertests+0x9b91e10) #16 0x00000e752f7b (/b/s/w/ir/out/Release/content_browsertests+0xe752f7a) [10155:10231:0426/022831.448822:WARNING:discardable_shared_memory_manager.cc(431)] Some MojoDiscardableSharedMemoryManagerImpls are still alive. They will be leaked. [ FAILED ] WebContentsImplBrowserTest.PausePageScheduledTasks, where TypeParam = and GetParam() = (8148 ms)
,
Apr 26 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/673c3aa4e20f52fa9002fc86e4e44dd42e59dcdf commit 673c3aa4e20f52fa9002fc86e4e44dd42e59dcdf Author: Max Morin <maxmorin@chromium.org> Date: Thu Apr 26 10:24:14 2018 Revert "Fix the flaky failure of WebContentsImplBrowserTest.PausePageScheduledTasks" This reverts commit 5f7ad25811b1aa0ae732b6a220c7fadb1abd6bf3. Reason for revert: Still flaky, see bug. Original change's description: > Fix the flaky failure of WebContentsImplBrowserTest.PausePageScheduledTasks > > The flaky failure of the test seems to be due to not waiting long enough after > resuming work again. This Cl changes the workaround logic to actually wait until > the javascript work again (or let the test fail by timing out otherwise). > > Bug: 832191 > Change-Id: I3c2f04ccf4d00cee6505e607566628d690f4ef00 > Reviewed-on: https://chromium-review.googlesource.com/1011744 > Commit-Queue: Gyuyoung Kim <gyuyoung.kim@lge.com> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Cr-Commit-Position: refs/heads/master@{#553927} TBR=kinuko@chromium.org,kmarshall@chromium.org,piman@chromium.org,gyuyoung.kim@lge.com Change-Id: Ie9e39f441305ac022494325ed7756be50574a401 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 832191 Reviewed-on: https://chromium-review.googlesource.com/1029972 Reviewed-by: Max Morin <maxmorin@chromium.org> Commit-Queue: Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#553971} [modify] https://crrev.com/673c3aa4e20f52fa9002fc86e4e44dd42e59dcdf/content/browser/web_contents/web_contents_impl_browsertest.cc
,
Apr 27 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4da46fac01e36a3f918f2248ae9f7a806024b65f commit 4da46fac01e36a3f918f2248ae9f7a806024b65f Author: Gyuyoung Kim <gyuyoung.kim@lge.com> Date: Fri Apr 27 05:11:53 2018 Fix the flaky failure of WebContentsImplBrowserTest.PausePageScheduledTasks again This reverts commit 673c3aa4e20f52fa9002fc86e4e44dd42e59dcdf. The original fix missed to solve other flaky places. The new flaky test seems to be due to not waiting long enough as well. This CL is to fix them. Original CL description: > The flaky failure of the test seems to be due to not waiting long enough after > resuming work again. This Cl changes the workaround logic to actually wait until > the javascript work again (or let the test fail by timing out otherwise). Bug: 832191 Change-Id: I2e36af87b341d6593dc2f10095f57742e37d5aad Reviewed-on: https://chromium-review.googlesource.com/1031790 Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung.kim@lge.com> Cr-Commit-Position: refs/heads/master@{#554313} [modify] https://crrev.com/4da46fac01e36a3f918f2248ae9f7a806024b65f/content/browser/web_contents/web_contents_impl_browsertest.cc
,
May 4 2018
kinuko@, it seems like this issue has been solved since the last fix. How about closing this bug? |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by kmarshall@chromium.org
, Apr 12 2018