New issue
Advanced search Search tips

Issue 832184 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug

Blocked on:
issue 768073

Blocking:
issue 831852



Sign in to add a comment

Update WebUI toggles (cr-toggle) for MD Refresh

Project Member Reported by dpa...@chromium.org, Apr 12 2018

Issue description

Spec at https://docs.google.com/presentation/d/1kXbnGrFln4CapA0bavU5zjZLALqeD4aQikVVKSJ0zFg/edit#slide=id.g3228466bab_0_40 (visible by @google accounts).

Note that there are still some occurrences of paper-toggle in WebUI. The goal is to *only* update our own cr-toggle, and also finish migrating paper-toggle usages to cr-toggle (tracked by  issue 768073 ).
 

Comment 1 by dpa...@chromium.org, Apr 12 2018

Blockedon: 768073
Blocking: 831852
Status: Started (was: Available)
CL at https://chromium-review.googlesource.com/c/chromium/src/+/1038737, still WIP.

Note that with this change, the 4 states disabled/enabled + on/off are easier to distinguish I think. Compare the following screenshots (I have disabled some toggles manually just for illustration purposes).

The basic difference is that while disabled, the colors do not drastically change. It only affects the opacity of the entire control, as opposed to previous spec where colors would be affected (in addition to opacity).

old_toggles.png
46.4 KB View Download
new_toggles.png
46.5 KB View Download
Project Member

Comment 3 by bugdroid1@chromium.org, May 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e6c77b80cd3c75616f92685141e6739877e31c93

commit e6c77b80cd3c75616f92685141e6739877e31c93
Author: Scott Chen <scottchen@chromium.org>
Date: Fri May 04 00:09:34 2018

WebUI: allow setting paper-ripple's opacity.

Bug:  836391 ,  832184 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I1ae3418e5b153a89b6d6bd5169365cc50bab7a15
Reviewed-on: https://chromium-review.googlesource.com/1040273
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555919}
[modify] https://crrev.com/e6c77b80cd3c75616f92685141e6739877e31c93/third_party/polymer/v1_0/components-chromium/paper-ripple/paper-ripple.html
[modify] https://crrev.com/e6c77b80cd3c75616f92685141e6739877e31c93/ui/webui/resources/cr_elements/cr_toggle/cr_toggle.html

Updated screenshot, with the proper disabled opacity set to 0.38 (as opposed to 0.5).
038_opacity.png
46.6 KB View Download
Project Member

Comment 5 by bugdroid1@chromium.org, May 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/60cce1e810fae7cbb0d81ac1353bc26a5d2dfa50

commit 60cce1e810fae7cbb0d81ac1353bc26a5d2dfa50
Author: dpapad <dpapad@chromium.org>
Date: Sat May 05 05:58:12 2018

WebUI MD Refresh: Update cr-toggle to adhere to the new spec.

Bug:  832184 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Idf252a9e10a524e898e2de8fc540d890285ff01e
Reviewed-on: https://chromium-review.googlesource.com/1038737
Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556311}
[modify] https://crrev.com/60cce1e810fae7cbb0d81ac1353bc26a5d2dfa50/ui/webui/resources/cr_elements/cr_toggle/cr_toggle.html
[modify] https://crrev.com/60cce1e810fae7cbb0d81ac1353bc26a5d2dfa50/ui/webui/resources/cr_elements/shared_vars_css.html

Cc: namratakannan@chromium.org
 Issue 818173  has been merged into this issue.
Owner: dpa...@chromium.org

Comment 8 by dpa...@chromium.org, May 11 2018

Status: Fixed (was: Started)

Sign in to add a comment