New issue
Advanced search Search tips

Issue 832181 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug

Blocking:
issue 831852



Sign in to add a comment

WebUI MD Refresh: Update cr-action-menu corner radius

Project Member Reported by dpa...@chromium.org, Apr 12 2018

Issue description

Comment 1 by dpa...@chromium.org, Apr 12 2018

Blocking: 831852

Comment 2 by dpa...@chromium.org, May 11 2018

Labels: M-68
Changes summary: background color of hover state and corner radius.

Comment 3 by dpa...@chromium.org, May 11 2018

Background color change targeting M69, corner radius targeting M68.

Comment 4 by dpa...@chromium.org, May 11 2018

Labels: -Pri-2 Pri-1

Comment 5 by dpa...@chromium.org, May 12 2018

Summary: WebUI MD Refresh: Update cr-action-menu hover corner radius (was: Update WebUI action menus (cr-action-menu) for MD Refresh )
Reducing scope for this bug. Filed separate one for background color.

Comment 6 by dpa...@chromium.org, May 12 2018

Labels: Proj-MaterialDesign-Refresh-WebUI

Comment 7 by dpa...@chromium.org, May 14 2018

Summary: WebUI MD Refresh: Update cr-action-menu corner radius (was: WebUI MD Refresh: Update cr-action-menu hover corner radius)

Comment 8 by aee@chromium.org, May 16 2018

Owner: aee@chromium.org
Status: Assigned (was: Available)

Comment 9 by aee@chromium.org, May 16 2018

Status: Started (was: Assigned)
Project Member

Comment 10 by bugdroid1@chromium.org, May 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9da91cfcb4446965c845278d36aebc4bb12f608d

commit 9da91cfcb4446965c845278d36aebc4bb12f608d
Author: Esmael El-Moslimany <aee@chromium.org>
Date: Wed May 16 19:56:22 2018

WebUI: updating border radius for cr-action-menu

Bug:  832181 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ia1f518476fca1e76223ddc072001c91e241dd44c
Reviewed-on: https://chromium-review.googlesource.com/1062226
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559242}
[modify] https://crrev.com/9da91cfcb4446965c845278d36aebc4bb12f608d/ui/webui/resources/cr_elements/cr_action_menu/cr_action_menu.html

Comment 11 by aee@chromium.org, May 16 2018

Status: Fixed (was: Started)
Labels: Needs-Feedback
Tried to verify the fix on Chrome #68.0.3343.0 on Windows 10 in chrome://settings/content/flash page by clicking on the menu button displayed adjacent to each site and the behavior is as in the screenshot attached.

aee@ -- Could you please look into the attached screenshot and confirm whether it is as expected or not. So that we can proceed ahead and add verified labels.

Thanks!
832181.png
49.0 KB View Download

Comment 13 by aee@chromium.org, May 17 2018

That looks correct, thanks.

Sign in to add a comment