Update WebUI <cr-dialog> for MD Refresh |
||||||||
Issue descriptionSpec at https://docs.google.com/presentation/d/1kXbnGrFln4CapA0bavU5zjZLALqeD4aQikVVKSJ0zFg/edit#slide=id.g34cf33e002_0_3 (visible by @google accounts).
,
Apr 12 2018
,
May 11 2018
Border radius and padding changes targeting 68.
,
May 12 2018
,
May 15 2018
,
May 15 2018
,
May 15 2018
,
May 16 2018
,
May 16 2018
I'm not sure. If you are okay with the proposed change to 716112, I can do that next.
,
May 16 2018
I am not sure either. I think it would help if Namrata comments on exactly what is still relevant from issue 716112 , before any work is done. Additionally, since issue 716112 is marked as M69, I suggest focusing on M68 bugs first.
,
May 16 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3b8a5ee5dad1eeb8739f1ce51cddcc048fd8cee7 commit 3b8a5ee5dad1eeb8739f1ce51cddcc048fd8cee7 Author: Esmael El-Moslimany <aee@chromium.org> Date: Wed May 16 19:51:07 2018 WebUI: updating cr-dialog border radius Bug: 832179 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I7db70455f9e9a6f72840b51ba8d9f89dab38d406 Reviewed-on: https://chromium-review.googlesource.com/1060472 Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#559239} [modify] https://crrev.com/3b8a5ee5dad1eeb8739f1ce51cddcc048fd8cee7/chrome/browser/resources/print_preview/new/destination_dialog.html [modify] https://crrev.com/3b8a5ee5dad1eeb8739f1ce51cddcc048fd8cee7/chrome/browser/resources/print_preview/new/provisional_destination_resolver.html [modify] https://crrev.com/3b8a5ee5dad1eeb8739f1ce51cddcc048fd8cee7/chrome/browser/resources/print_preview/new/search_dialog_css.html [modify] https://crrev.com/3b8a5ee5dad1eeb8739f1ce51cddcc048fd8cee7/ui/webui/resources/cr_elements/cr_dialog/cr_dialog.html
,
May 16 2018
namratakannan@: can I mark this fixed and start working on 716112?
,
May 16 2018
,
May 17 2018
Tested the issue using #68.0.3433.0 on Mac 10.13.3, Linux Debian Rodete and Win 10 as per the steps mentioned below. Steps: 1. Launched Browser 2. Navigated to chrome://settings/content/notifications @aee: Could you please find the screenshot and help us in verifying the fix? Thanks!! |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by dpa...@chromium.org
, Apr 12 2018