New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 832177 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jul 3
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug

Blocking:
issue 831852



Sign in to add a comment

Update WebUI text inputs for MD Refresh

Project Member Reported by dpa...@chromium.org, Apr 12 2018

Issue description

Comment 1 by dpa...@chromium.org, Apr 12 2018

Blocking: 831852

Comment 2 by dpa...@chromium.org, May 11 2018

Labels: M-69

Comment 3 by dpa...@chromium.org, May 12 2018

Labels: Proj-MaterialDesign-Refresh-WebUI
Status: Started (was: Available)
Owner: scottchen@chromium.org
NOTE: also need to follow-up on design and then implement textarea.
Project Member

Comment 7 by bugdroid1@chromium.org, May 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/029a7c42b84d765f6c5f46d8abdce7932eff2101

commit 029a7c42b84d765f6c5f46d8abdce7932eff2101
Author: Scott Chen <scottchen@chromium.org>
Date: Fri May 25 01:17:24 2018

Settings: moved --paper-input-max-width from cr-shared to settings-shared css

Found the "--paper-input-max-width" is only used within settings/ so moving
it to settings-shared style sheet.

Bug:  832177 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I84f2f8b46f4d2c7a95c32ec57ed4be1339bfa5dd
Reviewed-on: https://chromium-review.googlesource.com/1070932
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561720}
[modify] https://crrev.com/029a7c42b84d765f6c5f46d8abdce7932eff2101/chrome/browser/resources/settings/downloads_page/add_smb_share_dialog.html
[modify] https://crrev.com/029a7c42b84d765f6c5f46d8abdce7932eff2101/chrome/browser/resources/settings/languages_page/edit_dictionary_page.html
[modify] https://crrev.com/029a7c42b84d765f6c5f46d8abdce7932eff2101/chrome/browser/resources/settings/passwords_and_forms_page/address_edit_dialog.html
[modify] https://crrev.com/029a7c42b84d765f6c5f46d8abdce7932eff2101/chrome/browser/resources/settings/passwords_and_forms_page/credit_card_edit_dialog.html
[modify] https://crrev.com/029a7c42b84d765f6c5f46d8abdce7932eff2101/chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.html
[modify] https://crrev.com/029a7c42b84d765f6c5f46d8abdce7932eff2101/chrome/browser/resources/settings/people_page/sync_page.html
[modify] https://crrev.com/029a7c42b84d765f6c5f46d8abdce7932eff2101/chrome/browser/resources/settings/people_page/users_add_user_dialog.html
[modify] https://crrev.com/029a7c42b84d765f6c5f46d8abdce7932eff2101/chrome/browser/resources/settings/settings_vars_css.html
[modify] https://crrev.com/029a7c42b84d765f6c5f46d8abdce7932eff2101/ui/webui/resources/cr_elements/paper_input_style_css.html

Labels: Needs-Feedback
scottchen@ -- In order to verify the fix do we need to enable any flags and in which page the fix can be verified with the latest UI.

This will help us in verifying and adding TE-Verified labels.

Thanks in advance!

Comment 9 by dpa...@chromium.org, May 25 2018

Labels: -Needs-Feedback
This bug is not marked as Fixed yet, and there are more changes coming. There is no need to verify anything yet.
Project Member

Comment 10 by bugdroid1@chromium.org, May 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/56c075371dba1bbc12dc3f260f7786547b29a651

commit 56c075371dba1bbc12dc3f260f7786547b29a651
Author: Scott Chen <scottchen@chromium.org>
Date: Sat May 26 02:44:11 2018

WebUI[MD-refresh]: create cr-input and replace some paper-input

This CL creates the initial version of cr-input, and implements enough
function to fully replace paper-input in the following places:
1) settings -> search engine -> add
2) settings -> appearance page -> home button url

There will be follow-up CLs to add more features to cr-input in order
to replace all paper-input's current usages.

Bug:  832177 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ib2215d565cd3c26635b03add114ae8d681476ca2
Reviewed-on: https://chromium-review.googlesource.com/1068138
Commit-Queue: Scott Chen <scottchen@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562103}
[modify] https://crrev.com/56c075371dba1bbc12dc3f260f7786547b29a651/chrome/browser/resources/settings/appearance_page/appearance_page.html
[modify] https://crrev.com/56c075371dba1bbc12dc3f260f7786547b29a651/chrome/browser/resources/settings/appearance_page/home_url_input.html
[modify] https://crrev.com/56c075371dba1bbc12dc3f260f7786547b29a651/chrome/browser/resources/settings/appearance_page/home_url_input.js
[modify] https://crrev.com/56c075371dba1bbc12dc3f260f7786547b29a651/chrome/browser/resources/settings/search_engines_page/search_engine_dialog.html
[modify] https://crrev.com/56c075371dba1bbc12dc3f260f7786547b29a651/chrome/test/data/webui/cr_elements/cr_elements_focus_test.js
[add] https://crrev.com/56c075371dba1bbc12dc3f260f7786547b29a651/chrome/test/data/webui/cr_elements/cr_input_test.js
[add] https://crrev.com/56c075371dba1bbc12dc3f260f7786547b29a651/ui/webui/resources/cr_elements/cr_input/BUILD.gn
[add] https://crrev.com/56c075371dba1bbc12dc3f260f7786547b29a651/ui/webui/resources/cr_elements/cr_input/cr_input.html
[add] https://crrev.com/56c075371dba1bbc12dc3f260f7786547b29a651/ui/webui/resources/cr_elements/cr_input/cr_input.js
[modify] https://crrev.com/56c075371dba1bbc12dc3f260f7786547b29a651/ui/webui/resources/cr_elements/cr_radio_button/cr_radio_button_style_css.html
[modify] https://crrev.com/56c075371dba1bbc12dc3f260f7786547b29a651/ui/webui/resources/cr_elements/shared_vars_css.html
[modify] https://crrev.com/56c075371dba1bbc12dc3f260f7786547b29a651/ui/webui/resources/cr_elements_resources.grdp

Project Member

Comment 11 by bugdroid1@chromium.org, Jun 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b829c175c977813bb38db339c9655ed7d63e07fd

commit b829c175c977813bb38db339c9655ed7d63e07fd
Author: Scott Chen <scottchen@chromium.org>
Date: Fri Jun 01 02:07:40 2018

WebUI[MD-refresh]: Add [type="password"] and ["readonly"] to cr-input

Bug:  832177 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: If05ffdfc80374c79dec5bbb1422ff44a4489818d
Reviewed-on: https://chromium-review.googlesource.com/1070861
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563488}
[modify] https://crrev.com/b829c175c977813bb38db339c9655ed7d63e07fd/chrome/browser/resources/settings/passwords_and_forms_page/BUILD.gn
[modify] https://crrev.com/b829c175c977813bb38db339c9655ed7d63e07fd/chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.html
[modify] https://crrev.com/b829c175c977813bb38db339c9655ed7d63e07fd/chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.js
[modify] https://crrev.com/b829c175c977813bb38db339c9655ed7d63e07fd/chrome/browser/resources/settings/people_page/sync_page.html
[modify] https://crrev.com/b829c175c977813bb38db339c9655ed7d63e07fd/chrome/browser/resources/settings/people_page/sync_page.js
[modify] https://crrev.com/b829c175c977813bb38db339c9655ed7d63e07fd/chrome/test/data/webui/cr_elements/cr_input_test.js
[modify] https://crrev.com/b829c175c977813bb38db339c9655ed7d63e07fd/chrome/test/data/webui/settings/people_page_sync_page_interactive_test.js
[modify] https://crrev.com/b829c175c977813bb38db339c9655ed7d63e07fd/ui/webui/resources/cr_elements/BUILD.gn
[modify] https://crrev.com/b829c175c977813bb38db339c9655ed7d63e07fd/ui/webui/resources/cr_elements/cr_input/cr_input.html
[modify] https://crrev.com/b829c175c977813bb38db339c9655ed7d63e07fd/ui/webui/resources/cr_elements/cr_input/cr_input.js

Project Member

Comment 12 by bugdroid1@chromium.org, Jun 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f1503be9536b620903c64d8028437ca1e4f1a519

commit f1503be9536b620903c64d8028437ca1e4f1a519
Author: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Date: Fri Jun 01 13:17:43 2018

Revert "WebUI[MD-refresh]: Add [type="password"] and ["readonly"] to cr-input"

This reverts commit b829c175c977813bb38db339c9655ed7d63e07fd.

Reason for revert:
SettingsPasswordSectionBrowserTest.uiTests has been failing consistently since this CL landed.

On Linux and CrOS

Stacktrace:
[28290:28290:0531/210110.220114:ERROR:web_ui_browser_test.cc(478)] JS call assumed failed, because JS console error(s) found.
gen/chrome/test/data/webui/settings/settings_passwords_section_browsertest-gen.cc:41: Failure
Value of: RunJavascriptTestF( true, "SettingsPasswordSectionBrowserTest", "uiTests")
  Actual: false
Expected: true
Stack trace:
#0 0x000003df7e60 StackTraceGetter::CurrentStackTrace()
#1 0x000003e18927 testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop()
#2 0x000003e17d8d testing::internal::AssertHelper::operator=()
#3 0x000002f69fe7 SettingsPasswordSectionBrowserTest_uiTests_Test::RunTestOnMainThread()
#4 0x0000075a5ece content::BrowserTestBase::ProxyRunTestOnMainThreadLoop()
#5 0x0000009a452d _ZN4base8internal13FunctorTraitsIM25RenderViewContextMenuBaseFvvEvE6InvokeIS4_P21RenderViewContextMenuJEEEvT_OT0_DpOT1_
#6 0x0000009a4474 _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIM25RenderViewContextMenuBaseFvvEJP21RenderViewContextMenuEEEvOT_DpOT0_
#7 0x0000075a7eb5 _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserTestBaseEFvvEJNS0_17UnretainedWrapperIS4_EEEEEFvvEE7RunImplIRKS6_RKNSt3__15tupleIJS8_EEEJLm0EEEEvOT_OT0_NSF_16integer_sequenceImJXspT1_EEEE
#8 0x0000075a7dfc _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserTestBaseEFvvEJNS0_17UnretainedWrapperIS4_EEEEEFvvEE3RunEPNS0_13BindStateBaseE
#9 0x0000009966ed _ZNKR4base17RepeatingCallbackIFvvEE3RunEv
#10 0x000006519af7 ChromeBrowserMainParts::PreMainMessageLoopRunImpl()
#11 0x000006517cde ChromeBrowserMainParts::PreMainMessageLoopRun()
#12 0x000003290375 chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun()
#13 0x7fd41048cb4c content::BrowserMainLoop::PreMainMessageLoopRun()
#14 0x7fd40f27ea0d _ZN4base8internal13FunctorTraitsIMN7content12ChildProcessEFvvEvE6InvokeIS5_PS3_JEEEvT_OT0_DpOT1_
#15 0x7fd40f27e954 _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIMN7content12ChildProcessEFvvEJPS5_EEEvOT_DpOT0_
#16 0x7fd4104928e5 _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserMainLoopEFivEJNS0_17UnretainedWrapperIS4_EEEEEFivEE7RunImplIRKS6_RKNSt3__15tupleIJS8_EEEJLm0EEEEiOT_OT0_NSF_16integer_sequenceImJXspT1_EEEE
#17 0x7fd41049282c _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserMainLoopEFivEJNS0_17UnretainedWrapperIS4_EEEEEFivEE3RunEPNS0_13BindStateBaseE
#18 0x7fd40f18c70d _ZNKR4base17RepeatingCallbackIFvvEE3RunEv
#19 0x7fd4112d797d content::StartupTaskRunner::RunAllTasksNow()
#20 0x7fd410488230 content::BrowserMainLoop::CreateStartupTasks()
#21 0x7fd410494fc7 content::BrowserMainRunnerImpl::Initialize()
#22 0x7fd410480729 content::BrowserMain()
#23 0x7fd41254804b content::RunBrowserProcessMain()
#24 0x7fd41254a055 content::ContentMainRunnerImpl::Run()
#25 0x7fd41253ed55 content::ContentServiceManagerMainDelegate::RunEmbedderProcess()
#26 0x7fd40b7add1b service_manager::Main()
#27 0x7fd412544ef5 content::ContentMain()
#28 0x0000075a5478 content::BrowserTestBase::SetUp()
#29 0x00000641cabb InProcessBrowserTest::SetUp()
#30 0x00000091fc3e _ZN7testing8internal12InvokeHelperIRKNSt3__16vectorIPN12user_manager4UserENS2_9allocatorIS6_EEEENS2_5tupleIJEEEE12InvokeMethodIN8chromeos15MockUserManagerEMSH_KFSB_vEEESB_PT_T0_RKSD_


Original change's description:
> WebUI[MD-refresh]: Add [type="password"] and ["readonly"] to cr-input
> 
> Bug:  832177 
> Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
> Change-Id: If05ffdfc80374c79dec5bbb1422ff44a4489818d
> Reviewed-on: https://chromium-review.googlesource.com/1070861
> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
> Commit-Queue: Scott Chen <scottchen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#563488}

TBR=dpapad@chromium.org,scottchen@chromium.org

Change-Id: I48576bfdebf17815a26e48301ae8463452b3e63f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  832177 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Reviewed-on: https://chromium-review.googlesource.com/1082453
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563605}
[modify] https://crrev.com/f1503be9536b620903c64d8028437ca1e4f1a519/chrome/browser/resources/settings/passwords_and_forms_page/BUILD.gn
[modify] https://crrev.com/f1503be9536b620903c64d8028437ca1e4f1a519/chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.html
[modify] https://crrev.com/f1503be9536b620903c64d8028437ca1e4f1a519/chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.js
[modify] https://crrev.com/f1503be9536b620903c64d8028437ca1e4f1a519/chrome/browser/resources/settings/people_page/sync_page.html
[modify] https://crrev.com/f1503be9536b620903c64d8028437ca1e4f1a519/chrome/browser/resources/settings/people_page/sync_page.js
[modify] https://crrev.com/f1503be9536b620903c64d8028437ca1e4f1a519/chrome/test/data/webui/cr_elements/cr_input_test.js
[modify] https://crrev.com/f1503be9536b620903c64d8028437ca1e4f1a519/chrome/test/data/webui/settings/people_page_sync_page_interactive_test.js
[modify] https://crrev.com/f1503be9536b620903c64d8028437ca1e4f1a519/ui/webui/resources/cr_elements/BUILD.gn
[modify] https://crrev.com/f1503be9536b620903c64d8028437ca1e4f1a519/ui/webui/resources/cr_elements/cr_input/cr_input.html
[modify] https://crrev.com/f1503be9536b620903c64d8028437ca1e4f1a519/ui/webui/resources/cr_elements/cr_input/cr_input.js

Project Member

Comment 13 by bugdroid1@chromium.org, Jun 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/da620acb4996e3f839b5bf35c1c44b1187f40c7b

commit da620acb4996e3f839b5bf35c1c44b1187f40c7b
Author: Scott Chen <scottchen@chromium.org>
Date: Fri Jun 01 22:54:14 2018

Reland "WebUI[MD-refresh]: Add [type="password"] and ["readonly"] to cr-input"

A file was imported-by-proxy via paper-input. After paper-input is removed,
during testing this file is not pulled in anymore so the test fails.

Bug:  832177 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I5b6e254dbe3a082a8e6309b8d1da865bd0bfee72
Reviewed-on: https://chromium-review.googlesource.com/1083011
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563845}
[modify] https://crrev.com/da620acb4996e3f839b5bf35c1c44b1187f40c7b/chrome/browser/resources/settings/passwords_and_forms_page/BUILD.gn
[modify] https://crrev.com/da620acb4996e3f839b5bf35c1c44b1187f40c7b/chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.html
[modify] https://crrev.com/da620acb4996e3f839b5bf35c1c44b1187f40c7b/chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.js
[modify] https://crrev.com/da620acb4996e3f839b5bf35c1c44b1187f40c7b/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html
[modify] https://crrev.com/da620acb4996e3f839b5bf35c1c44b1187f40c7b/chrome/browser/resources/settings/people_page/sync_page.html
[modify] https://crrev.com/da620acb4996e3f839b5bf35c1c44b1187f40c7b/chrome/browser/resources/settings/people_page/sync_page.js
[modify] https://crrev.com/da620acb4996e3f839b5bf35c1c44b1187f40c7b/chrome/test/data/webui/cr_elements/cr_input_test.js
[modify] https://crrev.com/da620acb4996e3f839b5bf35c1c44b1187f40c7b/chrome/test/data/webui/settings/people_page_sync_page_interactive_test.js
[modify] https://crrev.com/da620acb4996e3f839b5bf35c1c44b1187f40c7b/ui/webui/resources/cr_elements/BUILD.gn
[modify] https://crrev.com/da620acb4996e3f839b5bf35c1c44b1187f40c7b/ui/webui/resources/cr_elements/cr_input/cr_input.html
[modify] https://crrev.com/da620acb4996e3f839b5bf35c1c44b1187f40c7b/ui/webui/resources/cr_elements/cr_input/cr_input.js

Project Member

Comment 16 by bugdroid1@chromium.org, Jun 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/66c801f15e20c5a8399054d7f8d8fc53477c6302

commit 66c801f15e20c5a8399054d7f8d8fc53477c6302
Author: Scott Chen <scottchen@chromium.org>
Date: Tue Jun 05 21:48:32 2018

WebUI[MD-refresh]: adjust cr-input style to work better in different context.

This CL replaces paper-input with cr-input in a few more pages.

The management of spacing around cr-input is adjusted to make consistent spacing
more easily.

cr-input now has no margin or padding on top. If there's an error message,
there will also be a 8px margin on the bottom of the error message.

Or if the user opts to hide the error-message with --cr-input-error-display: none,
it will not have any spacing on the bottom either; One should use
--cr-form-field-bottom-spacing to add spacing under cr-input if it is followed
by an element.

Also, the "suffix" slot is introduced to cr-input in order for elements to easily
align with the input field itself regardless of label and error-message.

Bug:  832177 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I638cffa576ec9c8767c4a96b464510ef55ad6874
Reviewed-on: https://chromium-review.googlesource.com/1074206
Commit-Queue: Scott Chen <scottchen@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564677}
[modify] https://crrev.com/66c801f15e20c5a8399054d7f8d8fc53477c6302/chrome/browser/resources/settings/appearance_page/appearance_page.html
[modify] https://crrev.com/66c801f15e20c5a8399054d7f8d8fc53477c6302/chrome/browser/resources/settings/appearance_page/home_url_input.html
[modify] https://crrev.com/66c801f15e20c5a8399054d7f8d8fc53477c6302/chrome/browser/resources/settings/appearance_page/home_url_input.js
[modify] https://crrev.com/66c801f15e20c5a8399054d7f8d8fc53477c6302/chrome/browser/resources/settings/languages_page/edit_dictionary_page.html
[modify] https://crrev.com/66c801f15e20c5a8399054d7f8d8fc53477c6302/chrome/browser/resources/settings/languages_page/edit_dictionary_page.js
[modify] https://crrev.com/66c801f15e20c5a8399054d7f8d8fc53477c6302/chrome/browser/resources/settings/passwords_and_forms_page/address_edit_dialog.html
[modify] https://crrev.com/66c801f15e20c5a8399054d7f8d8fc53477c6302/chrome/browser/resources/settings/passwords_and_forms_page/credit_card_edit_dialog.html
[modify] https://crrev.com/66c801f15e20c5a8399054d7f8d8fc53477c6302/chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.html
[modify] https://crrev.com/66c801f15e20c5a8399054d7f8d8fc53477c6302/chrome/browser/resources/settings/people_page/manage_profile.html
[modify] https://crrev.com/66c801f15e20c5a8399054d7f8d8fc53477c6302/chrome/browser/resources/settings/people_page/sync_page.html
[modify] https://crrev.com/66c801f15e20c5a8399054d7f8d8fc53477c6302/chrome/test/data/webui/settings/settings_autofill_section_browsertest.js
[modify] https://crrev.com/66c801f15e20c5a8399054d7f8d8fc53477c6302/ui/webui/resources/cr_elements/cr_input/cr_input.html
[modify] https://crrev.com/66c801f15e20c5a8399054d7f8d8fc53477c6302/ui/webui/resources/cr_elements/cr_input/cr_input.js
[modify] https://crrev.com/66c801f15e20c5a8399054d7f8d8fc53477c6302/ui/webui/resources/cr_elements/cr_radio_button/cr_radio_button.html
[modify] https://crrev.com/66c801f15e20c5a8399054d7f8d8fc53477c6302/ui/webui/resources/cr_elements/shared_vars_css.html

Project Member

Comment 17 by bugdroid1@chromium.org, Jun 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f58a0adad674d61c38e66932273cfa03043b3525

commit f58a0adad674d61c38e66932273cfa03043b3525
Author: Scott Chen <scottchen@chromium.org>
Date: Wed Jun 06 18:13:00 2018

WebUI[MD-refresh]: switches remaining paper-input in Settings to cr-input.

Bug:  832177 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Iae1036e0a8975f65a37ff9ccc7b6084b4a6d45ef
Reviewed-on: https://chromium-review.googlesource.com/1081243
Commit-Queue: Scott Chen <scottchen@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564968}
[modify] https://crrev.com/f58a0adad674d61c38e66932273cfa03043b3525/chrome/browser/resources/settings/downloads_page/add_smb_share_dialog.html
[modify] https://crrev.com/f58a0adad674d61c38e66932273cfa03043b3525/chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.html
[modify] https://crrev.com/f58a0adad674d61c38e66932273cfa03043b3525/chrome/browser/resources/settings/people_page/BUILD.gn
[modify] https://crrev.com/f58a0adad674d61c38e66932273cfa03043b3525/chrome/browser/resources/settings/people_page/fingerprint_list.html
[modify] https://crrev.com/f58a0adad674d61c38e66932273cfa03043b3525/chrome/browser/resources/settings/people_page/password_prompt_dialog.html
[modify] https://crrev.com/f58a0adad674d61c38e66932273cfa03043b3525/chrome/browser/resources/settings/people_page/password_prompt_dialog.js
[modify] https://crrev.com/f58a0adad674d61c38e66932273cfa03043b3525/chrome/browser/resources/settings/people_page/sync_page.js
[modify] https://crrev.com/f58a0adad674d61c38e66932273cfa03043b3525/chrome/browser/resources/settings/people_page/users_add_user_dialog.html
[modify] https://crrev.com/f58a0adad674d61c38e66932273cfa03043b3525/chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.html
[modify] https://crrev.com/f58a0adad674d61c38e66932273cfa03043b3525/chrome/browser/resources/settings/printing_page/cups_edit_printer_dialog.html
[modify] https://crrev.com/f58a0adad674d61c38e66932273cfa03043b3525/chrome/browser/resources/settings/printing_page/cups_printer_shared_css.html
[modify] https://crrev.com/f58a0adad674d61c38e66932273cfa03043b3525/chrome/browser/resources/settings/site_settings/add_site_dialog.html
[modify] https://crrev.com/f58a0adad674d61c38e66932273cfa03043b3525/chrome/browser/resources/settings/site_settings/edit_exception_dialog.html
[modify] https://crrev.com/f58a0adad674d61c38e66932273cfa03043b3525/chrome/browser/resources/settings/site_settings/edit_exception_dialog.js
[modify] https://crrev.com/f58a0adad674d61c38e66932273cfa03043b3525/ui/webui/resources/cr_elements/cr_input/cr_input.html

Project Member

Comment 18 by bugdroid1@chromium.org, Jun 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9e27a974e41299090cc016622f933b7b20f68f72

commit 9e27a974e41299090cc016622f933b7b20f68f72
Author: Kevin McNee <mcnee@chromium.org>
Date: Wed Jun 06 21:35:00 2018

Revert "WebUI[MD-refresh]: switches remaining paper-input in Settings to cr-input."

This reverts commit f58a0adad674d61c38e66932273cfa03043b3525.

Reason for revert: Suspecting this CL for the failures of CrSettingsSiteListTest.AddExceptionDialog and CrSettingsSiteListTest.EditExceptionDialog. https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=CrSettingsSiteListTest.*ExceptionDialog 

Original change's description:
> WebUI[MD-refresh]: switches remaining paper-input in Settings to cr-input.
> 
> Bug:  832177 
> Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
> Change-Id: Iae1036e0a8975f65a37ff9ccc7b6084b4a6d45ef
> Reviewed-on: https://chromium-review.googlesource.com/1081243
> Commit-Queue: Scott Chen <scottchen@chromium.org>
> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#564968}

TBR=dpapad@chromium.org,scottchen@chromium.org

Change-Id: I4a0a973a5d54324389e2164e041bfb085dffd631
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  832177 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Reviewed-on: https://chromium-review.googlesource.com/1089870
Reviewed-by: Kevin McNee <mcnee@chromium.org>
Commit-Queue: Kevin McNee <mcnee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565042}
[modify] https://crrev.com/9e27a974e41299090cc016622f933b7b20f68f72/chrome/browser/resources/settings/downloads_page/add_smb_share_dialog.html
[modify] https://crrev.com/9e27a974e41299090cc016622f933b7b20f68f72/chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.html
[modify] https://crrev.com/9e27a974e41299090cc016622f933b7b20f68f72/chrome/browser/resources/settings/people_page/BUILD.gn
[modify] https://crrev.com/9e27a974e41299090cc016622f933b7b20f68f72/chrome/browser/resources/settings/people_page/fingerprint_list.html
[modify] https://crrev.com/9e27a974e41299090cc016622f933b7b20f68f72/chrome/browser/resources/settings/people_page/password_prompt_dialog.html
[modify] https://crrev.com/9e27a974e41299090cc016622f933b7b20f68f72/chrome/browser/resources/settings/people_page/password_prompt_dialog.js
[modify] https://crrev.com/9e27a974e41299090cc016622f933b7b20f68f72/chrome/browser/resources/settings/people_page/sync_page.js
[modify] https://crrev.com/9e27a974e41299090cc016622f933b7b20f68f72/chrome/browser/resources/settings/people_page/users_add_user_dialog.html
[modify] https://crrev.com/9e27a974e41299090cc016622f933b7b20f68f72/chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.html
[modify] https://crrev.com/9e27a974e41299090cc016622f933b7b20f68f72/chrome/browser/resources/settings/printing_page/cups_edit_printer_dialog.html
[modify] https://crrev.com/9e27a974e41299090cc016622f933b7b20f68f72/chrome/browser/resources/settings/printing_page/cups_printer_shared_css.html
[modify] https://crrev.com/9e27a974e41299090cc016622f933b7b20f68f72/chrome/browser/resources/settings/site_settings/add_site_dialog.html
[modify] https://crrev.com/9e27a974e41299090cc016622f933b7b20f68f72/chrome/browser/resources/settings/site_settings/edit_exception_dialog.html
[modify] https://crrev.com/9e27a974e41299090cc016622f933b7b20f68f72/chrome/browser/resources/settings/site_settings/edit_exception_dialog.js
[modify] https://crrev.com/9e27a974e41299090cc016622f933b7b20f68f72/ui/webui/resources/cr_elements/cr_input/cr_input.html

Cc: weifangsun@chromium.org x...@chromium.org brajkumar@chromium.org ajha@chromium.org scottchen@chromium.org
 Issue 850470  has been merged into this issue.
Project Member

Comment 20 by bugdroid1@chromium.org, Jun 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/23f3b531610532a4b205d8dc47eddbf9fbf5693c

commit 23f3b531610532a4b205d8dc47eddbf9fbf5693c
Author: Scott Chen <scottchen@chromium.org>
Date: Fri Jun 08 02:52:03 2018

Reland "WebUI[MD-refresh]: switches remaining paper-input in Settings to cr-input."

Tests were still testing for paper-input, which is why the tests were failing.

Bug:  832177 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I70abd95c2da6c54f46a522c039ed28fda0c3b67c
Reviewed-on: https://chromium-review.googlesource.com/1089863
Commit-Queue: Scott Chen <scottchen@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565522}
[modify] https://crrev.com/23f3b531610532a4b205d8dc47eddbf9fbf5693c/chrome/browser/resources/settings/downloads_page/add_smb_share_dialog.html
[modify] https://crrev.com/23f3b531610532a4b205d8dc47eddbf9fbf5693c/chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.html
[modify] https://crrev.com/23f3b531610532a4b205d8dc47eddbf9fbf5693c/chrome/browser/resources/settings/people_page/BUILD.gn
[modify] https://crrev.com/23f3b531610532a4b205d8dc47eddbf9fbf5693c/chrome/browser/resources/settings/people_page/fingerprint_list.html
[modify] https://crrev.com/23f3b531610532a4b205d8dc47eddbf9fbf5693c/chrome/browser/resources/settings/people_page/password_prompt_dialog.html
[modify] https://crrev.com/23f3b531610532a4b205d8dc47eddbf9fbf5693c/chrome/browser/resources/settings/people_page/password_prompt_dialog.js
[modify] https://crrev.com/23f3b531610532a4b205d8dc47eddbf9fbf5693c/chrome/browser/resources/settings/people_page/sync_page.js
[modify] https://crrev.com/23f3b531610532a4b205d8dc47eddbf9fbf5693c/chrome/browser/resources/settings/people_page/users_add_user_dialog.html
[modify] https://crrev.com/23f3b531610532a4b205d8dc47eddbf9fbf5693c/chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.html
[modify] https://crrev.com/23f3b531610532a4b205d8dc47eddbf9fbf5693c/chrome/browser/resources/settings/printing_page/cups_edit_printer_dialog.html
[modify] https://crrev.com/23f3b531610532a4b205d8dc47eddbf9fbf5693c/chrome/browser/resources/settings/printing_page/cups_printer_shared_css.html
[modify] https://crrev.com/23f3b531610532a4b205d8dc47eddbf9fbf5693c/chrome/browser/resources/settings/site_settings/add_site_dialog.html
[modify] https://crrev.com/23f3b531610532a4b205d8dc47eddbf9fbf5693c/chrome/browser/resources/settings/site_settings/edit_exception_dialog.html
[modify] https://crrev.com/23f3b531610532a4b205d8dc47eddbf9fbf5693c/chrome/browser/resources/settings/site_settings/edit_exception_dialog.js
[modify] https://crrev.com/23f3b531610532a4b205d8dc47eddbf9fbf5693c/chrome/test/data/webui/settings/quick_unlock_authenticate_browsertest_chromeos.js
[modify] https://crrev.com/23f3b531610532a4b205d8dc47eddbf9fbf5693c/chrome/test/data/webui/settings/site_list_tests.js
[modify] https://crrev.com/23f3b531610532a4b205d8dc47eddbf9fbf5693c/ui/webui/resources/cr_elements/cr_input/cr_input.html

Project Member

Comment 21 by bugdroid1@chromium.org, Jun 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eb12d31bc08f755fce655514cd98bd63836489a3

commit eb12d31bc08f755fce655514cd98bd63836489a3
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Fri Jun 08 15:55:51 2018

Settings > network > update input and dialog style

This CL fixes a number of inconsistencies with input style and
overall dialog appearance.

Bug:  832177 , 829272 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Icb5bdd4245073d3c8db5100ebc3bca1a8b4f1b17
Reviewed-on: https://chromium-review.googlesource.com/1091166
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565643}
[modify] https://crrev.com/eb12d31bc08f755fce655514cd98bd63836489a3/chrome/browser/resources/settings/internet_page/network_proxy_section.js
[modify] https://crrev.com/eb12d31bc08f755fce655514cd98bd63836489a3/ui/webui/resources/cr_components/chromeos/network/BUILD.gn
[modify] https://crrev.com/eb12d31bc08f755fce655514cd98bd63836489a3/ui/webui/resources/cr_components/chromeos/network/compiled_resources2.gyp
[modify] https://crrev.com/eb12d31bc08f755fce655514cd98bd63836489a3/ui/webui/resources/cr_components/chromeos/network/network_config.html
[modify] https://crrev.com/eb12d31bc08f755fce655514cd98bd63836489a3/ui/webui/resources/cr_components/chromeos/network/network_config.js
[delete] https://crrev.com/87d70d4c17f9cfd0afbc8a5e3a54b1dd535b543b/ui/webui/resources/cr_components/chromeos/network/network_config_input.html
[modify] https://crrev.com/eb12d31bc08f755fce655514cd98bd63836489a3/ui/webui/resources/cr_components/chromeos/network/network_config_select.html
[modify] https://crrev.com/eb12d31bc08f755fce655514cd98bd63836489a3/ui/webui/resources/cr_components/chromeos/network/network_ip_config.html
[modify] https://crrev.com/eb12d31bc08f755fce655514cd98bd63836489a3/ui/webui/resources/cr_components/chromeos/network/network_nameservers.html
[add] https://crrev.com/eb12d31bc08f755fce655514cd98bd63836489a3/ui/webui/resources/cr_components/chromeos/network/network_password_input.html
[rename] https://crrev.com/eb12d31bc08f755fce655514cd98bd63836489a3/ui/webui/resources/cr_components/chromeos/network/network_password_input.js
[modify] https://crrev.com/eb12d31bc08f755fce655514cd98bd63836489a3/ui/webui/resources/cr_components/chromeos/network/network_property_list.html
[modify] https://crrev.com/eb12d31bc08f755fce655514cd98bd63836489a3/ui/webui/resources/cr_components/chromeos/network/network_property_list.js
[modify] https://crrev.com/eb12d31bc08f755fce655514cd98bd63836489a3/ui/webui/resources/cr_components/chromeos/network/network_proxy.html
[modify] https://crrev.com/eb12d31bc08f755fce655514cd98bd63836489a3/ui/webui/resources/cr_components/chromeos/network/network_proxy_input.html
[modify] https://crrev.com/eb12d31bc08f755fce655514cd98bd63836489a3/ui/webui/resources/cr_components/chromeos/network/network_proxy_input.js
[modify] https://crrev.com/eb12d31bc08f755fce655514cd98bd63836489a3/ui/webui/resources/cr_components/chromeos/network/network_shared_css.html
[modify] https://crrev.com/eb12d31bc08f755fce655514cd98bd63836489a3/ui/webui/resources/cr_components/chromeos/network/network_siminfo.html
[modify] https://crrev.com/eb12d31bc08f755fce655514cd98bd63836489a3/ui/webui/resources/cr_components/chromeos/network/network_siminfo.js
[modify] https://crrev.com/eb12d31bc08f755fce655514cd98bd63836489a3/ui/webui/resources/cr_components/cr_components_resources.grdp
[modify] https://crrev.com/eb12d31bc08f755fce655514cd98bd63836489a3/ui/webui/resources/cr_elements/cr_input/cr_input.html

Project Member

Comment 22 by bugdroid1@chromium.org, Jun 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/34e6c6afd8c6242e9a094782e739743da471e75a

commit 34e6c6afd8c6242e9a094782e739743da471e75a
Author: Scott Chen <scottchen@chromium.org>
Date: Fri Jun 08 22:30:01 2018

WebUI[MD-refresh]: replace paper-input with cr-input in cert-manager elements.

Bug:  832177 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Iac35742ffba55c0645a67f6a84813643076bd0e7
Reviewed-on: https://chromium-review.googlesource.com/1090003
Commit-Queue: Scott Chen <scottchen@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565760}
[modify] https://crrev.com/34e6c6afd8c6242e9a094782e739743da471e75a/chrome/test/data/webui/settings/certificate_manager_test.js
[modify] https://crrev.com/34e6c6afd8c6242e9a094782e739743da471e75a/ui/webui/resources/cr_components/certificate_manager/certificate_password_decryption_dialog.html
[modify] https://crrev.com/34e6c6afd8c6242e9a094782e739743da471e75a/ui/webui/resources/cr_components/certificate_manager/certificate_password_encryption_dialog.html

Project Member

Comment 24 by bugdroid1@chromium.org, Jun 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f5f57d603abf28015cca7a5b39f60851a2fa5c53

commit f5f57d603abf28015cca7a5b39f60851a2fa5c53
Author: Scott Chen <scottchen@chromium.org>
Date: Mon Jun 11 19:04:56 2018

WebUI[MD-refresh]: add settings-textarea to replace paper-textarea

This CL creates the settings-textarea element that inherits styling from
cr-input. This CL also replaces paper-textarea usage in address-edit-dialog,
as well as removing paper-textarea usage in a11y-tts page.

Bug:  832177 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ia225d6b15ae3562ebb0bee099bf9848fe504797b
Reviewed-on: https://chromium-review.googlesource.com/1087434
Commit-Queue: Scott Chen <scottchen@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566090}
[modify] https://crrev.com/f5f57d603abf28015cca7a5b39f60851a2fa5c53/chrome/browser/resources/settings/a11y_page/tts_subpage.html
[modify] https://crrev.com/f5f57d603abf28015cca7a5b39f60851a2fa5c53/chrome/browser/resources/settings/controls/BUILD.gn
[add] https://crrev.com/f5f57d603abf28015cca7a5b39f60851a2fa5c53/chrome/browser/resources/settings/controls/settings_textarea.html
[add] https://crrev.com/f5f57d603abf28015cca7a5b39f60851a2fa5c53/chrome/browser/resources/settings/controls/settings_textarea.js
[modify] https://crrev.com/f5f57d603abf28015cca7a5b39f60851a2fa5c53/chrome/browser/resources/settings/passwords_and_forms_page/address_edit_dialog.html
[modify] https://crrev.com/f5f57d603abf28015cca7a5b39f60851a2fa5c53/chrome/browser/resources/settings/settings_resources.grd
[modify] https://crrev.com/f5f57d603abf28015cca7a5b39f60851a2fa5c53/chrome/test/data/webui/cr_elements/cr_input_test.js
[modify] https://crrev.com/f5f57d603abf28015cca7a5b39f60851a2fa5c53/chrome/test/data/webui/settings/cr_settings_browsertest.js
[modify] https://crrev.com/f5f57d603abf28015cca7a5b39f60851a2fa5c53/chrome/test/data/webui/settings/settings_autofill_section_browsertest.js
[add] https://crrev.com/f5f57d603abf28015cca7a5b39f60851a2fa5c53/chrome/test/data/webui/settings/settings_textarea_tests.js
[modify] https://crrev.com/f5f57d603abf28015cca7a5b39f60851a2fa5c53/ui/webui/resources/cr_components/chromeos/network/network_property_list.html
[modify] https://crrev.com/f5f57d603abf28015cca7a5b39f60851a2fa5c53/ui/webui/resources/cr_elements/cr_input/cr_input.html
[add] https://crrev.com/f5f57d603abf28015cca7a5b39f60851a2fa5c53/ui/webui/resources/cr_elements/cr_input/cr_input_style_css.html
[modify] https://crrev.com/f5f57d603abf28015cca7a5b39f60851a2fa5c53/ui/webui/resources/cr_elements_resources.grdp

Project Member

Comment 25 by bugdroid1@chromium.org, Jun 12 2018

Project Member

Comment 26 by bugdroid1@chromium.org, Jun 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/497c159c986b8c1d0259ffd3bc45f173fdcc001c

commit 497c159c986b8c1d0259ffd3bc45f173fdcc001c
Author: Scott Chen <scottchen@chromium.org>
Date: Wed Jun 13 00:51:11 2018

Settings: removes mention of paper-input

Now that settings/ doesn't use any paper-input, this CL removes any mention
of it, including unused styles and closure compile.

Bug:  832177 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I1c1db7537958276851cd097fae3a558cd51230a2
Reviewed-on: https://chromium-review.googlesource.com/1098144
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566662}
[modify] https://crrev.com/497c159c986b8c1d0259ffd3bc45f173fdcc001c/chrome/browser/resources/settings/printing_page/cups_printer_shared_css.html
[modify] https://crrev.com/497c159c986b8c1d0259ffd3bc45f173fdcc001c/chrome/browser/resources/settings/settings_page/BUILD.gn
[modify] https://crrev.com/497c159c986b8c1d0259ffd3bc45f173fdcc001c/chrome/browser/resources/settings/settings_page/settings_subpage_search.js
[modify] https://crrev.com/497c159c986b8c1d0259ffd3bc45f173fdcc001c/chrome/browser/resources/settings/settings_shared_css.html

Project Member

Comment 27 by bugdroid1@chromium.org, Jun 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6aa4d573c8370aca03007081eccfeb7e18925cba

commit 6aa4d573c8370aca03007081eccfeb7e18925cba
Author: Scott Chen <scottchen@chromium.org>
Date: Fri Jun 15 21:51:43 2018

WebUI: cr-input automatically generates aria-label on <input>

This CL improves accessibility of cr-input by automatically generating
aria-label on <input>, taking a best guess based on cr-input's aria-label,
label, or placeholders.

Bug:  832177 
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I6847f16fa5ddca89691aca271ea077974ff5211e
Reviewed-on: https://chromium-review.googlesource.com/1097942
Commit-Queue: Scott Chen <scottchen@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567803}
[modify] https://crrev.com/6aa4d573c8370aca03007081eccfeb7e18925cba/chrome/browser/resources/settings/controls/settings_textarea.html
[modify] https://crrev.com/6aa4d573c8370aca03007081eccfeb7e18925cba/chrome/test/data/webui/cr_elements/cr_input_test.js
[modify] https://crrev.com/6aa4d573c8370aca03007081eccfeb7e18925cba/chrome/test/data/webui/settings/settings_textarea_tests.js
[modify] https://crrev.com/6aa4d573c8370aca03007081eccfeb7e18925cba/ui/webui/resources/cr_elements/cr_input/cr_input.js

Project Member

Comment 28 by bugdroid1@chromium.org, Jun 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9a7643defbc3e5114439b6d2240eed0715c1705c

commit 9a7643defbc3e5114439b6d2240eed0715c1705c
Author: Scott Chen <scottchen@chromium.org>
Date: Mon Jun 18 23:57:57 2018

WebUI[MD-refresh]: replace most paper-input with cr-inputs

This CL replaces most paper-inputs with cr-inputs within the code-base.
After this CL, the 3 places that still has paper-input remaining are:
- chrome/browser/resources/chromeos/login/
- chrome/browser/resources/pdf/
- ui/file_manager/

There are planned follow-up CLs to replace paper-input in the above 3
areas as well.

Bug:  832177 
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I7acc7e0a26a6bd3d40ec6828608717fd97bd0c73
Reviewed-on: https://chromium-review.googlesource.com/1086357
Commit-Queue: Scott Chen <scottchen@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568241}
[modify] https://crrev.com/9a7643defbc3e5114439b6d2240eed0715c1705c/chrome/browser/resources/chromeos/emulator/audio_settings.html
[modify] https://crrev.com/9a7643defbc3e5114439b6d2240eed0715c1705c/chrome/browser/resources/chromeos/emulator/battery_settings.html
[modify] https://crrev.com/9a7643defbc3e5114439b6d2240eed0715c1705c/chrome/browser/resources/chromeos/emulator/bluetooth_settings.html
[modify] https://crrev.com/9a7643defbc3e5114439b6d2240eed0715c1705c/chrome/browser/resources/chromeos/emulator/shared_styles.html
[modify] https://crrev.com/9a7643defbc3e5114439b6d2240eed0715c1705c/chrome/browser/resources/chromeos/zip_archiver/css/passphrase-dialog.css
[modify] https://crrev.com/9a7643defbc3e5114439b6d2240eed0715c1705c/chrome/browser/resources/chromeos/zip_archiver/html/passphrase-dialog.html
[modify] https://crrev.com/9a7643defbc3e5114439b6d2240eed0715c1705c/chrome/browser/resources/md_bookmarks/BUILD.gn
[modify] https://crrev.com/9a7643defbc3e5114439b6d2240eed0715c1705c/chrome/browser/resources/md_bookmarks/edit_dialog.html
[modify] https://crrev.com/9a7643defbc3e5114439b6d2240eed0715c1705c/chrome/browser/resources/md_bookmarks/edit_dialog.js
[modify] https://crrev.com/9a7643defbc3e5114439b6d2240eed0715c1705c/chrome/browser/resources/md_extensions/keyboard_shortcuts.html
[modify] https://crrev.com/9a7643defbc3e5114439b6d2240eed0715c1705c/chrome/browser/resources/md_extensions/kiosk_dialog.html
[modify] https://crrev.com/9a7643defbc3e5114439b6d2240eed0715c1705c/chrome/browser/resources/md_extensions/pack_dialog.html
[modify] https://crrev.com/9a7643defbc3e5114439b6d2240eed0715c1705c/chrome/browser/resources/md_extensions/shortcut_input.html
[modify] https://crrev.com/9a7643defbc3e5114439b6d2240eed0715c1705c/chrome/browser/resources/md_extensions/shortcut_input.js
[modify] https://crrev.com/9a7643defbc3e5114439b6d2240eed0715c1705c/chrome/browser/resources/md_user_manager/BUILD.gn
[modify] https://crrev.com/9a7643defbc3e5114439b6d2240eed0715c1705c/chrome/browser/resources/md_user_manager/create_profile.html
[modify] https://crrev.com/9a7643defbc3e5114439b6d2240eed0715c1705c/chrome/browser/resources/md_user_manager/create_profile.js
[modify] https://crrev.com/9a7643defbc3e5114439b6d2240eed0715c1705c/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.css
[modify] https://crrev.com/9a7643defbc3e5114439b6d2240eed0715c1705c/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.html
[modify] https://crrev.com/9a7643defbc3e5114439b6d2240eed0715c1705c/chrome/browser/resources/settings/people_page/setup_pin_dialog.html
[modify] https://crrev.com/9a7643defbc3e5114439b6d2240eed0715c1705c/chrome/browser/resources/settings/settings_page/settings_subpage_search.html
[modify] https://crrev.com/9a7643defbc3e5114439b6d2240eed0715c1705c/chrome/browser/ui/webui/settings/search_engines_handler.cc
[modify] https://crrev.com/9a7643defbc3e5114439b6d2240eed0715c1705c/chrome/test/data/webui/cr_elements/cr_dialog_test.js
[modify] https://crrev.com/9a7643defbc3e5114439b6d2240eed0715c1705c/chrome/test/data/webui/cr_elements/cr_input_test.js
[modify] https://crrev.com/9a7643defbc3e5114439b6d2240eed0715c1705c/chrome/test/data/webui/media_router/media_router_container_filter_tests.js
[modify] https://crrev.com/9a7643defbc3e5114439b6d2240eed0715c1705c/chrome/test/data/webui/settings/certificate_manager_test.js
[modify] https://crrev.com/9a7643defbc3e5114439b6d2240eed0715c1705c/chrome/test/data/webui/settings/search_engines_page_test.js
[modify] https://crrev.com/9a7643defbc3e5114439b6d2240eed0715c1705c/ui/webui/resources/cr_components/chromeos/BUILD.gn
[modify] https://crrev.com/9a7643defbc3e5114439b6d2240eed0715c1705c/ui/webui/resources/cr_components/chromeos/bluetooth_dialog.html
[modify] https://crrev.com/9a7643defbc3e5114439b6d2240eed0715c1705c/ui/webui/resources/cr_components/chromeos/bluetooth_dialog.js
[modify] https://crrev.com/9a7643defbc3e5114439b6d2240eed0715c1705c/ui/webui/resources/cr_components/chromeos/compiled_resources2.gyp
[modify] https://crrev.com/9a7643defbc3e5114439b6d2240eed0715c1705c/ui/webui/resources/cr_components/chromeos/quick_unlock/BUILD.gn
[modify] https://crrev.com/9a7643defbc3e5114439b6d2240eed0715c1705c/ui/webui/resources/cr_components/chromeos/quick_unlock/compiled_resources2.gyp
[modify] https://crrev.com/9a7643defbc3e5114439b6d2240eed0715c1705c/ui/webui/resources/cr_components/chromeos/quick_unlock/pin_keyboard.html
[modify] https://crrev.com/9a7643defbc3e5114439b6d2240eed0715c1705c/ui/webui/resources/cr_components/chromeos/quick_unlock/pin_keyboard.js
[add] https://crrev.com/9a7643defbc3e5114439b6d2240eed0715c1705c/ui/webui/resources/cr_elements/cr_input/compiled_resources2.gyp
[modify] https://crrev.com/9a7643defbc3e5114439b6d2240eed0715c1705c/ui/webui/resources/cr_elements/cr_input/cr_input.html
[modify] https://crrev.com/9a7643defbc3e5114439b6d2240eed0715c1705c/ui/webui/resources/cr_elements/cr_input/cr_input.js
[modify] https://crrev.com/9a7643defbc3e5114439b6d2240eed0715c1705c/ui/webui/resources/cr_elements/cr_input/cr_input_style_css.html

Project Member

Comment 29 by bugdroid1@chromium.org, Jun 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e25ce18197c99f1b063bf85e816562a5c8340214

commit e25ce18197c99f1b063bf85e816562a5c8340214
Author: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Date: Tue Jun 19 03:29:55 2018

Revert "WebUI[MD-refresh]: replace most paper-input with cr-inputs"

This reverts commit 9a7643defbc3e5114439b6d2240eed0715c1705c.

Reason for revert: 

MediaRouterElementsBrowserTest.MediaRouterContainerFilterPart1 became
flaky in Mac10.11, 10.12, and 10.13 after this landed.

https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=MediaRouterElementsBrowserTest.MediaRouterContainerFilterPart1

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.12%20Tests/13846

[ RUN      ] MediaRouterElementsBrowserTest.MediaRouterContainerFilterPart1
[35158:6151:0618/184304.560701:WARNING:notification_platform_bridge_mac.mm(510)] AlertNotificationService: XPC connection invalidated.
[35158:775:0618/184305.696851:WARNING:CONSOLE(0)] "Styling master document from stylesheets defined in HTML Imports is deprecated. Please refer to https://goo.gl/EGXzpw for possible migration paths.", source:  (0)
[35158:775:0618/184306.249427:INFO:CONSOLE(1236)] "Running TestCase MediaRouterElementsBrowserTest.MAYBE_MediaRouterContainerFilterPart1", source: file:///b/s/w/ir/chrome/test/data/webui/test_api.js (1236)
[35158:775:0618/184306.545042:WARNING:CONSOLE(16)] "Invalid keyframe value for property marginBottom: 44", source: chrome://resources/polymer/v1_0/web-animations-js/web-animations-next-lite.min.js (16)
[35158:775:0618/184306.545170:WARNING:CONSOLE(16)] "Invalid keyframe value for property marginBottom: 44", source: chrome://resources/polymer/v1_0/web-animations-js/web-animations-next-lite.min.js (16)
[35158:775:0618/184306.602655:ERROR:CONSOLE(48)] "Mocha test failed: MediaRouterContainerFilterPart1 focus sink search input
Error: Script error. (:0)
", source: file:///b/s/w/ir/chrome/test/data/webui/mocha_adapter.js (48)
[35158:775:0618/184306.602796:ERROR:CONSOLE(206)] "Uncaught AssertionError: expected 'sink-list' to equal 'filter'", source: file:///b/s/w/ir/third_party/chaijs/chai.js (206)
[35158:775:0618/184306.688827:WARNING:CONSOLE(16)] "Invalid keyframe value for property marginBottom: 44", source: chrome://resources/polymer/v1_0/web-animations-js/web-animations-next-lite.min.js (16)
[35158:775:0618/184306.688978:WARNING:CONSOLE(16)] "Invalid keyframe value for property marginBottom: 44", source: chrome://resources/polymer/v1_0/web-animations-js/web-animations-next-lite.min.js (16)
[35158:775:0618/184306.878527:WARNING:CONSOLE(16)] "Invalid keyframe value for property marginBottom: 44", source: chrome://resources/polymer/v1_0/web-animations-js/web-animations-next-lite.min.js (16)
[35158:775:0618/184306.878646:WARNING:CONSOLE(16)] "Invalid keyframe value for property marginBottom: 44", source: chrome://resources/polymer/v1_0/web-animations-js/web-animations-next-lite.min.js (16)
[35158:775:0618/184307.420478:WARNING:CONSOLE(16)] "Invalid keyframe value for property marginBottom: 44", source: chrome://resources/polymer/v1_0/web-animations-js/web-animations-next-lite.min.js (16)
[35158:775:0618/184307.420605:WARNING:CONSOLE(16)] "Invalid keyframe value for property marginBottom: 44", source: chrome://resources/polymer/v1_0/web-animations-js/web-animations-next-lite.min.js (16)
[35158:775:0618/184308.705393:WARNING:CONSOLE(16)] "Invalid keyframe value for property marginBottom: 44", source: chrome://resources/polymer/v1_0/web-animations-js/web-animations-next-lite.min.js (16)
[35158:775:0618/184308.705526:WARNING:CONSOLE(16)] "Invalid keyframe value for property marginBottom: 44", source: chrome://resources/polymer/v1_0/web-animations-js/web-animations-next-lite.min.js (16)
[35158:775:0618/184308.710999:WARNING:CONSOLE(16)] "Invalid keyframe value for property marginBottom: 44", source: chrome://resources/polymer/v1_0/web-animations-js/web-animations-next-lite.min.js (16)
[35158:775:0618/184308.711145:WARNING:CONSOLE(16)] "Invalid keyframe value for property marginBottom: 44", source: chrome://resources/polymer/v1_0/web-animations-js/web-animations-next-lite.min.js (16)
[35158:775:0618/184308.845267:WARNING:CONSOLE(16)] "Invalid keyframe value for property marginBottom: 44", source: chrome://resources/polymer/v1_0/web-animations-js/web-animations-next-lite.min.js (16)
[35158:775:0618/184308.845353:WARNING:CONSOLE(16)] "Invalid keyframe value for property marginBottom: 44", source: chrome://resources/polymer/v1_0/web-animations-js/web-animations-next-lite.min.js (16)
[35158:775:0618/184308.850290:ERROR:web_ui_test_handler.cc(100)] Test Errors: 1/12 tests had failed assertions.

Original change's description:
> WebUI[MD-refresh]: replace most paper-input with cr-inputs
> 
> This CL replaces most paper-inputs with cr-inputs within the code-base.
> After this CL, the 3 places that still has paper-input remaining are:
> - chrome/browser/resources/chromeos/login/
> - chrome/browser/resources/pdf/
> - ui/file_manager/
> 
> There are planned follow-up CLs to replace paper-input in the above 3
> areas as well.
> 
> Bug:  832177 
> Cq-Include-Trybots: luci.chromium.try:closure_compilation
> Change-Id: I7acc7e0a26a6bd3d40ec6828608717fd97bd0c73
> Reviewed-on: https://chromium-review.googlesource.com/1086357
> Commit-Queue: Scott Chen <scottchen@chromium.org>
> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#568241}

TBR=dpapad@chromium.org,scottchen@chromium.org

Change-Id: I1dd101893378c8354c48e72d9f56231ec1ee9850
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  832177 
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Reviewed-on: https://chromium-review.googlesource.com/1105207
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568320}
[modify] https://crrev.com/e25ce18197c99f1b063bf85e816562a5c8340214/chrome/browser/resources/chromeos/emulator/audio_settings.html
[modify] https://crrev.com/e25ce18197c99f1b063bf85e816562a5c8340214/chrome/browser/resources/chromeos/emulator/battery_settings.html
[modify] https://crrev.com/e25ce18197c99f1b063bf85e816562a5c8340214/chrome/browser/resources/chromeos/emulator/bluetooth_settings.html
[modify] https://crrev.com/e25ce18197c99f1b063bf85e816562a5c8340214/chrome/browser/resources/chromeos/emulator/shared_styles.html
[modify] https://crrev.com/e25ce18197c99f1b063bf85e816562a5c8340214/chrome/browser/resources/chromeos/zip_archiver/css/passphrase-dialog.css
[modify] https://crrev.com/e25ce18197c99f1b063bf85e816562a5c8340214/chrome/browser/resources/chromeos/zip_archiver/html/passphrase-dialog.html
[modify] https://crrev.com/e25ce18197c99f1b063bf85e816562a5c8340214/chrome/browser/resources/md_bookmarks/BUILD.gn
[modify] https://crrev.com/e25ce18197c99f1b063bf85e816562a5c8340214/chrome/browser/resources/md_bookmarks/edit_dialog.html
[modify] https://crrev.com/e25ce18197c99f1b063bf85e816562a5c8340214/chrome/browser/resources/md_bookmarks/edit_dialog.js
[modify] https://crrev.com/e25ce18197c99f1b063bf85e816562a5c8340214/chrome/browser/resources/md_extensions/keyboard_shortcuts.html
[modify] https://crrev.com/e25ce18197c99f1b063bf85e816562a5c8340214/chrome/browser/resources/md_extensions/kiosk_dialog.html
[modify] https://crrev.com/e25ce18197c99f1b063bf85e816562a5c8340214/chrome/browser/resources/md_extensions/pack_dialog.html
[modify] https://crrev.com/e25ce18197c99f1b063bf85e816562a5c8340214/chrome/browser/resources/md_extensions/shortcut_input.html
[modify] https://crrev.com/e25ce18197c99f1b063bf85e816562a5c8340214/chrome/browser/resources/md_extensions/shortcut_input.js
[modify] https://crrev.com/e25ce18197c99f1b063bf85e816562a5c8340214/chrome/browser/resources/md_user_manager/BUILD.gn
[modify] https://crrev.com/e25ce18197c99f1b063bf85e816562a5c8340214/chrome/browser/resources/md_user_manager/create_profile.html
[modify] https://crrev.com/e25ce18197c99f1b063bf85e816562a5c8340214/chrome/browser/resources/md_user_manager/create_profile.js
[modify] https://crrev.com/e25ce18197c99f1b063bf85e816562a5c8340214/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.css
[modify] https://crrev.com/e25ce18197c99f1b063bf85e816562a5c8340214/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.html
[modify] https://crrev.com/e25ce18197c99f1b063bf85e816562a5c8340214/chrome/browser/resources/settings/people_page/setup_pin_dialog.html
[modify] https://crrev.com/e25ce18197c99f1b063bf85e816562a5c8340214/chrome/browser/resources/settings/settings_page/settings_subpage_search.html
[modify] https://crrev.com/e25ce18197c99f1b063bf85e816562a5c8340214/chrome/browser/ui/webui/settings/search_engines_handler.cc
[modify] https://crrev.com/e25ce18197c99f1b063bf85e816562a5c8340214/chrome/test/data/webui/cr_elements/cr_dialog_test.js
[modify] https://crrev.com/e25ce18197c99f1b063bf85e816562a5c8340214/chrome/test/data/webui/cr_elements/cr_input_test.js
[modify] https://crrev.com/e25ce18197c99f1b063bf85e816562a5c8340214/chrome/test/data/webui/media_router/media_router_container_filter_tests.js
[modify] https://crrev.com/e25ce18197c99f1b063bf85e816562a5c8340214/chrome/test/data/webui/settings/certificate_manager_test.js
[modify] https://crrev.com/e25ce18197c99f1b063bf85e816562a5c8340214/chrome/test/data/webui/settings/search_engines_page_test.js
[modify] https://crrev.com/e25ce18197c99f1b063bf85e816562a5c8340214/ui/webui/resources/cr_components/chromeos/BUILD.gn
[modify] https://crrev.com/e25ce18197c99f1b063bf85e816562a5c8340214/ui/webui/resources/cr_components/chromeos/bluetooth_dialog.html
[modify] https://crrev.com/e25ce18197c99f1b063bf85e816562a5c8340214/ui/webui/resources/cr_components/chromeos/bluetooth_dialog.js
[modify] https://crrev.com/e25ce18197c99f1b063bf85e816562a5c8340214/ui/webui/resources/cr_components/chromeos/compiled_resources2.gyp
[modify] https://crrev.com/e25ce18197c99f1b063bf85e816562a5c8340214/ui/webui/resources/cr_components/chromeos/quick_unlock/BUILD.gn
[modify] https://crrev.com/e25ce18197c99f1b063bf85e816562a5c8340214/ui/webui/resources/cr_components/chromeos/quick_unlock/compiled_resources2.gyp
[modify] https://crrev.com/e25ce18197c99f1b063bf85e816562a5c8340214/ui/webui/resources/cr_components/chromeos/quick_unlock/pin_keyboard.html
[modify] https://crrev.com/e25ce18197c99f1b063bf85e816562a5c8340214/ui/webui/resources/cr_components/chromeos/quick_unlock/pin_keyboard.js
[delete] https://crrev.com/156afe2aa39dd26b9a5ab769b586449c312ad361/ui/webui/resources/cr_elements/cr_input/compiled_resources2.gyp
[modify] https://crrev.com/e25ce18197c99f1b063bf85e816562a5c8340214/ui/webui/resources/cr_elements/cr_input/cr_input.html
[modify] https://crrev.com/e25ce18197c99f1b063bf85e816562a5c8340214/ui/webui/resources/cr_elements/cr_input/cr_input.js
[modify] https://crrev.com/e25ce18197c99f1b063bf85e816562a5c8340214/ui/webui/resources/cr_elements/cr_input/cr_input_style_css.html

Project Member

Comment 30 by bugdroid1@chromium.org, Jun 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ae83ae04bd3af244b483b2ae7431881dd093d6d5

commit ae83ae04bd3af244b483b2ae7431881dd093d6d5
Author: Scott Chen <scottchen@chromium.org>
Date: Tue Jun 19 23:27:46 2018

Reland "WebUI[MD-refresh]: replace most paper-input with cr-inputs"

This CL removes all changes from media_router, which were causing flakey
tests. The intention is to reland those separately as a follow-up CL.

Bug:  832177 
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I68c653f4e492807988cdb09c2387e42111bd8db7
Reviewed-on: https://chromium-review.googlesource.com/1106419
Commit-Queue: Scott Chen <scottchen@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568640}
[modify] https://crrev.com/ae83ae04bd3af244b483b2ae7431881dd093d6d5/chrome/browser/resources/chromeos/emulator/audio_settings.html
[modify] https://crrev.com/ae83ae04bd3af244b483b2ae7431881dd093d6d5/chrome/browser/resources/chromeos/emulator/battery_settings.html
[modify] https://crrev.com/ae83ae04bd3af244b483b2ae7431881dd093d6d5/chrome/browser/resources/chromeos/emulator/bluetooth_settings.html
[modify] https://crrev.com/ae83ae04bd3af244b483b2ae7431881dd093d6d5/chrome/browser/resources/chromeos/emulator/shared_styles.html
[modify] https://crrev.com/ae83ae04bd3af244b483b2ae7431881dd093d6d5/chrome/browser/resources/chromeos/zip_archiver/css/passphrase-dialog.css
[modify] https://crrev.com/ae83ae04bd3af244b483b2ae7431881dd093d6d5/chrome/browser/resources/chromeos/zip_archiver/html/passphrase-dialog.html
[modify] https://crrev.com/ae83ae04bd3af244b483b2ae7431881dd093d6d5/chrome/browser/resources/md_bookmarks/BUILD.gn
[modify] https://crrev.com/ae83ae04bd3af244b483b2ae7431881dd093d6d5/chrome/browser/resources/md_bookmarks/edit_dialog.html
[modify] https://crrev.com/ae83ae04bd3af244b483b2ae7431881dd093d6d5/chrome/browser/resources/md_bookmarks/edit_dialog.js
[modify] https://crrev.com/ae83ae04bd3af244b483b2ae7431881dd093d6d5/chrome/browser/resources/md_extensions/keyboard_shortcuts.html
[modify] https://crrev.com/ae83ae04bd3af244b483b2ae7431881dd093d6d5/chrome/browser/resources/md_extensions/kiosk_dialog.html
[modify] https://crrev.com/ae83ae04bd3af244b483b2ae7431881dd093d6d5/chrome/browser/resources/md_extensions/pack_dialog.html
[modify] https://crrev.com/ae83ae04bd3af244b483b2ae7431881dd093d6d5/chrome/browser/resources/md_extensions/shortcut_input.html
[modify] https://crrev.com/ae83ae04bd3af244b483b2ae7431881dd093d6d5/chrome/browser/resources/md_extensions/shortcut_input.js
[modify] https://crrev.com/ae83ae04bd3af244b483b2ae7431881dd093d6d5/chrome/browser/resources/md_user_manager/BUILD.gn
[modify] https://crrev.com/ae83ae04bd3af244b483b2ae7431881dd093d6d5/chrome/browser/resources/md_user_manager/create_profile.html
[modify] https://crrev.com/ae83ae04bd3af244b483b2ae7431881dd093d6d5/chrome/browser/resources/md_user_manager/create_profile.js
[modify] https://crrev.com/ae83ae04bd3af244b483b2ae7431881dd093d6d5/chrome/browser/resources/settings/people_page/setup_pin_dialog.html
[modify] https://crrev.com/ae83ae04bd3af244b483b2ae7431881dd093d6d5/chrome/browser/resources/settings/settings_page/settings_subpage_search.html
[modify] https://crrev.com/ae83ae04bd3af244b483b2ae7431881dd093d6d5/chrome/browser/ui/webui/settings/search_engines_handler.cc
[modify] https://crrev.com/ae83ae04bd3af244b483b2ae7431881dd093d6d5/chrome/test/data/webui/cr_elements/cr_dialog_test.js
[modify] https://crrev.com/ae83ae04bd3af244b483b2ae7431881dd093d6d5/chrome/test/data/webui/cr_elements/cr_input_test.js
[modify] https://crrev.com/ae83ae04bd3af244b483b2ae7431881dd093d6d5/chrome/test/data/webui/settings/certificate_manager_test.js
[modify] https://crrev.com/ae83ae04bd3af244b483b2ae7431881dd093d6d5/chrome/test/data/webui/settings/search_engines_page_test.js
[modify] https://crrev.com/ae83ae04bd3af244b483b2ae7431881dd093d6d5/ui/webui/resources/cr_components/chromeos/BUILD.gn
[modify] https://crrev.com/ae83ae04bd3af244b483b2ae7431881dd093d6d5/ui/webui/resources/cr_components/chromeos/bluetooth_dialog.html
[modify] https://crrev.com/ae83ae04bd3af244b483b2ae7431881dd093d6d5/ui/webui/resources/cr_components/chromeos/bluetooth_dialog.js
[modify] https://crrev.com/ae83ae04bd3af244b483b2ae7431881dd093d6d5/ui/webui/resources/cr_components/chromeos/compiled_resources2.gyp
[modify] https://crrev.com/ae83ae04bd3af244b483b2ae7431881dd093d6d5/ui/webui/resources/cr_components/chromeos/quick_unlock/BUILD.gn
[modify] https://crrev.com/ae83ae04bd3af244b483b2ae7431881dd093d6d5/ui/webui/resources/cr_components/chromeos/quick_unlock/compiled_resources2.gyp
[modify] https://crrev.com/ae83ae04bd3af244b483b2ae7431881dd093d6d5/ui/webui/resources/cr_components/chromeos/quick_unlock/pin_keyboard.html
[modify] https://crrev.com/ae83ae04bd3af244b483b2ae7431881dd093d6d5/ui/webui/resources/cr_components/chromeos/quick_unlock/pin_keyboard.js
[add] https://crrev.com/ae83ae04bd3af244b483b2ae7431881dd093d6d5/ui/webui/resources/cr_elements/cr_input/compiled_resources2.gyp
[modify] https://crrev.com/ae83ae04bd3af244b483b2ae7431881dd093d6d5/ui/webui/resources/cr_elements/cr_input/cr_input.html
[modify] https://crrev.com/ae83ae04bd3af244b483b2ae7431881dd093d6d5/ui/webui/resources/cr_elements/cr_input/cr_input.js
[modify] https://crrev.com/ae83ae04bd3af244b483b2ae7431881dd093d6d5/ui/webui/resources/cr_elements/cr_input/cr_input_style_css.html

Project Member

Comment 31 by bugdroid1@chromium.org, Jun 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/944030dfcb0698b072b052bd03ebc3f8ef7d4b7d

commit 944030dfcb0698b072b052bd03ebc3f8ef7d4b7d
Author: Scott Chen <scottchen@chromium.org>
Date: Thu Jun 21 23:36:57 2018

WebUI: rework cr-input tabindex and keyboard focus logic

This CL makes it possible to give cr-input a tabindex larger than 0 and
have the tab order work as expected.

Bug:  832177 
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I42b25c70ac614360c95140d026755ae66c3cae8c
Reviewed-on: https://chromium-review.googlesource.com/1103002
Commit-Queue: Scott Chen <scottchen@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569450}
[modify] https://crrev.com/944030dfcb0698b072b052bd03ebc3f8ef7d4b7d/chrome/browser/resources/settings/appearance_page/home_url_input.html
[modify] https://crrev.com/944030dfcb0698b072b052bd03ebc3f8ef7d4b7d/chrome/browser/resources/settings/people_page/password_prompt_dialog.js
[modify] https://crrev.com/944030dfcb0698b072b052bd03ebc3f8ef7d4b7d/chrome/test/data/webui/cr_elements/cr_input_test.js
[modify] https://crrev.com/944030dfcb0698b072b052bd03ebc3f8ef7d4b7d/ui/webui/resources/cr_elements/cr_input/cr_input.html
[modify] https://crrev.com/944030dfcb0698b072b052bd03ebc3f8ef7d4b7d/ui/webui/resources/cr_elements/cr_input/cr_input.js

Project Member

Comment 32 by bugdroid1@chromium.org, Jun 21 2018

Project Member

Comment 33 by bugdroid1@chromium.org, Jun 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/31e592b5823badfedeeb824ab6521615e5f78329

commit 31e592b5823badfedeeb824ab6521615e5f78329
Author: Scott Chen <scottchen@chromium.org>
Date: Mon Jun 25 22:16:46 2018

WebUI[MD-refresh]: fix various tabindex issues for cr-input

This fixes a few bugs introduced by 1103002 to cr-input, as well as making
cr-input more robust against edge-cases:

likely cases:
- |tabindex| initially set by element are mistakenly set to 0.
- if element has both |tabindex| and |disabled| set, element
  would not know what to set |tabindex| to once |disabled| is removed.
- clicking on a |disabled| cr-input would set its |tabindex| to 0 again.

edge case:
- if |disabled| is changed to true in the same cycle as pointerdown is fired,
  then |tabindex| state gets messed up.

Bug:  832177 ,  856118 
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I91161ecde90e816340aa38db4646b3f8eedd7a8b
Reviewed-on: https://chromium-review.googlesource.com/1111201
Commit-Queue: Scott Chen <scottchen@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570198}
[modify] https://crrev.com/31e592b5823badfedeeb824ab6521615e5f78329/chrome/browser/resources/settings/people_page/sync_page.js
[modify] https://crrev.com/31e592b5823badfedeeb824ab6521615e5f78329/chrome/test/data/webui/cr_elements/cr_input_test.js
[modify] https://crrev.com/31e592b5823badfedeeb824ab6521615e5f78329/ui/webui/resources/cr_elements/cr_input/cr_input.js
[modify] https://crrev.com/31e592b5823badfedeeb824ab6521615e5f78329/ui/webui/resources/cr_elements/cr_input/cr_input_style_css.html

Weifang - here are the before/after photos for the search box and save-as box before and after this change.

With UI approval, we can land the patch.
save-as-before.png
5.9 KB View Download
search-box-before.png
5.0 KB View Download
save-as-after.png
11.9 KB View Download
search-after.png
2.3 KB View Download
Cc: sgabr...@chromium.org mcirimele@chromium.org
These UI updates look good to me, but adding in mcirimele@ and sgabriel@ to advise with their designer eyes. :)
Is the update only about the underline? The spec is using quite different textfield designs.
Project Member

Comment 37 by bugdroid1@chromium.org, Jun 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c2670bca2614e9250ef3bd5af77d47067e82738c

commit c2670bca2614e9250ef3bd5af77d47067e82738c
Author: Scott Chen <scottchen@chromium.org>
Date: Thu Jun 28 18:54:54 2018

WebUI[MD-refresh]: switch file-manager paper-inputs to cr-inputs

Bug:  832177 
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I552d8ba9107b82aca3a24d24299181b788fc54d8
Reviewed-on: https://chromium-review.googlesource.com/1108918
Commit-Queue: Scott Chen <scottchen@chromium.org>
Reviewed-by: Sasha Morrissey <sashab@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571214}
[modify] https://crrev.com/c2670bca2614e9250ef3bd5af77d47067e82738c/ui/file_manager/file_manager/foreground/css/file_manager.css
[modify] https://crrev.com/c2670bca2614e9250ef3bd5af77d47067e82738c/ui/file_manager/file_manager/foreground/elements/elements_bundle.html
[modify] https://crrev.com/c2670bca2614e9250ef3bd5af77d47067e82738c/ui/file_manager/file_manager/foreground/js/BUILD.gn
[modify] https://crrev.com/c2670bca2614e9250ef3bd5af77d47067e82738c/ui/file_manager/file_manager/foreground/js/elements_importer.js
[modify] https://crrev.com/c2670bca2614e9250ef3bd5af77d47067e82738c/ui/file_manager/file_manager/foreground/js/file_manager.js
[modify] https://crrev.com/c2670bca2614e9250ef3bd5af77d47067e82738c/ui/file_manager/file_manager/foreground/js/file_manager_commands.js
[modify] https://crrev.com/c2670bca2614e9250ef3bd5af77d47067e82738c/ui/file_manager/file_manager/foreground/js/ui/BUILD.gn
[modify] https://crrev.com/c2670bca2614e9250ef3bd5af77d47067e82738c/ui/file_manager/file_manager/foreground/js/ui/dialog_footer.js
[modify] https://crrev.com/c2670bca2614e9250ef3bd5af77d47067e82738c/ui/file_manager/file_manager/foreground/js/ui/search_box.js
[modify] https://crrev.com/c2670bca2614e9250ef3bd5af77d47067e82738c/ui/file_manager/file_manager/main.html
[modify] https://crrev.com/c2670bca2614e9250ef3bd5af77d47067e82738c/ui/file_manager/file_manager/test/scripts/create_test_main.py
[modify] https://crrev.com/c2670bca2614e9250ef3bd5af77d47067e82738c/ui/file_manager/gallery/css/gallery.css
[modify] https://crrev.com/c2670bca2614e9250ef3bd5af77d47067e82738c/ui/file_manager/gallery/gallery.html
[modify] https://crrev.com/c2670bca2614e9250ef3bd5af77d47067e82738c/ui/file_manager/gallery/js/gallery.js
[modify] https://crrev.com/c2670bca2614e9250ef3bd5af77d47067e82738c/ui/file_manager/gallery/js/image_editor/image_editor_toolbar.js
[modify] https://crrev.com/c2670bca2614e9250ef3bd5af77d47067e82738c/ui/file_manager/gallery/js/test_util.js
[modify] https://crrev.com/c2670bca2614e9250ef3bd5af77d47067e82738c/ui/file_manager/integration_tests/file_manager/context_menu.js
[modify] https://crrev.com/c2670bca2614e9250ef3bd5af77d47067e82738c/ui/file_manager/integration_tests/file_manager/drive_specific.js
[modify] https://crrev.com/c2670bca2614e9250ef3bd5af77d47067e82738c/ui/file_manager/integration_tests/file_manager/file_display.js
[modify] https://crrev.com/c2670bca2614e9250ef3bd5af77d47067e82738c/ui/file_manager/integration_tests/file_manager/tab_index.js
[modify] https://crrev.com/c2670bca2614e9250ef3bd5af77d47067e82738c/ui/file_manager/integration_tests/gallery/photo_editor.js
[modify] https://crrev.com/c2670bca2614e9250ef3bd5af77d47067e82738c/ui/file_manager/integration_tests/remote_call.js
[modify] https://crrev.com/c2670bca2614e9250ef3bd5af77d47067e82738c/ui/webui/resources/cr_elements/cr_input/cr_input.html
[modify] https://crrev.com/c2670bca2614e9250ef3bd5af77d47067e82738c/ui/webui/resources/cr_elements/cr_input/cr_input_style_css.html

Project Member

Comment 38 by bugdroid1@chromium.org, Jun 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/223a305365e03cc859d26d6b996794d2f2768848

commit 223a305365e03cc859d26d6b996794d2f2768848
Author: Scott Chen <scottchen@chromium.org>
Date: Thu Jun 28 22:50:02 2018

WebUI[MD-refresh]: provide better way to select text within cr-input

This CL provides a more encapsulated way to focus and select the text
within cr-input.

Bug:  832177 
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: Ie1bf83d51fd706adc18b879251639c78381dc4fd
Reviewed-on: https://chromium-review.googlesource.com/1114254
Commit-Queue: Scott Chen <scottchen@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Sasha Morrissey <sashab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571308}
[modify] https://crrev.com/223a305365e03cc859d26d6b996794d2f2768848/chrome/browser/resources/pdf/elements/viewer-page-selector/viewer-page-selector.js
[modify] https://crrev.com/223a305365e03cc859d26d6b996794d2f2768848/chrome/browser/resources/pdf/elements/viewer-password-screen/BUILD.gn
[modify] https://crrev.com/223a305365e03cc859d26d6b996794d2f2768848/chrome/browser/resources/pdf/elements/viewer-password-screen/viewer-password-screen.js
[modify] https://crrev.com/223a305365e03cc859d26d6b996794d2f2768848/chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.js
[modify] https://crrev.com/223a305365e03cc859d26d6b996794d2f2768848/chrome/browser/resources/settings/people_page/password_prompt_dialog.js
[modify] https://crrev.com/223a305365e03cc859d26d6b996794d2f2768848/chrome/test/data/webui/cr_elements/cr_input_test.js
[modify] https://crrev.com/223a305365e03cc859d26d6b996794d2f2768848/ui/file_manager/file_manager/foreground/js/file_manager_commands.js
[modify] https://crrev.com/223a305365e03cc859d26d6b996794d2f2768848/ui/file_manager/file_manager/foreground/js/ui/dialog_footer.js
[modify] https://crrev.com/223a305365e03cc859d26d6b996794d2f2768848/ui/webui/resources/cr_elements/cr_input/BUILD.gn
[modify] https://crrev.com/223a305365e03cc859d26d6b996794d2f2768848/ui/webui/resources/cr_elements/cr_input/cr_input.html
[modify] https://crrev.com/223a305365e03cc859d26d6b996794d2f2768848/ui/webui/resources/cr_elements/cr_input/cr_input.js

Labels: -Pri-2 Pri-1
Oops, sorry... This landed by accident ^_^; I guess now you can install a version of Canary and see it for yourself? Lol

As for the underline - yes, I think this is the only noticeable change. This is really a backend-only change, it's meant to have no effect on the front-end but that's not entirely possible, so this is as close as we could get. Do you think this is too big an impact to our users?

We can roll it back if needed, or change the underline style. Just let scottchen@ know, we won't close this bug until you're happy and I'm making it P1 for M69 :)
I'm just curious as to what is changed. 
If there's no change in the front-end that's fine.
The only noticeable change is the color of the underline, and slight alignment adjustment - originally there was an issue where the icon buttons in the top toolbar will shift up/down when the search input gets open/closed, and I was able to fix that with the new input I'm using.

Also in gallery view (for images), the file-name input as well as width/height input in edit-mode is shifted a couple pixels up/down (it didn't seem to be completely vertically centered before so I adjusted that with my change).

That's about it, nothing incredibly noticeable.
Status: Fixed (was: Started)
Thanks scottchen; this SGTM. :)

Sign in to add a comment