New issue
Advanced search Search tips

Issue 832175 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

Syntax highlighting for TSX

Project Member Reported by allada@chromium.org, Apr 12 2018

Issue description

Typescript + JSX (ie: tsx) has been apart of codemirror for a bit now, can we add this to devtools too?

Added to codemirror as of:
https://github.com/codemirror/CodeMirror/issues/3893
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2cd6384564ee20982b15e863c62fa726d76b2985

commit 2cd6384564ee20982b15e863c62fa726d76b2985
Author: Joel Einbinder <einbinder@chromium.org>
Date: Mon Apr 16 23:02:24 2018

DevTools: Highlight tsx files

Bug:  832175 
Change-Id: I8723a8d5e92d1439760ae6a40b0cb444aad00531
Reviewed-on: https://chromium-review.googlesource.com/1014253
Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org>
Commit-Queue: Joel Einbinder <einbinder@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551160}
[modify] https://crrev.com/2cd6384564ee20982b15e863c62fa726d76b2985/third_party/blink/renderer/devtools/front_end/cm_modes/module.json
[modify] https://crrev.com/2cd6384564ee20982b15e863c62fa726d76b2985/third_party/blink/renderer/devtools/front_end/common/ResourceType.js

Status: Fixed (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 17 2018

Labels: merge-merged-testbranch
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2cd6384564ee20982b15e863c62fa726d76b2985

commit 2cd6384564ee20982b15e863c62fa726d76b2985
Author: Joel Einbinder <einbinder@chromium.org>
Date: Mon Apr 16 23:02:24 2018

DevTools: Highlight tsx files

Bug:  832175 
Change-Id: I8723a8d5e92d1439760ae6a40b0cb444aad00531
Reviewed-on: https://chromium-review.googlesource.com/1014253
Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org>
Commit-Queue: Joel Einbinder <einbinder@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551160}
[modify] https://crrev.com/2cd6384564ee20982b15e863c62fa726d76b2985/third_party/blink/renderer/devtools/front_end/cm_modes/module.json
[modify] https://crrev.com/2cd6384564ee20982b15e863c62fa726d76b2985/third_party/blink/renderer/devtools/front_end/common/ResourceType.js

Sign in to add a comment