New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 832158 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 829949



Sign in to add a comment

[Findit] Flake Analyzer - Assertion error in _ParseFlakeSwarmingTaskOutput

Project Member Reported by wylieb@chromium.org, Apr 12 2018

Issue description

Looks like it might be the result of a failed swarming task

https://pantheon.corp.google.com/errors/CPnQl-ej_4rz2QE?time=P1D&project=findit-for-me
 

Comment 1 by wylieb@chromium.org, Apr 12 2018

Blocking: 829949

Comment 2 by wylieb@chromium.org, Apr 12 2018

Owner: wylieb@chromium.org

Comment 3 by wylieb@chromium.org, Apr 12 2018

Labels: -Pri-0 Pri-1
Case for this is:

suite.testA is run, the data comes back is one of the three

suite.PRE_testA P
suite.testA P or F

suite.PRE_testA F
suite.testA missing!

to fix this, if suite.testA is missing treat suite.PRE_testA as suite.testA

Comment 4 by wylieb@chromium.org, Apr 12 2018

Status: Assigned (was: Available)
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/eecfb6d2aeb7fb4f5b8e74c2051e6e7afc5cbeca

commit eecfb6d2aeb7fb4f5b8e74c2051e6e7afc5cbeca
Author: Brandon Wylie <wylieb@chromium.org>
Date: Thu Apr 12 22:48:24 2018

[Findit] Flake Analyzer - Add support for PRE_test runs

Right now we assume that there is only one test reslt in test results,
which isn't true in the case where the test has a PRE_test hook.

This CL adds support for three cases
1. No prerun, and test results exist.
2. Prerun, but test results exist.
3. Prerun and no test results exist.

Bug: 832158
Change-Id: I4888dc87436926e98f361a2afea2e6e8a77a458b
Reviewed-on: https://chromium-review.googlesource.com/1010832
Commit-Queue: Brandon Wylie <wylieb@chromium.org>
Reviewed-by: Shuotao Gao <stgao@chromium.org>

[modify] https://crrev.com/eecfb6d2aeb7fb4f5b8e74c2051e6e7afc5cbeca/appengine/findit/services/flake_failure/test/flake_swarming_test.py
[modify] https://crrev.com/eecfb6d2aeb7fb4f5b8e74c2051e6e7afc5cbeca/appengine/findit/services/flake_failure/flake_swarming.py

Comment 6 by wylieb@chromium.org, Apr 20 2018

Owner: ----
Status: Available (was: Assigned)

Sign in to add a comment