New issue
Advanced search Search tips

Issue 832110 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 832061
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

Selection.modify('extend', 'forward', 'word') should not crash for null-selection

Project Member Reported by ClusterFuzz, Apr 12 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5334724680351744

Fuzzer: miaubiz_css_fuzzer
Job Type: linux_cfi_chrome
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x000000000010
Crash State:
  chrome
  blink::Node::GetLayoutObject
  blink::TextOffsetMapping::ComputeContainigBlock
  
Sanitizer: cfi (CFI)

Regressed: https://clusterfuzz.com/revisions?job=linux_cfi_chrome&range=550071:550107

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5334724680351744

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Apr 12 2018

Components: Blink>DOM Blink>Editing
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Apr 12 2018

Labels: Test-Predator-Auto-Owner
Owner: yosin@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/1324be868df000cb2e070199ce2d10cd0c5a2706 (Make NextWordPosition() to utilize TextOffsetMapping).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.

Comment 3 by yosin@chromium.org, Apr 13 2018

Components: Blink>Editing>Selection
Status: Started (was: Assigned)
I'm working now...

Comment 4 by yosin@chromium.org, Apr 13 2018

Components: -Blink>Editing

Comment 5 by yosin@chromium.org, Apr 13 2018

Components: -Blink>DOM

Comment 6 by yosin@chromium.org, Apr 13 2018

Mergedinto: 832061
Status: Duplicate (was: Started)
Summary: Selection.modify('extend', 'forward', 'word') should not crash for null-selection (was: Null-dereference READ in chrome)
Minimal HTML to reproduce
<script>
window.getSelection().modify('extend', 'forward', 'word');
</script>

We call NextWordPosition() for null-Position

Comment 7 by yosin@chromium.org, Apr 13 2018

Cc: yosin@chromium.org
 Issue 832121  has been merged into this issue.
Project Member

Comment 8 by ClusterFuzz, Apr 18 2018

ClusterFuzz has detected this issue as fixed in range 551526:551549.

Detailed report: https://clusterfuzz.com/testcase?key=5334724680351744

Fuzzer: miaubiz_css_fuzzer
Job Type: linux_cfi_chrome
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x000000000010
Crash State:
  chrome
  blink::Node::GetLayoutObject
  blink::TextOffsetMapping::ComputeContainigBlock
  
Sanitizer: cfi (CFI)

Regressed: https://clusterfuzz.com/revisions?job=linux_cfi_chrome&range=550071:550107
Fixed: https://clusterfuzz.com/revisions?job=linux_cfi_chrome&range=551526:551549

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5334724680351744

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.

Sign in to add a comment