Adding integration test to src side upload script |
|||
Issue descriptionIt would be very beneficial to test our src side upload script with an actual integration test for the dashboard. Ethan indicated we can use something called TestApp, that simulates the perf dashboard endpoints in a test harness so we can actually call the dashboard end points within a unit tests. See how it is used here in add_histograms_test.py: https://cs.chromium.org/chromium/src/third_party/catapult/dashboard/dashboard/add_histograms_test.py?q=add_histograms&sq=package:chromium&l=1
,
Apr 12 2018
Ethan, Simon and I met and it seems pretty reasonable to mock out the calls in tools/perf/core/results_dashboard.py to use the TestApp infrastructure they have in place. After looking into it briefly, there is a fair bit of refactoring to get it to a state where we can plug in TestApp. We have migrated the unittests from the build repo for now and will revisit this later in the Q2 or in Q3.
,
Apr 13 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8c4cc6501437162257a6e863d380315c891559af commit 8c4cc6501437162257a6e863d380315c891559af Author: Emily Hanley <eyaich@google.com> Date: Fri Apr 13 14:57:23 2018 Adding results_dashboard unit test to src side Bug: 832081 Change-Id: I9e14993b3a771657cc4d7dfc43ba518f4d345ebb Reviewed-on: https://chromium-review.googlesource.com/1010723 Commit-Queue: Emily Hanley <eyaich@chromium.org> Reviewed-by: Ashley Enstad <ashleymarie@chromium.org> Cr-Commit-Position: refs/heads/master@{#550619} [add] https://crrev.com/8c4cc6501437162257a6e863d380315c891559af/tools/perf/core/results_dashboard_unittest.py
,
Apr 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8c4cc6501437162257a6e863d380315c891559af commit 8c4cc6501437162257a6e863d380315c891559af Author: Emily Hanley <eyaich@google.com> Date: Fri Apr 13 14:57:23 2018 Adding results_dashboard unit test to src side Bug: 832081 Change-Id: I9e14993b3a771657cc4d7dfc43ba518f4d345ebb Reviewed-on: https://chromium-review.googlesource.com/1010723 Commit-Queue: Emily Hanley <eyaich@chromium.org> Reviewed-by: Ashley Enstad <ashleymarie@chromium.org> Cr-Commit-Position: refs/heads/master@{#550619} [add] https://crrev.com/8c4cc6501437162257a6e863d380315c891559af/tools/perf/core/results_dashboard_unittest.py
,
Apr 18 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/04987cddf95271f7f0ebfb87344afb54bdf87c10 commit 04987cddf95271f7f0ebfb87344afb54bdf87c10 Author: Emily Hanley <eyaich@chromium.org> Date: Wed Apr 18 22:26:08 2018 Revert "Adding results_dashboard unit test to src side" This reverts commit 8c4cc6501437162257a6e863d380315c891559af. Reason for revert: <INSERT REASONING HERE> Original change's description: > Adding results_dashboard unit test to src side > > Bug: 832081 > Change-Id: I9e14993b3a771657cc4d7dfc43ba518f4d345ebb > Reviewed-on: https://chromium-review.googlesource.com/1010723 > Commit-Queue: Emily Hanley <eyaich@chromium.org> > Reviewed-by: Ashley Enstad <ashleymarie@chromium.org> > Cr-Commit-Position: refs/heads/master@{#550619} Reverted due to failing tests on cros infrastructure, crbug.com/833630 TBR=eyaich@chromium.org,ashleymarie@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 832081 Change-Id: I9acab1c37fb050bb18052d94e346c665c0acd083 Reviewed-on: https://chromium-review.googlesource.com/1015182 Reviewed-by: Emily Hanley <eyaich@chromium.org> Commit-Queue: Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#551854} [delete] https://crrev.com/a581664af3a44053be4512ea9d4d3be0ac12f45e/tools/perf/core/results_dashboard_unittest.py
,
Nov 12
|
|||
►
Sign in to add a comment |
|||
Comment 1 by nednguyen@chromium.org
, Apr 12 2018