Issue metadata
Sign in to add a comment
|
10.3% regression in blink_perf.layout at 548483:548615 |
||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Apr 12 2018
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/14c89992c40000
,
Apr 13 2018
📍 Found a significant difference after 1 commit. https://pinpoint-dot-chromeperf.appspot.com/job/14c89992c40000 Adding fieldtrial config for the IncompatibleApplicationsWarning feature by pmonette@chromium.org https://chromium.googlesource.com/chromium/src/+/7a86e22e588d7941bde54bdb4a8c58c23e502836 Understanding performance regressions: http://g.co/ChromePerformanceRegressions
,
Jul 20
Closing this bug Increased CPU time is totally expected from my feature. But the extra work is scheduled on a background thread and should not interfere with foreground work. In addition, the extra work I am doing is a one time occurrence, that happens shortly after startup. A series of tasks is posted sequentially for each loaded DLL in the process (InspectModule() in module_info_win,h), and each tasks takes less than a second. It may seem long but keep in mind that this runs on a background task. Our metrics shows that the median amount of loaded DLLs for users in the wild is 120. So unless we see more pref regressions that doesn't involve CPU time, this is working as intended.
,
Jul 20
Leaving WontFix because I think it's okay to accept this change in benchmark score with the explanation, but wanted to cc gab in case Lucky Luke can help with the task scheduling--it should be possible to schedule background work such that it doesn't affect a benchmark like this, right? To clarify, this isn't a CPU benchmark, it's a layout benchmark measuring time to layout iframes from JavaScript. Source code is here: https://cs.chromium.org/chromium/src/third_party/blink/perf_tests/layout/Shapes/MultipleShapes.html
,
Jul 26
Yes it should be possible to more aggressively delay background work and not request layout when heavy background tasks are queued. fdoray is working on this (tracked in issue 839110). Let's make fixing this regression a goal of that work.
,
Aug 9
|
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Apr 12 2018