New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 832078 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

36.3%-82.2% regression in blink_perf.layout at 549413:549492

Project Member Reported by sullivan@chromium.org, Apr 12 2018

Issue description

See the link to graphs below.
 
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Apr 12 2018

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=832078

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=1ace3412dd4713d2dd277a6b273166572c7558e43edbd024c8244e353f50050e


Bot(s) for this bug's original alert(s):

android-nexus5
android-nexus5X
android-nexus6
android-nexus7v2
android-one
android-webview-nexus5X
chromium-rel-mac12
chromium-rel-win8-dual
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Apr 13 2018

😿 Pinpoint job stopped with an error.
https://pinpoint-dot-chromeperf.appspot.com/job/11beb7fcc40000
Cc: svil...@igalia.com ikilpatrick@chromium.org
Owner: r...@igalia.com
Status: Assigned (was: Untriaged)
rego: Not sure what went wrong with the bisect, but you can see a pretty clear drop in these metrics at r549461, "[css-grid] Initialize OverrideContainingBlock size for grid items" if you look at the link in #2. Can you take a look?
Project Member

Comment 5 by 42576172...@developer.gserviceaccount.com, Apr 13 2018

Cc: steve...@chromium.org trchen@chromium.org mlippautz@chromium.org r...@igalia.com phoglund@chromium.org wangxianzhu@chromium.org haraken@chromium.org pdr@chromium.org kojii@chromium.org cathiec...@tencent.com
📍 Found significant differences after each of 5 commits.
https://pinpoint-dot-chromeperf.appspot.com/job/11beb7fcc40000

[SPv175+] Reuse transform state across clip/effect states if possible by wangxianzhu@chromium.org
https://chromium.googlesource.com/chromium/src/+/11b7265cbef484a5184a09fb90dfaf4bbf82f96c

[LayoutNG] Fix paint position error of image by cathiechen@tencent.com
https://chromium.googlesource.com/chromium/src/+/66924513f9314eedf5094a7fa70f0257c83462f9

[css-grid] Initialize OverrideContainingBlock size for grid items by rego@igalia.com
https://chromium.googlesource.com/chromium/src/+/092113c398efcc3a864b3e65ce8b0ccfe01e8c37

Revert "ONC: Add FTEnabled property to WiFi" by phoglund@chromium.org
https://chromium.googlesource.com/chromium/src/+/bf89a1210e800760d4c656442b17a7c8424dbd44

[oilpan] Filter deleted weakcell slots during incremental marking by mlippautz@chromium.org
https://chromium.googlesource.com/chromium/src/+/2da3fcd0c9a8a6ec5504ddbf2293d5b9b8d6122c

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions

Comment 6 by r...@igalia.com, Apr 16 2018

Status: Started (was: Assigned)
Yes, it's clearly related to my patch.

We're going to revert it, as we might find a different solution for the issue.
Project Member

Comment 7 by bugdroid1@chromium.org, Apr 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1f4159ae4aa6d85d967bc4f96b3305e4a2f8ac31

commit 1f4159ae4aa6d85d967bc4f96b3305e4a2f8ac31
Author: Manuel Rego Casasnovas <rego@igalia.com>
Date: Mon Apr 16 19:50:44 2018

Revert "[css-grid] Initialize OverrideContainingBlock size for grid items"

This reverts commit 092113c398efcc3a864b3e65ce8b0ccfe01e8c37.

Reason for revert: It's causing big performance regressions on CSS Grid Layout perftests.

BUG= 832078 

Original change's description:
> [css-grid] Initialize OverrideContainingBlock size for grid items
> 
> This patch removes the grid logic from
> LayoutBox::ContainingBlockLogicalWidth|HeightForContent().
> Instead it initializes the OverrideContainingBlock size to zero
> in LayoutGrid::UpdateBlockLayout().
> 
> For grid items we don't want to use the grid container size
> (which would be the regular containing block size),
> so we want to use the overridden value.
> And while we don't have such value, it's better we use zero
> (so percentages are not resolved against the wrong thing).
> 
> This change is covered by existent tests.
> 
> Change-Id: If6a96abe7148203a2cdb9ffb2b9dd487239f7aae
> Reviewed-on: https://chromium-review.googlesource.com/989734
> Commit-Queue: Manuel Rego Casasnovas <rego@igalia.com>
> Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
> Reviewed-by: Sergio Villar <svillar@igalia.com>
> Cr-Commit-Position: refs/heads/master@{#549461}

TBR=jfernandez@igalia.com,rego@igalia.com,svillar@igalia.com,ikilpatrick@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: I17fb8ebc78e88c0c91c5802862402ea3689385d9
Reviewed-on: https://chromium-review.googlesource.com/1014120
Reviewed-by: Manuel Rego Casasnovas <rego@igalia.com>
Commit-Queue: Manuel Rego Casasnovas <rego@igalia.com>
Cr-Commit-Position: refs/heads/master@{#551082}
[modify] https://crrev.com/1f4159ae4aa6d85d967bc4f96b3305e4a2f8ac31/third_party/blink/renderer/core/layout/layout_box.cc
[modify] https://crrev.com/1f4159ae4aa6d85d967bc4f96b3305e4a2f8ac31/third_party/blink/renderer/core/layout/layout_grid.cc

Comment 8 by r...@igalia.com, Apr 16 2018

Status: Fixed (was: Started)
I guess the perf regression should be gone now.

Still we'll do some work to improve the current issues with the overrides and try to avoid performance regressions of this size.
Project Member

Comment 9 by bugdroid1@chromium.org, Apr 17 2018

Labels: merge-merged-testbranch
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1f4159ae4aa6d85d967bc4f96b3305e4a2f8ac31

commit 1f4159ae4aa6d85d967bc4f96b3305e4a2f8ac31
Author: Manuel Rego Casasnovas <rego@igalia.com>
Date: Mon Apr 16 19:50:44 2018

Revert "[css-grid] Initialize OverrideContainingBlock size for grid items"

This reverts commit 092113c398efcc3a864b3e65ce8b0ccfe01e8c37.

Reason for revert: It's causing big performance regressions on CSS Grid Layout perftests.

BUG= 832078 

Original change's description:
> [css-grid] Initialize OverrideContainingBlock size for grid items
> 
> This patch removes the grid logic from
> LayoutBox::ContainingBlockLogicalWidth|HeightForContent().
> Instead it initializes the OverrideContainingBlock size to zero
> in LayoutGrid::UpdateBlockLayout().
> 
> For grid items we don't want to use the grid container size
> (which would be the regular containing block size),
> so we want to use the overridden value.
> And while we don't have such value, it's better we use zero
> (so percentages are not resolved against the wrong thing).
> 
> This change is covered by existent tests.
> 
> Change-Id: If6a96abe7148203a2cdb9ffb2b9dd487239f7aae
> Reviewed-on: https://chromium-review.googlesource.com/989734
> Commit-Queue: Manuel Rego Casasnovas <rego@igalia.com>
> Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
> Reviewed-by: Sergio Villar <svillar@igalia.com>
> Cr-Commit-Position: refs/heads/master@{#549461}

TBR=jfernandez@igalia.com,rego@igalia.com,svillar@igalia.com,ikilpatrick@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: I17fb8ebc78e88c0c91c5802862402ea3689385d9
Reviewed-on: https://chromium-review.googlesource.com/1014120
Reviewed-by: Manuel Rego Casasnovas <rego@igalia.com>
Commit-Queue: Manuel Rego Casasnovas <rego@igalia.com>
Cr-Commit-Position: refs/heads/master@{#551082}
[modify] https://crrev.com/1f4159ae4aa6d85d967bc4f96b3305e4a2f8ac31/third_party/blink/renderer/core/layout/layout_box.cc
[modify] https://crrev.com/1f4159ae4aa6d85d967bc4f96b3305e4a2f8ac31/third_party/blink/renderer/core/layout/layout_grid.cc

Sign in to add a comment