[WPT] service-workers/service-worker/worker-client-id.https.html fails with unstable messages (can't be rebaselined) |
||
Issue descriptionThe test hasn't been imported yet. This issue is opened in advance so that I can associate the expectation lines with it (and unblock the importer). https://github.com/w3c/web-platform-tests/pull/10418 The test prints out client IDs in the failure message which are different every time.
,
Apr 12 2018
I wrote this test. We can change it to not include transient data like this. I'll make a note about the problem for future test write. Sorry for the trouble.
,
Apr 12 2018
Thanks, bkelly@! Once you changed the test, could you give us a heads up so that we can rebaseline it?
,
Apr 12 2018
bkelly thanks a lot for the offer but I think it's fine to leave it as is... It's Chrome's fault we're failing this test, and assert_not_equals(id1, id2) is a natural way to the write the test... robertma thanks for adding the lines in TestExpectations.
,
Apr 13 2018
,
Sep 6
Hi, I did some investigation on this issue, and found the client id was originally created during construction of ServiceWorkerProviderHost. And it seems a bit strange that the ServiceWorkerProviderType doesn't include Dedicated Worker. While according to the spec (https://w3c.github.io/ServiceWorker/#service-worker-client-concept), dedicated worker is also a client type. So I'm wondering is it missed or there are some other considerations. Thanks.
,
Sep 6
Thanks for looking into this. Yes, dedicated workers are not yet supported as service worker clients, and when a "controlled" dedicated worker does a fetch() we reuse the client id of its ancestor frame, so this WPT will fail for a while. We will be able to fix it after "PlzWorker" work ongoing for issue 715632 .
,
Sep 7
Thanks falken for the explanation. |
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Apr 12 2018