Peter, I don't have a touch device to debug this issue. The problem was most likely introduced with one of my changes to the HoverButton.
Could someone from the Windows team take a look at this?

If you need any help let me know!
Thanks,
 Thomas

pbos@, since you're already looking at avatar button stuff, maybe you and tangltom can work together to debug this fairly quickly?

I think your CL broke it by either of:

* not accepting gesture events:
 https://cs.chromium.org/chromium/src/ui/views/controls/button/menu_button.cc?l=169&rcl=8d42e256c037c60f839b90571d50b5d784a2df27
* not returning MenuButton::IsTriggerableEvent(event) which would've accepted EF_GESTURE_TAPs

I assume that replacing Button::IsTriggerableEvent(event) with MenuButton::IsTriggerableEvent(event) would address this. Assigning it back to you to make this change if it's appropriate. I don't know if you intended to bypass MenuButton here.

This line might be relevant too:

https://cs.chromium.org/chromium/src/ui/views/controls/button/button.cc?l=311&rcl=41e1ddb4aaadbba95c09939e903dce7615a5fea8

I haven't read into it too much, if you don't think this would address it please assign it back to me and I'll look back into it.

Hi pbos@. Yes, our intention is to bypass MenuButton here because MenuButtons
are activated on mouse press rather than mouse release and we want HoverButton
to be activated on mouse release. However, I unfortunately can't debug touch events because no one in our team has a desktop (or laptop) machine with touch screen.

To the bug:
I also think that the change has to be made in HoverButton::IsTriggerableEventType or adding HoverButton::OnGestureEvent.

I just talked to my manager and he said that ordering a touch device would take around 4 weeks. Could you take this on?
Reassigning to you to resolve this please.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dfdc271f89660811340a88f4deb10c4021369039

commit dfdc271f89660811340a88f4deb10c4021369039
Author: Peter Boström <pbos@chromium.org>
Date: Wed Apr 18 02:58:33 2018

Trigger HoverButton on touch release (not tap)

When crrev.com/c/966286 changed HoverButton to trigger only on mouse
release gesture behavior was accidentally affected as well (would
trigger on ui::ET_GESTURE_TAP_DOWN events).

This change restricts the override in above CL to only affect mouse
events and use the correct MenuButton behavior for gesture events. It
also removes right-click key-release as a trigger by checking that the
gesture event can trigger buttons (which enforces mouse left-click).

Bug:  chromium:832056 
Change-Id: Ibf34d6b20f7dff2b7c13c8f42811124f9a06c781
Reviewed-on: https://chromium-review.googlesource.com/1014487
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551562}
[modify] https://crrev.com/dfdc271f89660811340a88f4deb10c4021369039/chrome/browser/ui/views/hover_button.cc

This should've fixed it. Please verify in the next Canary (it's not in today's Canary). :)

I think this regressed pre-branch so this needs a merge.

Update:

Retested above issue is fixed on latest canary build #68.0.3400.0 using Windows(10Touch device) OS.

Kindly review an attached screen-cast.

Thank you.

Deleted: Fix_Actual.mp4 257 KB

	Fix_Actual.mp4 257 KB View Download

Your change meets the bar and is auto-approved for M67. Please go ahead and merge the CL to branch 3396 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/20c5d00888c73d558665a2d6943383e893f86e0d

commit 20c5d00888c73d558665a2d6943383e893f86e0d
Author: Peter Boström <pbos@chromium.org>
Date: Thu Apr 19 18:11:53 2018

Trigger HoverButton on touch release (not tap)

When crrev.com/c/966286 changed HoverButton to trigger only on mouse
release gesture behavior was accidentally affected as well (would
trigger on ui::ET_GESTURE_TAP_DOWN events).

This change restricts the override in above CL to only affect mouse
events and use the correct MenuButton behavior for gesture events. It
also removes right-click key-release as a trigger by checking that the
gesture event can trigger buttons (which enforces mouse left-click).

Bug:  chromium:832056 
Change-Id: Ibf34d6b20f7dff2b7c13c8f42811124f9a06c781
Reviewed-on: https://chromium-review.googlesource.com/1014487
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#551562}(cherry picked from commit dfdc271f89660811340a88f4deb10c4021369039)
Reviewed-on: https://chromium-review.googlesource.com/1019961
Reviewed-by: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/branch-heads/3396@{#135}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}
[modify] https://crrev.com/20c5d00888c73d558665a2d6943383e893f86e0d/chrome/browser/ui/views/hover_button.cc

Thanks for verifying dbote@!

Tested the issue on Windows-10(Touch) using chrome latest Dev M67-67.0.3396.18 by following steps mentioned in the original comment. Observed that selection highlight is displaying as expected. Hence adding TE-Verified label.

please find the screen shot for reference.

Thank you!

Deleted: 832056.mp4 998 KB

	832056.mp4 998 KB View Download