New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 832055 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug

Blocked on:
issue 829234

Blocking:
issue 778507



Sign in to add a comment

TextOffsetMapping should skip anonymous LayoutBlockFlow with anonymous layout object

Project Member Reported by ClusterFuzz, Apr 12 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5321998641922048

Fuzzer: inferno_twister
Job Type: linux_ubsan_vptr_content_shell_drt
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x000000000000
Crash State:
  blink::TextIteratorAlgorithm<blink::EditingAlgorithm<blink::FlatTreeTraversal> >
  blink::TextOffsetMapping::ComputeTextOffset
  blink::NextWordPosition
  
Sanitizer: undefined (UBSAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_ubsan_vptr_content_shell_drt&range=550102:550107

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5321998641922048

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Apr 12 2018

Components: Blink>Editing
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Apr 12 2018

Labels: Test-Predator-Auto-Owner
Owner: yosin@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/1324be868df000cb2e070199ce2d10cd0c5a2706 (Make NextWordPosition() to utilize TextOffsetMapping).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
Project Member

Comment 3 by ClusterFuzz, Apr 13 2018

Labels: OS-Mac

Comment 4 by yosin@chromium.org, Apr 13 2018

Components: Blink>Editing>Selection
Status: Started (was: Assigned)
I'm working now...

Comment 5 by yosin@chromium.org, Apr 13 2018

Components: -Blink>Editing

Comment 6 Deleted

Comment 7 by yosin@chromium.org, Apr 13 2018

Here is minimal HTML to reproduce:
<div style="columns: 51 12px"><b>foo</b></div>
<script>
const selection = window.getSelection();
selection.collapse(document.querySelector('b').firstChild, 3);
selection.modify('move', 'forward', 'word');
</script>

LayoutTree
layer at (0,0) size 800x600
  LayoutView at (0,0) size 800x600
layer at (0,0) size 800x600
  LayoutBlockFlow {HTML} at (0,0) size 800x600
    LayoutBlockFlow {BODY} at (8,8) size 784x584
layer at (8,8) size 784x20
  LayoutBlockFlow {DIV} at (0,0) size 784x20
    LayoutMultiColumnSet (anonymous) at (0,0) size 784x20
layer at (8,8) size 13x20
  LayoutMultiColumnFlowThread (anonymous) at (0,0) size 12.56x20
    LayoutInline {B} at (0,0) size 21x19
      LayoutText {#text} at (0,0) size 21x19
        text run at (0,0) width 21: "foo"

Comment 8 by yosin@chromium.org, Apr 13 2018

Cc: yosin@chromium.org
 Issue 832369  has been merged into this issue.
Project Member

Comment 9 by ClusterFuzz, Apr 14 2018

Labels: OS-Chrome

Comment 10 by yosin@chromium.org, Apr 17 2018

Cc: brajkumar@chromium.org
 Issue 833263  has been merged into this issue.

Comment 11 by yosin@chromium.org, Apr 17 2018

 Issue 833242  has been merged into this issue.
Project Member

Comment 12 by bugdroid1@chromium.org, Apr 17 2018

Labels: merge-merged-3396
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dec40a582a3805fb28dfd67ba49fc2cdb28a1b6c

commit dec40a582a3805fb28dfd67ba49fc2cdb28a1b6c
Author: Yoshifumi Inoue <yosin@chromium.org>
Date: Tue Apr 17 04:30:18 2018

Revert "Make NextWordPosition() to utilize TextOffsetMapping"

This reverts commit 1324be868df000cb2e070199ce2d10cd0c5a2706 for M67/Beta

TextOffsetMapping is not ready for release.
It should support edge cases.

TBR=yosin@chromium.org

Bug:  832055 ,  832061 ,  832101 ,  832261 ,  832350 ,  832497 ,  832639 ,  833172 ,  833180 
Change-Id: Iac5f58716619a626650088a55109922daf1a4f3a
Reviewed-on: https://chromium-review.googlesource.com/1013445
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/branch-heads/3396@{#36}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}
[modify] https://crrev.com/dec40a582a3805fb28dfd67ba49fc2cdb28a1b6c/third_party/blink/renderer/core/editing/visible_units_word.cc
[modify] https://crrev.com/dec40a582a3805fb28dfd67ba49fc2cdb28a1b6c/third_party/blink/renderer/core/editing/visible_units_word_test.cc

Comment 13 by yosin@chromium.org, Apr 17 2018

 Issue 833180  has been merged into this issue.

Comment 14 by yosin@chromium.org, Apr 17 2018

Blocking: 778507

Comment 15 by yosin@chromium.org, Apr 18 2018

Blockedon: 829234

Comment 16 by yosin@chromium.org, Apr 19 2018

Labels: OS-Windows
Summary: TextOffsetMapping should skip anonymous LayoutBlockFlow with anonymous layout object (was: TextOffsetMaaping/ComputeStartPositon(LayoutBlock) crashes with multicol)

Comment 17 by yosin@chromium.org, Apr 19 2018

 Issue 834623  has been merged into this issue.

Comment 18 by yosin@chromium.org, Apr 19 2018

 Issue 834625  has been merged into this issue.
Project Member

Comment 19 by ClusterFuzz, Apr 23 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Started)
ClusterFuzz testcase 4927582869651456 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 20 by ClusterFuzz, Apr 30 2018

Labels: Needs-Feedback
ClusterFuzz testcase 5015537156096000 is still reproducing on tip-of-tree build (trunk).

Please re-test your fix against this testcase and if the fix was incorrect or incomplete, please re-open the bug. Otherwise, ignore this notification and add ClusterFuzz-Wrong label.

Sign in to add a comment