Repro instructions are not using top-level paths |
|||
Issue descriptionExample: https://chromium-swarm.appspot.com/task?id=3cd24966e94d4310&refresh=10&show_raw=1&wide_logs=true The instructions listed under "Reproducing the task locally" are not giving any indication of where to run this. Maybe you could display the path from the top-level chrome directory, making it easier for the standard chromie to run them without having to grep for the python files first. python swarming.py reproduce -S chromium-swarm.appspot.com 3cd24966e94d4310 Should become: python tools/swarming_client/swarming.py reproduce -S chromium-swarm.appspot.com 3cd24966e94d4310
,
Apr 12 2018
Swarming is not chromium specific. Many other projects are using it, so the help here cannot refer to a specific kind of checkout. It does state a generic way to get the ckient code and from adhoc reports it seems to have been sufficient, other people noticed the mapping of the client tools inside src and using it instead. The git clone comment was not clear enough?
,
Apr 12 2018
I see. Maybe then move the clone instruction first and then relative paths to the checked out repo? I'm trying to shave of tens of seconds on every repro instruction. This happens infrequently enough that you don't remember where things are.
,
Sep 24
,
Sep 24
The following revision refers to this bug: https://chromium.googlesource.com/infra/luci/luci-py.git/+/db78d575f254956bc075ad47183ef6b5c4dd50a9 commit db78d575f254956bc075ad47183ef6b5c4dd50a9 Author: Kevin Lubick <kjlubick@google.com> Date: Mon Sep 24 17:56:43 2018 Add relative paths to repro commands Bug: 832036 Change-Id: I2e665c177d11601eadbad2601f603d97e72532f8 Reviewed-on: https://chromium-review.googlesource.com/1239025 Commit-Queue: Kevin Lubick <kjlubick@chromium.org> Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org> [modify] https://crrev.com/db78d575f254956bc075ad47183ef6b5c4dd50a9/appengine/swarming/ui/build/elements.html [modify] https://crrev.com/db78d575f254956bc075ad47183ef6b5c4dd50a9/appengine/swarming/ui/res/imp/taskpage/task-page.html
,
Sep 28
This fix is live |
|||
►
Sign in to add a comment |
|||
Comment 1 by cbruni@chromium.org
, Apr 12 2018