App Store links not opening |
||||||
Issue descriptionChrome Version: 67.0.3395.0 (Canary) OS: iOS What steps will reproduce the problem? (1) Load loansharkgames.com/games/apocrypha/up (2) Tap Apple App Store button. (3) A new tab opens about:blank, and then nothing else happens. What is the expected result? The App Store app should open, perhaps with an interstitial dialog. What happens instead? A blank tab opens. App Store link on page is : https://itunes.apple.com/us/app/apocrypha-companion-app/id1272179643?ls=1&mt=8 App store links work fine in the current release build (65.0.3325.152).
,
Apr 12 2018
This was on iOS 11.3 (both the 67 canary failure and the 65 release success).
,
Apr 16 2018
I was able to reproduce it seems that this happens when the target=_blank on the url.
,
Apr 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4a554fb86970ce0be1252557ca8d8ce879f2b219 commit 4a554fb86970ce0be1252557ca8d8ce879f2b219 Author: Mohammad Refaat <mrefaat@chromium.org> Date: Thu Apr 19 00:41:22 2018 Don't early exit on didFailProvisionalNavigation There was a condition that forced early return when there is no visible item in didFailProvisionalNavigation, this was useful to prevent crashed coming from adding the item to the history (check crbug.com/565457) Right now with the history tab helper it's much easier to check for visible item and don't proceed if there is no visible item. We should remove the condition (which i will follow with a CL to do that). But for now i added a check to the condition to bypass the case that prevents the storekit to be opened when itunes link is opened on target=_blank link Bug: 570699, 832017 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ife5e3f58f03365b0d225e0ab10fe289a7caed4f3 Reviewed-on: https://chromium-review.googlesource.com/1016086 Reviewed-by: Eugene But <eugenebut@chromium.org> Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#551902} [modify] https://crrev.com/4a554fb86970ce0be1252557ca8d8ce879f2b219/ios/web/web_state/ui/crw_web_controller.mm
,
Apr 19 2018
,
Apr 20 2018
Your change meets the bar and is auto-approved for M67. Please go ahead and merge the CL to branch 3396 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 20 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/98a1fec4f4b870ec1d535ff947fa1fbfefcfc03f commit 98a1fec4f4b870ec1d535ff947fa1fbfefcfc03f Author: Mohammad Refaat <mrefaat@chromium.org> Date: Fri Apr 20 16:48:54 2018 Don't early exit on didFailProvisionalNavigation There was a condition that forced early return when there is no visible item in didFailProvisionalNavigation, this was useful to prevent crashed coming from adding the item to the history (check crbug.com/565457) Right now with the history tab helper it's much easier to check for visible item and don't proceed if there is no visible item. We should remove the condition (which i will follow with a CL to do that). But for now i added a check to the condition to bypass the case that prevents the storekit to be opened when itunes link is opened on target=_blank link Bug: 570699, 832017 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ife5e3f58f03365b0d225e0ab10fe289a7caed4f3 Reviewed-on: https://chromium-review.googlesource.com/1016086 Reviewed-by: Eugene But <eugenebut@chromium.org> Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#551902}(cherry picked from commit 4a554fb86970ce0be1252557ca8d8ce879f2b219) Reviewed-on: https://chromium-review.googlesource.com/1020801 Cr-Commit-Position: refs/branch-heads/3396@{#164} Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428} [modify] https://crrev.com/98a1fec4f4b870ec1d535ff947fa1fbfefcfc03f/ios/web/web_state/ui/crw_web_controller.mm
,
Apr 24 2018
Verified on chrome canary version 68.0.3405.0 canary following steps mentioned in comment #0 on iPhone 8 with iOS 11.2.6, 11.4. Directed to app store upon tapping the link. Looks good.
,
Apr 25 2018
Verified in: App Version: 67.0.3396.19 beta Devices: iPhone 7, iPad Air, iPhone 8 Plus OS Versions: 10.3.3, 11.2.6, 11.4 beta 2 Followed the steps mentioned in comment#0, Tapping on Apple AppStore button, it redirects the user to Appstore. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by pkl@chromium.org
, Apr 12 2018Labels: M-67
Owner: mrefaat@chromium.org