Regression:Close icon doesn't appear properly after press and hold action is performed via spacebar key.
Reported by
vku...@etouch.net,
Apr 12 2018
|
|||||||||
Issue descriptionChrome Version:67.0.3395.0 (Official Build)Revision 19ac07e50344cdf4089e5d1b696958867736fc03-refs/heads/master@{#549859} (32/64 Bit) OS:Windows(7,8,8.1,10),Mac(10.12.6, 10.13.1, 10.13.5),Linux(14.04 LTS) What steps will reproduce the problem? (1)Launch chrome and open to 2-3 webpages. (2)Navigate to chrome://history/ click on checkbox of any entry (3)Press tab key till focus reaches close 'X' icon, now press and hold spacebar key and observe the close icon. Actual: Close icon doesn't appear properly after press and hold action is performed via spacebar key(i.e 'X' icon turns into white color) Expected: Close icon should appear properly even after press and hold action is performed via spacebar key. This is a regression issue broken in 'M67' and below is the manual bisect info Good Build: 67.0.3368.0(Revision:542341) Bad Build: 67.0.3369.0(Revision:542817)
,
Apr 12 2018
Yes, this looks related to my change. I'll create a patch for a fix
,
Apr 13 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/12b708c733623cf4ce0ef775a77f50288fe6f39d commit 12b708c733623cf4ce0ef775a77f50288fe6f39d Author: Hector Carmona <hcarmona@chromium.org> Date: Fri Apr 13 00:45:10 2018 MD History: Fix ripple styling caused by paper-icon-button update. Bug: 832012 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I3c1b7499de7085f1ca109748b28b5067754b5aaa Reviewed-on: https://chromium-review.googlesource.com/1010481 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#550442} [modify] https://crrev.com/12b708c733623cf4ce0ef775a77f50288fe6f39d/ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_selection_overlay.html
,
Apr 16 2018
,
Apr 16 2018
Requesting merge to prevent regression from going to stable. Merge is low risk.
,
Apr 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/12b708c733623cf4ce0ef775a77f50288fe6f39d commit 12b708c733623cf4ce0ef775a77f50288fe6f39d Author: Hector Carmona <hcarmona@chromium.org> Date: Fri Apr 13 00:45:10 2018 MD History: Fix ripple styling caused by paper-icon-button update. Bug: 832012 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I3c1b7499de7085f1ca109748b28b5067754b5aaa Reviewed-on: https://chromium-review.googlesource.com/1010481 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#550442} [modify] https://crrev.com/12b708c733623cf4ce0ef775a77f50288fe6f39d/ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_selection_overlay.html
,
Apr 18 2018
Your change meets the bar and is auto-approved for M67. Please go ahead and merge the CL to branch 3396 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 18 2018
Pls merge your change to M67 branch 3396 ASAP so we can pick it up for next M67 Dev/Beta release. If already merged to M67 and nothing is pending, pls remove "Merge=Approved-67" label. Thank you.
,
Apr 18 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e936bccede64d432e51c2617fb514a6250ffe982 commit e936bccede64d432e51c2617fb514a6250ffe982 Author: Hector Carmona <hcarmona@chromium.org> Date: Wed Apr 18 18:50:55 2018 MD History: Fix ripple styling caused by paper-icon-button update. Bug: 832012 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I3c1b7499de7085f1ca109748b28b5067754b5aaa Reviewed-on: https://chromium-review.googlesource.com/1010481 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Hector Carmona <hcarmona@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#550442}(cherry picked from commit 12b708c733623cf4ce0ef775a77f50288fe6f39d) Reviewed-on: https://chromium-review.googlesource.com/1017362 Reviewed-by: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/branch-heads/3396@{#89} Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428} [modify] https://crrev.com/e936bccede64d432e51c2617fb514a6250ffe982/ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_selection_overlay.html
,
Apr 18 2018
,
Apr 24 2018
Update : Retested above issue in latest Dev build #67.0.3396.18 on Windows(7,8,8.1,10),Mac(10.12.6, 10.13.1, 10.13.5) & Linux(14.04 LTS) OS and the issue is fixed. Kindly review an attached screen-cast. Thank you..! |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by vku...@etouch.net
, Apr 12 2018Owner: hcarmona@chromium.org
Status: Assigned (was: Unconfirmed)