New issue
Advanced search Search tips

Issue 831999 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

cast_unittests AudioDecoderTestScenarios/AudioDecoderTest.RecoversFromDroppedFrames/2 failing on android

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Apr 12 2018

Issue description

Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of grunell@chromium.org

cast_unittests AudioDecoderTestScenarios/AudioDecoderTest.RecoversFromDroppedFrames/2
 failing on chromium.memory/Android CFI

Builders failed on: 
- Android CFI: 
  https://build.chromium.org/p/chromium.memory/builders/Android%20CFI

Failure:
DecoderTest.RecoversFromDroppedFrames/2
I   79.799s run_tests_on_device(00ba82a980789b29)  ../../media/cast/receiver/audio_decoder_unittest.cc:175: Failure
I   79.799s run_tests_on_device(00ba82a980789b29)  The difference between TestAudioBusFactory::kMiddleANoteFreq * 2 * audio_bus->frames() / GetParam().sampling_rate and CountZeroCrossings(audio_bus->channel(ch), audio_bus->frames()) is 7, which exceeds 1, where
I   79.799s run_tests_on_device(00ba82a980789b29)  TestAudioBusFactory::kMiddleANoteFreq * 2 * audio_bus->frames() / GetParam().sampling_rate evaluates to 8,
I   79.799s run_tests_on_device(00ba82a980789b29)  CountZeroCrossings(audio_bus->channel(ch), audio_bus->frames()) evaluates to 1, and
I   79.799s run_tests_on_device(00ba82a980789b29)  1 evaluates to 1.
I   79.799s run_tests_on_device(00ba82a980789b29)  ../../media/cast/receiver/audio_decoder_unittest.cc:175: Failure
I   79.799s run_tests_on_device(00ba82a980789b29)  The difference between TestAudioBusFactory::kMiddleANoteFreq * 2 * audio_bus->frames() / GetParam().sampling_rate and CountZeroCrossings(audio_bus->channel(ch), audio_bus->frames()) is 8, which exceeds 1, where
I   79.799s run_tests_on_device(00ba82a980789b29)  TestAudioBusFactory::kMiddleANoteFreq * 2 * audio_bus->frames() / GetParam().sampling_rate evaluates to 8,
I   79.799s run_tests_on_device(00ba82a980789b29)  CountZeroCrossings(audio_bus->channel(ch), audio_bus->frames()) evaluates to 0, and
I   79.799s run_tests_on_device(00ba82a980789b29)  1 evaluates to 1.
I   79.799s run_tests_on_device(00ba82a980789b29)  [  FAILED  ] AudioDecoderTestScenarios/AudioDecoderTest.RecoversFromDroppedFrames/2, where GetParam() = 12-byte object <01-00 00-00 01-00 00-00 40-1F 00-00> (23 ms)

This started when the test was enabled on the memory waterfall here https://chromium-review.googlesource.com/c/chromium/src/+/987916 
 
Components: Internals>Cast
Labels: -Sheriff-Chromium OS-Android Type-Bug
Owner: m...@chromium.org
Status: Assigned (was: Available)
miu@ can you take a look?
Cc: -grunell@chromium.org
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 17 2018

Comment 5 by thakis@chromium.org, May 16 2018

Summary: cast_unittests AudioDecoderTestScenarios/AudioDecoderTest.RecoversFromDroppedFrames/2 failing on android (was: cast_unittests AudioDecoderTestScenarios/AudioDecoderTest.RecoversFromDroppedFrames/2 failing on chromium.memory/Android CFI)
Also fails on regular android:

https://ci.chromium.org/buildbot/tryserver.chromium.android/linux_android_rel_ng/552271

 RUN      ] AudioDecoderTestScenarios/AudioDecoderTest.RecoversFromDroppedFrames/2
../../media/cast/receiver/audio_decoder_unittest.cc:176: Failure
The difference between TestAudioBusFactory::kMiddleANoteFreq * 2 * audio_bus->frames() / GetParam().sampling_rate and CountZeroCrossings(audio_bus->channel(ch), audio_bus->frames()) is 7, which exceeds 1, where
TestAudioBusFactory::kMiddleANoteFreq * 2 * audio_bus->frames() / GetParam().sampling_rate evaluates to 8,
CountZeroCrossings(audio_bus->channel(ch), audio_bus->frames()) evaluates to 1, and
1 evaluates to 1.
Stack trace:
../../media/cast/receiver/audio_decoder_unittest.cc:176: Failure
The difference between TestAudioBusFactory::kMiddleANoteFreq * 2 * audio_bus->frames() / GetParam().sampling_rate and CountZeroCrossings(audio_bus->channel(ch), audio_bus->frames()) is 8, which exceeds 1, where
TestAudioBusFactory::kMiddleANoteFreq * 2 * audio_bus->frames() / GetParam().sampling_rate evaluates to 8,
CountZeroCrossings(audio_bus->channel(ch), audio_bus->frames()) evaluates to 0, and
1 evaluates to 1.
Stack trace:
[  FAILED  ] AudioDecoderTestScenarios/AudioDecoderTest.RecoversFromDroppedFrames/2, where GetParam() = 12-byte object <01-00 00-00 01-00 00-00 40-1F 00-00> (31 ms)
Searching for native crashes in: /b/swarming/w/itiqSAou/tmp2F8lUl
Unknown Android release, consider passing --packed-lib.
Reading Android symbols from: /b/swarming/w/ir
Searching for Chrome symbols from within: /b/swarming/w/ir/out/Release/lib.unstripped:/b/swarming/w/ir/out/Release
Stack Trace:
  RELADDR   FUNCTION                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                          FILE:LINE
  0021f633  testing::internal::AssertHelper::operator=(testing::Message const&) const                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                         ??:0:0
  000fe6ab  media::cast::AudioDecoderTest::OnDecodedFrame(bool, std::__ndk1::unique_ptr<media::AudioBus, std::__ndk1::default_delete<media::AudioBus> >, bool)                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                ??:0:0
  000fea89  void base::internal::FunctorTraits<void (media::cast::AudioDecoderTest::*)(bool, std::__ndk1::unique_ptr<media::AudioBus, std::__ndk1::default_delete<media::AudioBus> >, bool), void>::Invoke<void (media::cast::AudioDecoderTest::*)(bool, std::__ndk1::unique_ptr<media::AudioBus, std::__ndk1::default_delete<media::AudioBus> >, bool), media::cast::AudioDecoderTest*, bool const&, std::__ndk1::unique_ptr<media::AudioBus, std::__ndk1::default_delete<media::AudioBus> >, bool>(void (media::cast::AudioDecoderTest::*)(bool, std::__ndk1::unique_ptr<media::AudioBus, std::__ndk1::default_delete<media::AudioBus> >, bool), media::cast::AudioDecoderTest*&&, bool const&&&, std::__ndk1::unique_ptr<media::AudioBus, std::__ndk1::default_delete<media::AudioBus> >&&, bool&&)                                                                                                                                                                                                                                                                                        ??:0:0
  000fea59  void base::internal::InvokeHelper<false, void>::MakeItSo<void (media::cast::AudioDecoderTest::* const&)(bool, std::__ndk1::unique_ptr<media::AudioBus, std::__ndk1::default_delete<media::AudioBus> >, bool), media::cast::AudioDecoderTest*, bool const&, std::__ndk1::unique_ptr<media::AudioBus, std::__ndk1::default_delete<media::AudioBus> >, bool>(void (media::cast::AudioDecoderTest::* const&&&)(bool, std::__ndk1::unique_ptr<media::AudioBus, std::__ndk1::default_delete<media::AudioBus> >, bool), media::cast::AudioDecoderTest*&&, bool const&&&, std::__ndk1::unique_ptr<media::AudioBus, std::__ndk1::default_delete<media::AudioBus> >&&, bool&&)                                                                                                                                                                                                                                                                                                                                                                                                              ??:0:0
  000fea3d  void base::internal::Invoker<base::internal::BindState<void (media::cast::AudioDecoderTest::*)(bool, std::__ndk1::unique_ptr<media::AudioBus, std::__ndk1::default_delete<media::AudioBus> >, bool), base::internal::UnretainedWrapper<media::cast::AudioDecoderTest>, bool>, void (std::__ndk1::unique_ptr<media::AudioBus, std::__ndk1::default_delete<media::AudioBus> >, bool)>::RunImpl<void (media::cast::AudioDecoderTest::* const&)(bool, std::__ndk1::unique_ptr<media::AudioBus, std::__ndk1::default_delete<media::AudioBus> >, bool), std::__ndk1::tuple<base::internal::UnretainedWrapper<media::cast::AudioDecoderTest>, bool> const&, 0u, 1u>(void (media::cast::AudioDecoderTest::* const&&&)(bool, std::__ndk1::unique_ptr<media::AudioBus, std::__ndk1::default_delete<media::AudioBus> >, bool), std::__ndk1::tuple<base::internal::UnretainedWrapper<media::cast::AudioDecoderTest>, bool> const&&&, std::__ndk1::integer_sequence<unsigned int, 0u, 1u>, std::__ndk1::unique_ptr<media::AudioBus, std::__ndk1::default_delete<media::AudioBus> >&&, bool&&)  ??:0:0
  000fea27  base::internal::Invoker<base::internal::BindState<void (media::cast::AudioDecoderTest::*)(bool, std::__ndk1::unique_ptr<media::AudioBus, std::__ndk1::default_delete<media::AudioBus> >, bool), base::internal::UnretainedWrapper<media::cast::AudioDecoderTest>, bool>, void (std::__ndk1::unique_ptr<media::AudioBus, std::__ndk1::default_delete<media::AudioBus> >, bool)>::Run(base::internal::BindStateBase*, std::__ndk1::unique_ptr<media::AudioBus, std::__ndk1::default_delete<media::AudioBus> >&&, bool)                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                              ??:0:0
  00127a45  void base::internal::FunctorTraits<base::RepeatingCallback<void (std::__ndk1::unique_ptr<media::AudioBus, std::__ndk1::default_delete<media::AudioBus> >, bool)>, void>::Invoke<base::RepeatingCallback<void (std::__ndk1::unique_ptr<media::AudioBus, std::__ndk1::default_delete<media::AudioBus> >, bool)> const&, std::__ndk1::unique_ptr<media::AudioBus, std::__ndk1::default_delete<media::AudioBus> >, bool const&>(base::RepeatingCallback<void (std::__ndk1::unique_ptr<media::AudioBus, std::__ndk1::default_delete<media::AudioBus> >, bool)> const&&&, std::__ndk1::unique_ptr<media::AudioBus, std::__ndk1::default_delete<media::AudioBus> >&&, bool const&&&)                                                                                                                                                                                                                                                                                                                                                                                                     ??:0:0
  001279f3  void base::internal::Invoker<base::internal::BindState<base::RepeatingCallback<void (std::__ndk1::unique_ptr<media::AudioBus, std::__ndk1::default_delete<media::AudioBus> >, bool)>, base::internal::PassedWrapper<std::__ndk1::unique_ptr<media::AudioBus, std::__ndk1::default_delete<media::AudioBus> > >, bool>, void ()>::RunImpl<base::RepeatingCallback<void (std::__ndk1::unique_ptr<media::AudioBus, std::__ndk1::default_delete<media::AudioBus> >, bool)> const&, std::__ndk1::tuple<base::internal::PassedWrapper<std::__ndk1::unique_ptr<media::AudioBus, std::__ndk1::default_delete<media::AudioBus> > >, bool> const&, 0u, 1u>(base::RepeatingCallback<void (std::__ndk1::unique_ptr<media::AudioBus, std::__ndk1::default_delete<media::AudioBus> >, bool)> const&&&, std::__ndk1::tuple<base::internal::PassedWrapper<std::__ndk1::unique_ptr<media::AudioBus, std::__ndk1::default_delete<media::AudioBus> > >, bool> const&&&, std::__ndk1::integer_sequence<unsigned int, 0u, 1u>)                                                                          ??:0:0
  00141ae7  base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask*)                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                              ??:0:0
  0014b44f  base::internal::IncomingTaskQueue::RunTask(base::PendingTask*)                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                    ??:0:0
  0014d00f  base::MessageLoop::RunTask(base::PendingTask*)                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                    ??:0:0
  0014d281  base::MessageLoop::DeferOrRunPendingTask(base::PendingTask)                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                       ??:0:0
  0014d407  base::MessageLoop::DoWork()                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                       ??:0:0
  00186d6d  base::MessagePumpLibevent::Run(base::MessagePump::Delegate*)                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                      ??:0:0
  0014cc41  base::MessageLoop::Run(bool)                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                      ??:0:0
  0015a86d  base::RunLoop::Run()                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                              ??:0:0
  0016fcf7  base::Thread::Run(base::RunLoop*)                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                 ??:0:0
  0016fe8d  base::Thread::ThreadMain()                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                        ??:0:0
  001849f7  base::(anonymous namespace)::ThreadFunc(void*)                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                    ??:0:0
  0000d173  <UNKNOWN>                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                         /system/lib/libc.so
  0000d30b  <UNKNOWN>                      
Project Member

Comment 6 by bugdroid1@chromium.org, May 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/589b7b025231a8a69a69c1a7f2a9091f5b9fdc9a

commit 589b7b025231a8a69a69c1a7f2a9091f5b9fdc9a
Author: Nico Weber <thakis@chromium.org>
Date: Sat May 19 02:58:46 2018

Reduce number of different test suite configurations.

- Remove all the "non_clang" and "_fyi" configs -- the clang
  waterfall and the FYI waterfall should default to running the
  same tests as the real waterfalls unless explicitly opted out.
  Deviations here were very likely not intentional.
  - This requires running chrome_cleaner_unittests on the regular
    win bots, which seems like a good change anyhow.
- Just include angle_unittests in chromium_gtests instead of
  spuriously adding it here and there (but on all platforms).
  We've had issues with this test unintentionally running on too
  few bots.
- Rename aura_gtests to non_android_and_mac_gtests
- Include gl_tests in the normal chromium_linux_gtests and
  chromium_android_gtests suites instead of having separate
  _and_gl configs
- Add gcm_unit_tests to chromium_gtests since it effectively
  ran everywhere already, this allows deleting
  non_android_and_cast_chromium_gtests. Use similar tactics to
  remove non_android_and_cast_and_chromeos_chromium_gtests.
- Address most "TODO: merge back to X" TODOs

The main effect is that this adds many tests to the chromium.clang
waterfall, making it more consistent with the main waterfall.
It also adds a couple of binaries to other waterfalls.

Bug: 843511, 843726 , 843729 , 843731 , 843732 , 843734 ,831999, 844582 
TBR=disabled test owners

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I67c3980009fc07897f1f6bab424ef6c5f11d4830
Reviewed-on: https://chromium-review.googlesource.com/1061795
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560147}
[modify] https://crrev.com/589b7b025231a8a69a69c1a7f2a9091f5b9fdc9a/content/test/gpu/generate_buildbot_json.py
[modify] https://crrev.com/589b7b025231a8a69a69c1a7f2a9091f5b9fdc9a/media/cast/receiver/audio_decoder_unittest.cc
[modify] https://crrev.com/589b7b025231a8a69a69c1a7f2a9091f5b9fdc9a/testing/buildbot/chromium.android.fyi.json
[modify] https://crrev.com/589b7b025231a8a69a69c1a7f2a9091f5b9fdc9a/testing/buildbot/chromium.android.json
[modify] https://crrev.com/589b7b025231a8a69a69c1a7f2a9091f5b9fdc9a/testing/buildbot/chromium.chromiumos.json
[modify] https://crrev.com/589b7b025231a8a69a69c1a7f2a9091f5b9fdc9a/testing/buildbot/chromium.clang.json
[modify] https://crrev.com/589b7b025231a8a69a69c1a7f2a9091f5b9fdc9a/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/589b7b025231a8a69a69c1a7f2a9091f5b9fdc9a/testing/buildbot/chromium.gpu.fyi.json
[modify] https://crrev.com/589b7b025231a8a69a69c1a7f2a9091f5b9fdc9a/testing/buildbot/chromium.gpu.json
[modify] https://crrev.com/589b7b025231a8a69a69c1a7f2a9091f5b9fdc9a/testing/buildbot/chromium.linux.json
[modify] https://crrev.com/589b7b025231a8a69a69c1a7f2a9091f5b9fdc9a/testing/buildbot/chromium.mac.json
[modify] https://crrev.com/589b7b025231a8a69a69c1a7f2a9091f5b9fdc9a/testing/buildbot/chromium.memory.json
[modify] https://crrev.com/589b7b025231a8a69a69c1a7f2a9091f5b9fdc9a/testing/buildbot/chromium.win.json
[modify] https://crrev.com/589b7b025231a8a69a69c1a7f2a9091f5b9fdc9a/testing/buildbot/test_suite_exceptions.pyl
[modify] https://crrev.com/589b7b025231a8a69a69c1a7f2a9091f5b9fdc9a/testing/buildbot/test_suites.pyl
[modify] https://crrev.com/589b7b025231a8a69a69c1a7f2a9091f5b9fdc9a/testing/buildbot/waterfalls.pyl
[modify] https://crrev.com/589b7b025231a8a69a69c1a7f2a9091f5b9fdc9a/third_party/libjingle_xmpp/README.chromium
[modify] https://crrev.com/589b7b025231a8a69a69c1a7f2a9091f5b9fdc9a/third_party/libjingle_xmpp/task_runner/task_unittest.cc
[modify] https://crrev.com/589b7b025231a8a69a69c1a7f2a9091f5b9fdc9a/tools/battor_agent/battor_connection_impl_unittest.cc
[modify] https://crrev.com/589b7b025231a8a69a69c1a7f2a9091f5b9fdc9a/ui/compositor/layer_unittest.cc

Comment 7 by m...@chromium.org, May 19 2018

Components: -Internals>Cast Internals>Cast>Streaming
Project Member

Comment 8 by bugdroid1@chromium.org, May 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e3b15b26491f649cffaccae05a4370f8367ddbcf

commit e3b15b26491f649cffaccae05a4370f8367ddbcf
Author: Pavel Feldman <pfeldman@chromium.org>
Date: Sat May 19 20:57:11 2018

Revert "Reduce number of different test suite configurations."

This reverts commit 589b7b025231a8a69a69c1a7f2a9091f5b9fdc9a.

Reason for revert: https://ci.chromium.org/buildbot/chromium.memory/Linux%20MSan%20Builder/11941

Original change's description:
> Reduce number of different test suite configurations.
> 
> - Remove all the "non_clang" and "_fyi" configs -- the clang
>   waterfall and the FYI waterfall should default to running the
>   same tests as the real waterfalls unless explicitly opted out.
>   Deviations here were very likely not intentional.
>   - This requires running chrome_cleaner_unittests on the regular
>     win bots, which seems like a good change anyhow.
> - Just include angle_unittests in chromium_gtests instead of
>   spuriously adding it here and there (but on all platforms).
>   We've had issues with this test unintentionally running on too
>   few bots.
> - Rename aura_gtests to non_android_and_mac_gtests
> - Include gl_tests in the normal chromium_linux_gtests and
>   chromium_android_gtests suites instead of having separate
>   _and_gl configs
> - Add gcm_unit_tests to chromium_gtests since it effectively
>   ran everywhere already, this allows deleting
>   non_android_and_cast_chromium_gtests. Use similar tactics to
>   remove non_android_and_cast_and_chromeos_chromium_gtests.
> - Address most "TODO: merge back to X" TODOs
> 
> The main effect is that this adds many tests to the chromium.clang
> waterfall, making it more consistent with the main waterfall.
> It also adds a couple of binaries to other waterfalls.
> 
> Bug: 843511, 843726 , 843729 , 843731 , 843732 , 843734 ,831999, 844582 
> TBR=disabled test owners
> 
> Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
> Change-Id: I67c3980009fc07897f1f6bab424ef6c5f11d4830
> Reviewed-on: https://chromium-review.googlesource.com/1061795
> Commit-Queue: Nico Weber <thakis@chromium.org>
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Reviewed-by: Kenneth Russell <kbr@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#560147}

TBR=thakis@chromium.org,dpranke@chromium.org,kbr@chromium.org

Change-Id: I645e08d0ae374f181836e5d3749f39e17e54d9f5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 843511,  843726 ,  843729 ,  843731 ,  843732 ,  843734 , 831999,  844582 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/1067052
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Pavel Feldman <pfeldman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560158}
[modify] https://crrev.com/e3b15b26491f649cffaccae05a4370f8367ddbcf/content/test/gpu/generate_buildbot_json.py
[modify] https://crrev.com/e3b15b26491f649cffaccae05a4370f8367ddbcf/media/cast/receiver/audio_decoder_unittest.cc
[modify] https://crrev.com/e3b15b26491f649cffaccae05a4370f8367ddbcf/testing/buildbot/chromium.android.fyi.json
[modify] https://crrev.com/e3b15b26491f649cffaccae05a4370f8367ddbcf/testing/buildbot/chromium.android.json
[modify] https://crrev.com/e3b15b26491f649cffaccae05a4370f8367ddbcf/testing/buildbot/chromium.chromiumos.json
[modify] https://crrev.com/e3b15b26491f649cffaccae05a4370f8367ddbcf/testing/buildbot/chromium.clang.json
[modify] https://crrev.com/e3b15b26491f649cffaccae05a4370f8367ddbcf/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/e3b15b26491f649cffaccae05a4370f8367ddbcf/testing/buildbot/chromium.gpu.fyi.json
[modify] https://crrev.com/e3b15b26491f649cffaccae05a4370f8367ddbcf/testing/buildbot/chromium.gpu.json
[modify] https://crrev.com/e3b15b26491f649cffaccae05a4370f8367ddbcf/testing/buildbot/chromium.linux.json
[modify] https://crrev.com/e3b15b26491f649cffaccae05a4370f8367ddbcf/testing/buildbot/chromium.mac.json
[modify] https://crrev.com/e3b15b26491f649cffaccae05a4370f8367ddbcf/testing/buildbot/chromium.memory.json
[modify] https://crrev.com/e3b15b26491f649cffaccae05a4370f8367ddbcf/testing/buildbot/chromium.win.json
[modify] https://crrev.com/e3b15b26491f649cffaccae05a4370f8367ddbcf/testing/buildbot/test_suite_exceptions.pyl
[modify] https://crrev.com/e3b15b26491f649cffaccae05a4370f8367ddbcf/testing/buildbot/test_suites.pyl
[modify] https://crrev.com/e3b15b26491f649cffaccae05a4370f8367ddbcf/testing/buildbot/waterfalls.pyl
[modify] https://crrev.com/e3b15b26491f649cffaccae05a4370f8367ddbcf/third_party/libjingle_xmpp/README.chromium
[modify] https://crrev.com/e3b15b26491f649cffaccae05a4370f8367ddbcf/third_party/libjingle_xmpp/task_runner/task_unittest.cc
[modify] https://crrev.com/e3b15b26491f649cffaccae05a4370f8367ddbcf/tools/battor_agent/battor_connection_impl_unittest.cc
[modify] https://crrev.com/e3b15b26491f649cffaccae05a4370f8367ddbcf/ui/compositor/layer_unittest.cc

Project Member

Comment 9 by bugdroid1@chromium.org, May 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/044dbed5fd8f9901855ad4e5b86d6eb298fe5261

commit 044dbed5fd8f9901855ad4e5b86d6eb298fe5261
Author: Nico Weber <thakis@chromium.org>
Date: Mon May 21 15:13:57 2018

run cast_unittests and gcm_unit_tests everywhere

Previously, they ran on the the clang and fyi android bots. cast_unittests
also ran on almost all desktop bots via non_android_and_clang_win_chromium_gtests.
gcm_unit_tests ran on almost all desktop bots via non_android_and_cast_chromium_gtests.

Effectively this adds the two binaries to the main waterfall android bots.
It also adds cast_unittests to the win/clang/tot and win/fyi bots,
and gcm_unit_tests to the linux cast audio bots.

Also unconditionally disable one cast_unittests test on Android since it
doesn't pass there (it was already disabled under android cfi).

This is part of an effort to reduce the number of test configurations.
Originally reviewed as part of https://chromium-review.googlesource.com/1061795,
which I'm now landing in smaller pieces.

TBR=kbr@chromium.org

Bug: 843511,831999
Change-Id: If4466d25664f8be72336b0da987732563fa049b3
Reviewed-on: https://chromium-review.googlesource.com/1067166
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560270}
[modify] https://crrev.com/044dbed5fd8f9901855ad4e5b86d6eb298fe5261/media/cast/receiver/audio_decoder_unittest.cc
[modify] https://crrev.com/044dbed5fd8f9901855ad4e5b86d6eb298fe5261/testing/buildbot/chromium.android.fyi.json
[modify] https://crrev.com/044dbed5fd8f9901855ad4e5b86d6eb298fe5261/testing/buildbot/chromium.android.json
[modify] https://crrev.com/044dbed5fd8f9901855ad4e5b86d6eb298fe5261/testing/buildbot/chromium.clang.json
[modify] https://crrev.com/044dbed5fd8f9901855ad4e5b86d6eb298fe5261/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/044dbed5fd8f9901855ad4e5b86d6eb298fe5261/testing/buildbot/chromium.linux.json
[modify] https://crrev.com/044dbed5fd8f9901855ad4e5b86d6eb298fe5261/testing/buildbot/test_suites.pyl

Cc: m...@chromium.org
Owner: ----
Status: Available (was: Assigned)

Sign in to add a comment