New issue
Advanced search Search tips

Issue 831994 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Closed: Aug 6
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

CCT: PageLoadMetricsObserver attached late for background tab

Project Member Reported by mattcary@chromium.org, Apr 12 2018

Issue description

CustomTabActivity only attaches a PageLoadMetricsObserver to a background tab when the tab is shown (in getHiddenTab(), via initializeMainTab()).

This probably means that it misses initial PageLoadMetrics events, such as the network quality information.
 
Cc: lizeb@chromium.org
@lizeb: One way to fix this would be to attach the CustomTabObserver as well as PageLoadMetricObserver to a hidden tab when it's created in CustomTabsConnection. If CustomTabActivity takes a hidden tab, it could avoid creating new observers in initializeMainTab. So that's all do-able, if a little messy.

A bigger question might be what to do with the notifications. Broadcasting metrics for prerendered tabs that are not explicitly navigated to will be a change from what CCT clients currently see and it may be difficult (or at least different from their current implementation) for them to distinguish prerendered events from a "real" page load. In other words, the usual prerendering problem.

An alternative might be to batch up the notifications that would be sent while the hidden tab loads, and send them only when the hidden tab is taken and shown. Since all the notifications are piped through CustomTabsConnection, this wouldn't be too hard, but would be a fair amount of work for something that's arguably not a big deal.

Do you have any opinion?
Status: WontFix (was: Started)
[delayed] update:

It has turned out in practice that this issue is not critical for network quality metrics. In view of the new policy on metrics exported to CCT [1], it does not seem worth doing much in this direction.

[1] https://docs.google.com/document/d/16ZBWOl06BTUKnRMjZDI0uFl9bXUZoymyz4KvOWN8I9g/edit

Sign in to add a comment