Issue metadata
Sign in to add a comment
|
Regression:Disabling the extension creates a white space between omnibox and wrench-menu.
Reported by
shruti.j...@etouch.net,
Apr 12 2018
|
||||||||||||||||||||||
Issue descriptionChrome version : 67.0.3395.0 (Official Build) (64-bit) (cohort: Stable) Revision 19ac07e50344cdf4089e5d1b696958867736fc03-refs/heads/master@{#549859} OS : Windows(7,8,8.1,10),Linux(14.04 LTS) Test URL:https://chrome.google.com/webstore/detail/grammarly-for-chrome/kbfnbcaeplbcioakkpcpgfkobkghlhen?utm_source=chrome-ntp-icon Steps to reproduce: 1.Launch chrome and navigate to above URL and download the extension. 2.Right Click on extension icon in omnibox and select ‘Manage extension ’ from context menu and observe. Actual Result : Disabling the extension creates a white space between omnibox and wrench-menu. Expected Result :Disabling the extension should not create a white space between omnibox and wrench-menu. Thank you.
,
Apr 13 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e8b35e25301e4b7e4e48c5101e156a6cd5c36013 commit e8b35e25301e4b7e4e48c5101e156a6cd5c36013 Author: Peter Boström <pbos@chromium.org> Date: Fri Apr 13 03:44:58 2018 Return unclamped width for BrowserActionsContainer This method is used from ToolbarActionsBar to see if BrowserActionsContainer is larger than all visible actions (and needs to be downsized). Per a recent change this was clamping to the ToolbarActionsBar max size which would make ToolbarActionsBar think it's already the appropriate full size and not not animate it to the smaller new full size. Bug: chromium:831977 Change-Id: I1a8b3a83504a4f0afcf6e72146bef0e85ecc4fd9 Reviewed-on: https://chromium-review.googlesource.com/1011343 Reviewed-by: Bret Sepulveda <bsep@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#550504} [modify] https://crrev.com/e8b35e25301e4b7e4e48c5101e156a6cd5c36013/chrome/browser/ui/views/toolbar/browser_actions_container.cc
,
Apr 13 2018
,
Apr 13 2018
Good catch, thank you!
,
Apr 16 2018
,
Apr 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e8b35e25301e4b7e4e48c5101e156a6cd5c36013 commit e8b35e25301e4b7e4e48c5101e156a6cd5c36013 Author: Peter Boström <pbos@chromium.org> Date: Fri Apr 13 03:44:58 2018 Return unclamped width for BrowserActionsContainer This method is used from ToolbarActionsBar to see if BrowserActionsContainer is larger than all visible actions (and needs to be downsized). Per a recent change this was clamping to the ToolbarActionsBar max size which would make ToolbarActionsBar think it's already the appropriate full size and not not animate it to the smaller new full size. Bug: chromium:831977 Change-Id: I1a8b3a83504a4f0afcf6e72146bef0e85ecc4fd9 Reviewed-on: https://chromium-review.googlesource.com/1011343 Reviewed-by: Bret Sepulveda <bsep@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#550504} [modify] https://crrev.com/e8b35e25301e4b7e4e48c5101e156a6cd5c36013/chrome/browser/ui/views/toolbar/browser_actions_container.cc |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by shruti.j...@etouch.net
, Apr 12 2018Owner: pbos@chromium.org
Status: Assigned (was: Unconfirmed)
1.3 MB
1.3 MB View Download