New issue
Advanced search Search tips

Issue 831975 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug

Blocking:
issue 800570



Sign in to add a comment

"external/wpt/html/syntax/parsing/html5lib_template.html?run_type=uri" isn't marked as "Slow"

Project Member Reported by chromium...@appspot.gserviceaccount.com, Apr 12 2018

Issue description

"external/wpt/html/syntax/parsing/html5lib_template.html?run_type=uri" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyTwsSBUZsYWtlIkRleHRlcm5hbC93cHQvaHRtbC9zeW50YXgvcGFyc2luZy9odG1sNWxpYl90ZW1wbGF0ZS5odG1sP3J1bl90eXBlPXVyaQw.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
 
Labels: -Sheriff-Chromium OS-Linux
Owner: shend@chromium.org
Status: Assigned (was: Untriaged)

Comment 2 by shend@chromium.org, Apr 12 2018

Cc: shend@chromium.org
Components: Blink>HTML>Parser
Owner: tkent@chromium.org
Hmm, not sure why I was assigned? Seems like a Blink>HTML>Parser issue.

Not sure who to assign this to. tkent-san, could you PTAL and redirect it to the right person? Thanks!

Comment 3 by tkent@chromium.org, Apr 13 2018

Cc: tkent@chromium.org robertma@chromium.org jeffcarp@chromium.org qyears...@chromium.org
Components: -Blink>HTML>Parser Blink>Infra
Owner: ----
Status: Untriaged (was: Assigned)
Summary: "external/wpt/html/syntax/parsing/html5lib_template.html?run_type=uri" isn't marked as "Slow" (was: "external/wpt/html/syntax/parsing/html5lib_template.html?run_type=uri" is flaky)
This is a Blink infra issue. timeout:long in MANIFEST.json doesn't work for tests of which URLs don't match to their file names.

MANIFEST.json has:

   "html/syntax/parsing/html5lib_template.html": [
    [
     "/html/syntax/parsing/html5lib_template.html?run_type=uri",
     {
      "timeout": "long"
     }
    ],

So, the test should be treated as "Slow".

wpt_manifest.py:

    def is_slow_test(self, test_name):
        items = self._items_for_path(test_name)
        if not items:
            return False
        extras = WPTManifest._get_extras_from_item(items[0])
        return 'timeout' in extras and extras['timeout'] == 'long'

where |test_name| is "html/syntax/parsing/html5lib_template.html?run_type=uri". It' s not a path, and _items_for_path() returns None.

Blocking: 800570
Cc: -robertma@chromium.org
Components: Blink>Infra>Ecosystem
Owner: robertma@chromium.org
Status: Assigned (was: Untriaged)
Thanks for the investigation. This is yet another edge case related to issue 800570 that hasn't been taken care of.

Comment 5 by tkent@chromium.org, Apr 13 2018

Cc: robertma@chromium.org
 Issue 803943  has been merged into this issue.

Comment 6 by tkent@chromium.org, Apr 13 2018

 Issue 831058  has been merged into this issue.

Comment 7 by tkent@chromium.org, Apr 13 2018

Cc: yhirano@chromium.org
 Issue 800359  has been merged into this issue.
Project Member

Comment 9 by bugdroid1@chromium.org, May 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6f0b5d97163ec24c5651475285449890d316734b

commit 6f0b5d97163ec24c5651475285449890d316734b
Author: Robert Ma <robertma@chromium.org>
Date: Fri May 04 14:15:35 2018

[blinkpy] Find manifest items for tests by URL

When running WPT in web_tests, test names are more like URLs instead of
file paths (to be precise, the part of a test name after external/wpt is
a WPT URL), because WPT can generate multiple tests (variations) for a
single test file (e.g. .any.js, ?run_type).

Therefore, when asking questions like "is a test slow?", we need to find
the manifest item for that test by URL instead of by file path; whereas
if we want to know if a file in external/wpt is a test file, we find
the manifest item(s) for that file by file path.

This CL separates the two types of manifest queries, and chooses the
correct one for each call site. Besides, unit tests are improved to
cover the WPT variations (.any.js & ?run_type).

Bug:  831975 , 800570
Change-Id: I230d5ec7df06b7df1387da1b93788d6cae55d153
Reviewed-on: https://chromium-review.googlesource.com/1043160
Commit-Queue: Robert Ma <robertma@chromium.org>
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556043}
[modify] https://crrev.com/6f0b5d97163ec24c5651475285449890d316734b/third_party/blink/tools/blinkpy/w3c/wpt_manifest.py
[modify] https://crrev.com/6f0b5d97163ec24c5651475285449890d316734b/third_party/blink/tools/blinkpy/web_tests/port/base.py
[modify] https://crrev.com/6f0b5d97163ec24c5651475285449890d316734b/third_party/blink/tools/blinkpy/web_tests/port/base_unittest.py

Project Member

Comment 10 by bugdroid1@chromium.org, May 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/732cc14175c56476b0b172f6d398518fee7912a0

commit 732cc14175c56476b0b172f6d398518fee7912a0
Author: Robert Ma <robertma@chromium.org>
Date: Fri May 04 15:26:17 2018

Remove some timeout expectations after a bug fix

These tests already declare to be slow (long timeout), but due to a bug
we previously didn't parse the manifest correctly so we missed them.
https://crrev.com/c/1043160 fixed the issue so we can now remove these
expectations.

TBR=tkent

Bug:  803943 , 818324, 803558,  831975 
Change-Id: I8f978d025e026b77dd6f42ade6de8e283886c024
Reviewed-on: https://chromium-review.googlesource.com/1044293
Reviewed-by: Robert Ma <robertma@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556062}
[modify] https://crrev.com/732cc14175c56476b0b172f6d398518fee7912a0/third_party/WebKit/LayoutTests/TestExpectations

Status: Fixed (was: Started)
Project Member

Comment 12 by bugdroid1@chromium.org, May 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/266b8bce041014954439d75c47607d38ebea4cb8

commit 266b8bce041014954439d75c47607d38ebea4cb8
Author: CJ DiMeglio <lethalantidote@chromium.org>
Date: Fri May 04 16:31:25 2018

Revert "[blinkpy] Find manifest items for tests by URL"

This reverts commit 6f0b5d97163ec24c5651475285449890d316734b.

Reason for revert: Causing Webkit Linux Trusty Leak to fail
https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20Leak/

Original change's description:
> [blinkpy] Find manifest items for tests by URL
> 
> When running WPT in web_tests, test names are more like URLs instead of
> file paths (to be precise, the part of a test name after external/wpt is
> a WPT URL), because WPT can generate multiple tests (variations) for a
> single test file (e.g. .any.js, ?run_type).
> 
> Therefore, when asking questions like "is a test slow?", we need to find
> the manifest item for that test by URL instead of by file path; whereas
> if we want to know if a file in external/wpt is a test file, we find
> the manifest item(s) for that file by file path.
> 
> This CL separates the two types of manifest queries, and chooses the
> correct one for each call site. Besides, unit tests are improved to
> cover the WPT variations (.any.js & ?run_type).
> 
> Bug:  831975 , 800570
> Change-Id: I230d5ec7df06b7df1387da1b93788d6cae55d153
> Reviewed-on: https://chromium-review.googlesource.com/1043160
> Commit-Queue: Robert Ma <robertma@chromium.org>
> Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#556043}

TBR=qyearsley@chromium.org,robertma@chromium.org

Change-Id: I5fb2c257967e32d1e4fce4277c10d77635e303d4
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  831975 , 800570
Reviewed-on: https://chromium-review.googlesource.com/1044567
Reviewed-by: CJ DiMeglio <lethalantidote@chromium.org>
Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556083}
[modify] https://crrev.com/266b8bce041014954439d75c47607d38ebea4cb8/third_party/blink/tools/blinkpy/w3c/wpt_manifest.py
[modify] https://crrev.com/266b8bce041014954439d75c47607d38ebea4cb8/third_party/blink/tools/blinkpy/web_tests/port/base.py
[modify] https://crrev.com/266b8bce041014954439d75c47607d38ebea4cb8/third_party/blink/tools/blinkpy/web_tests/port/base_unittest.py

Project Member

Comment 13 by bugdroid1@chromium.org, May 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a244e7595ef2030d72c6bac7dc8880bdac573ffa

commit a244e7595ef2030d72c6bac7dc8880bdac573ffa
Author: Robert Ma <robertma@chromium.org>
Date: Fri May 04 18:27:42 2018

Reland "[blinkpy] Find manifest items for tests by URL"

This is a reland of 6f0b5d97163ec24c5651475285449890d316734b

A baseline is added for a test that no longer (always) times out because
of this fix. The test has a few failing subtests so a baseline is needed.

Original change's description:
> [blinkpy] Find manifest items for tests by URL
>
> When running WPT in web_tests, test names are more like URLs instead of
> file paths (to be precise, the part of a test name after external/wpt is
> a WPT URL), because WPT can generate multiple tests (variations) for a
> single test file (e.g. .any.js, ?run_type).
>
> Therefore, when asking questions like "is a test slow?", we need to find
> the manifest item for that test by URL instead of by file path; whereas
> if we want to know if a file in external/wpt is a test file, we find
> the manifest item(s) for that file by file path.
>
> This CL separates the two types of manifest queries, and chooses the
> correct one for each call site. Besides, unit tests are improved to
> cover the WPT variations (.any.js & ?run_type).
>
> Bug:  831975 , 800570
> Change-Id: I230d5ec7df06b7df1387da1b93788d6cae55d153
> Reviewed-on: https://chromium-review.googlesource.com/1043160
> Commit-Queue: Robert Ma <robertma@chromium.org>
> Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#556043}

Bug:  831975 , 800570
Change-Id: I65e818473153b134af8dc78677b1b678d196aada
Reviewed-on: https://chromium-review.googlesource.com/1044586
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556126}
[add] https://crrev.com/a244e7595ef2030d72c6bac7dc8880bdac573ffa/third_party/WebKit/LayoutTests/external/wpt/WebCryptoAPI/derive_bits_keys/pbkdf2.https.worker-expected.txt
[modify] https://crrev.com/a244e7595ef2030d72c6bac7dc8880bdac573ffa/third_party/blink/tools/blinkpy/w3c/wpt_manifest.py
[modify] https://crrev.com/a244e7595ef2030d72c6bac7dc8880bdac573ffa/third_party/blink/tools/blinkpy/web_tests/port/base.py
[modify] https://crrev.com/a244e7595ef2030d72c6bac7dc8880bdac573ffa/third_party/blink/tools/blinkpy/web_tests/port/base_unittest.py

Sign in to add a comment