New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 831969 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Jul 20
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug
Team-Accessibility



Sign in to add a comment

Switch Access highlight not going away after disabling

Project Member Reported by leberly@chromium.org, Apr 12 2018

Issue description

Google Chrome 67.0.3383.0 (Official Build) dev (64-bit)
Google_Samus.6300.276.0
Chrome OS with flag enabled: #enable-experimental-accessibility-features

Note that Switch Access is still under development and is not yet a full feature. I started using it just to disambiguate STS and ChromeVox bugs.  

Steps:
# Go to Settings > Accessibility > Manage Accessibility features and enable Switch Access
# Note that there is now a green ring around the area of any page that has focus 
# Disable Switch Access
Expected: focus ring goes away
Actual: focus ring remains 

Please see this video for the repro: https://drive.google.com/file/d/1Md45NpHyqoQ9pOWsUSyft5U9PaTWI-Go/view

As a workaround, I clear it by invoking another application that uses a focus ring such as STS or ChromeVox. 

 
Description: Show this description
Labels: SwitchAccessCrOS
Cc: zhelfins@chromium.org
Cc: -zhelfins@chromium.org
Owner: zhelfins@chromium.org
Status: Started (was: Available)
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e2a2c68a7e650eca3154d3fb76d2c1167979b501

commit e2a2c68a7e650eca3154d3fb76d2c1167979b501
Author: Zach Helfinstein <zhelfins@chromium.org>
Date: Fri Jul 20 21:19:27 2018

Clear SwitchAccess focus ring when disabled

When the SwitchAccess extension has been successfully unloaded,
clear the focus ring.

Bug:  831969 
Change-Id: I33e4580db15463d502d5d2273c7285cf3dad0154
Reviewed-on: https://chromium-review.googlesource.com/1141336
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Katie Dektar <katie@chromium.org>
Commit-Queue: Zach Helfinstein <zhelfins@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576990}
[modify] https://crrev.com/e2a2c68a7e650eca3154d3fb76d2c1167979b501/ash/accessibility/accessibility_focus_ring_controller.cc
[modify] https://crrev.com/e2a2c68a7e650eca3154d3fb76d2c1167979b501/chrome/browser/chromeos/accessibility/accessibility_manager.cc
[modify] https://crrev.com/e2a2c68a7e650eca3154d3fb76d2c1167979b501/chrome/browser/chromeos/accessibility/accessibility_manager.h

Status: Fixed (was: Started)
Labels: a11y-testers
Adding label a11y-testers so that it's in the queue for verification. For any future bugs you'd like to be verified, please include that label. Thanks!
Labels: -a11y-testers
Status: Verified (was: Fixed)
Chrome Version:	70.0.3511.0 (Official Build) canary (64-bit)
CrOS Firmware Version:	Google_Eve.9584.160.0

Enabled experimental accessibility features flag. 
Turned on Switch Access in settings
Tabbed once to move the focus highlight
Turned off feature in settings
Focus highlight went away as expected. 

Sign in to add a comment