New issue
Advanced search Search tips

Issue 831956 link

Starred by 1 user
Status: Fixed
Owner:
yuweih@chromium.org
Closed: Apr 2018
Cc:
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug



Sign in to add a comment

[CRD iOS] Crash at FillWithChromotingEvent(...)

Project Member Reported by yuweih@chromium.org, Apr 12 2018 
The host os enum "Other" is not translated to string. It's unsure what host will produce this enum but we should still fix this.
Screen Shot 2018-04-11 at 9.43.03 PM.png
276 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 12 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f55e65e97dcc0d0e3b62afa80ffdf324f04dc386

commit f55e65e97dcc0d0e3b62afa80ffdf324f04dc386
Author: Yuwei Huang <yuweih@chromium.org>
Date: Thu Apr 12 21:01:11 2018

[CRD iOS] Add enum string name for OS::OTHER

We got some crash reports happened when the user tries to send a
feedback during a session. Looks like their host os is OTHER, which is
not mapped to a string and crashes the app.

It's unsure when will the host OS be OTHER. Let's just add back the
mapping for now.

Bug:  831956 
Change-Id: I2bf285955a266ab61aae4dfc525b5185546c9109
Reviewed-on: https://chromium-review.googlesource.com/1010969
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550355}
[modify] https://crrev.com/f55e65e97dcc0d0e3b62afa80ffdf324f04dc386/remoting/base/chromoting_event.cc

Comment 2 by yuweih@chromium.org, Apr 13 2018

Status: Fixed (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 17 2018

Labels: merge-merged-testbranch
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f55e65e97dcc0d0e3b62afa80ffdf324f04dc386

commit f55e65e97dcc0d0e3b62afa80ffdf324f04dc386
Author: Yuwei Huang <yuweih@chromium.org>
Date: Thu Apr 12 21:01:11 2018

[CRD iOS] Add enum string name for OS::OTHER

We got some crash reports happened when the user tries to send a
feedback during a session. Looks like their host os is OTHER, which is
not mapped to a string and crashes the app.

It's unsure when will the host OS be OTHER. Let's just add back the
mapping for now.

Bug:  831956 
Change-Id: I2bf285955a266ab61aae4dfc525b5185546c9109
Reviewed-on: https://chromium-review.googlesource.com/1010969
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550355}
[modify] https://crrev.com/f55e65e97dcc0d0e3b62afa80ffdf324f04dc386/remoting/base/chromoting_event.cc
►

Sign in to add a comment