[CRD iOS] Crash at SendClientResolution(int, int, int) |
||||||
Issue description
,
Apr 13 2018
This should only affect Chromoting and not the Chrome browser.
,
Apr 14 2018
Your change meets the bar and is auto-approved for M67. Please go ahead and merge the CL to branch 3396 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 16 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5dca3e6c6cec7ff135685db633d09d14b5715365 commit 5dca3e6c6cec7ff135685db633d09d14b5715365 Author: Yuwei Huang <yuweih@chromium.org> Date: Mon Apr 16 20:01:43 2018 [CRD iOS] Prevent crash for accessing _session after the session is disconnected _session is only valid when the session is connected. This CL adds tests before using _session in RemotingClient. Bug: 831954 Change-Id: I0f12221f2c80b55d0a784dc8771fbec573fd1deb Reviewed-on: https://chromium-review.googlesource.com/1010917 Reviewed-by: Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#550438}(cherry picked from commit 6a647c7f3332d5d643f0c38e063f3f09730169bc) Reviewed-on: https://chromium-review.googlesource.com/1012791 Reviewed-by: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/branch-heads/3396@{#25} Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428} [modify] https://crrev.com/5dca3e6c6cec7ff135685db633d09d14b5715365/remoting/client/chromoting_session.cc [modify] https://crrev.com/5dca3e6c6cec7ff135685db633d09d14b5715365/remoting/client/chromoting_session.h [modify] https://crrev.com/5dca3e6c6cec7ff135685db633d09d14b5715365/remoting/ios/session/remoting_client.mm
,
Apr 16 2018
,
Apr 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6a647c7f3332d5d643f0c38e063f3f09730169bc commit 6a647c7f3332d5d643f0c38e063f3f09730169bc Author: Yuwei Huang <yuweih@chromium.org> Date: Fri Apr 13 00:37:05 2018 [CRD iOS] Prevent crash for accessing _session after the session is disconnected _session is only valid when the session is connected. This CL adds tests before using _session in RemotingClient. Bug: 831954 Change-Id: I0f12221f2c80b55d0a784dc8771fbec573fd1deb Reviewed-on: https://chromium-review.googlesource.com/1010917 Reviewed-by: Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#550438} [modify] https://crrev.com/6a647c7f3332d5d643f0c38e063f3f09730169bc/remoting/client/chromoting_session.cc [modify] https://crrev.com/6a647c7f3332d5d643f0c38e063f3f09730169bc/remoting/client/chromoting_session.h [modify] https://crrev.com/6a647c7f3332d5d643f0c38e063f3f09730169bc/remoting/ios/session/remoting_client.mm |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by bugdroid1@chromium.org
, Apr 13 2018