New issue
Advanced search Search tips

Issue 831952 link

Starred by 1 user
Status: Available
Owner: ----
Cc:
editing-dev@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment

Simplify PositionWithAffinity constructors

Project Member Reported by yosin@chromium.org, Apr 12 2018 
To simplify PwA construction and identify callers which don't care about
affinity. We would like to change PwA construction as follows:

1. Change to PwA(position, affinity); make |affinity| is required and |affinity| should not be constant.
2. Introduce PwA(position); for callers don't care affinity
3. Introduce PwA::DownstreamOf(pos) and PwA::UpstreamOf(pos); PwA(pos, const) should be used one of DownstreamOf() or UpstreamOf()

PwA::DownstreamOf()/UpstreamOf() are similar to Position::BeforeNode()/AfterNode().
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 18 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d31eac66d10bea66bb84de2d8a7da61e3cd73a13

commit d31eac66d10bea66bb84de2d8a7da61e3cd73a13
Author: tanvir.rizvi <tanvir.rizvi@samsung.com>
Date: Wed Apr 18 08:45:07 2018

Simplify PositionWithAffinity constructors

PositionWithAffinity uses default affinity as second
parameter.
This CL introduces
1) PositionWithAffinity(Position) and
2) Makes default affinity as a required field.

Bug: 831952
Change-Id: Ie13f8ca3b612587d953628c56402bb9108fea1b5
Reviewed-on: https://chromium-review.googlesource.com/1014862
Commit-Queue: Tanvir Rizvi <tanvir.rizvi@samsung.com>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551613}
[modify] https://crrev.com/d31eac66d10bea66bb84de2d8a7da61e3cd73a13/third_party/blink/renderer/core/editing/position_with_affinity.cc
[modify] https://crrev.com/d31eac66d10bea66bb84de2d8a7da61e3cd73a13/third_party/blink/renderer/core/editing/position_with_affinity.h
►

Sign in to add a comment