Modern Media Controls: media/webkit-media-controls-webkit-appearance.html fails incorrectly |
||
Issue descriptionThe media/webkit-media-controls-webkit-appearance.html layout test is testing that there is no crash when setting the -webkit-appearance attribute on ::webkit-media-controls. This correctly does not crash with the new media controls, but due to visual changes the expected file no longer matches the actual file, and there's not a simple way to get them to match. Disabling the test for now.
,
Apr 12 2018
+foolip@ in case of he has some memory of this place :)
,
Apr 12 2018
I remember the bug, but it looks like https://chromium.googlesource.com/chromium/src/+/0cfdea8931d2aa8a3ec5414435c8652324f0027e/third_party/blink/renderer/core/layout/layout_media.cc no longer has that code nor does is_child_allowed seem to exist. Digging into when it was removed might reveal whether this could possibly regress again, but simply deleting the test seems quite reasonable to me, once disabling it'll remain forever so.
,
Apr 13 2018
foolip@, to clarify, the intent of this bug is to decide whether we should fix the test or remove it. Would you have an idea why using the new controls would make this test fail? Sounds that this should be orthogonal to the code not being there is layout_media.cc
,
Apr 13 2018
I don't know anything about how the new controls are different, so no clue :) But even without that change, seems like the bug this was written against is very unlikely to reappear in the same form as the code is gone, so I'd just delete it. |
||
►
Sign in to add a comment |
||
Comment 1 by steimel@chromium.org
, Apr 12 2018