New issue
Advanced search Search tips

Issue 831931 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Warn/error on trying to load an extension with an html/html/js icon

Project Member Reported by rdevlin....@chromium.org, Apr 12 2018

Issue description

After revision 4f9644ce37ed42380a0c013aac4d9febbb552426, html, js, html, etc files will all be verified with content verification.  This means that any icon set to a [html html js] file will fail verification.

With this being the case, we should at minimum warn developers when they load the extension, and likely make this a flat-out load failure (so that the extension doesn't get added, rather than having it be added and immediately disabled for corruption).

Forking from https://bugs.chromium.org/p/chromium/issues/detail?id=809088#c11.
 
I wonder what Chrome's icon-repacking mechanism would do on files that aren't actually image files. I think that it skips repacking them.

If that's the case, the extension would not be immediately disabled for corruption (as its hash would match the verified_contents')

Sign in to add a comment