New issue
Advanced search Search tips

Issue 831929 link

Starred by 1 user
Status: Fixed
Owner:
dgarr...@chromium.org
Closed: Apr 2018
Cc:
jclinton@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

binhost_test needs to know which builds are "active".

Project Member Reported by dgarr...@chromium.org, Apr 12 2018 
binhost test ensures that we are publishing the necessary binary prebuilts for Chrome.

To do this, it looks for build configs that need that prebuilt, but skips configs which aren't actually build.

Today, it uses the logic:

     production_config = (
          (config.build_type == config_lib.CONFIG_TYPE_PRECQ) or
          (config.active_waterfall and
           config.active_waterfall != waterfall.WATERFALL_TRYBOT)
      )

      if builds_chrome and production_config:
        self.AssertChromePrebuilts(pfq_configs, config)

However, as we move builds to swarming, they no longer have a waterfall (or, they all have the same waterfall), which breaks that test. The only source of truth for "production_config" is the luci-scheduler.

Comment 1 by dgarr...@chromium.org, Apr 12 2018 

Doing some investigation....

The main builders which appear to need binhost_test coverage are:
  CQ
  Android PFQs
  incrementals
  misc - one off configs.

Comment 2 by dgarr...@chromium.org, Apr 12 2018

Cc: jclinton@chromium.org
Labels: Swarming
Alternatives:

A)
Searching for all master builders and their defined slave configs will cover the CQ and all Android PFQs, but not incrementals or misc builders.

B)
We could use chromeos_config to track which builds are in production, and which aren't. Perhaps by setting waterfall to None for builds that aren't actively built, but we would need a way to keep this in sync to keep it current.

C)
If we were generating the LUCI Scheduler config, the source of truth could be shared.

Comment 3 by dgarr...@chromium.org, Apr 12 2018

Labels: -Pri-3 Pri-2
I'm going to implement A, with a reference to this bug.

Comment 4 by dgarr...@chromium.org, Apr 12 2018 

PS: I found this while cleaning up waterfall definitions, and realized it would become a migration blocker.

Comment 5 by dgarr...@chromium.org, Apr 12 2018

Owner: dgarr...@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 6 by bugdroid1@chromium.org, Apr 14 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/ec02171f49658842d17f4ed30b0aa1e7a0e060be

commit ec02171f49658842d17f4ed30b0aa1e7a0e060be
Author: Don Garrett <dgarrett@google.com>
Date: Sat Apr 14 01:45:41 2018

binhost_test: Update active config definition.

As builds move to swarming, waterfall is no longer a good indication
of being actively built, so come up with a new approximation of
collecting all slave configs.

This leaves out a few other builders, but is hopefully good enough.

BUG= chromium:831929 
TEST=cros tryjob binhost-pre-cq

Change-Id: I2e67a300051e5057fa14e1c07ab0fb39eba1575e
Reviewed-on: https://chromium-review.googlesource.com/1009203
Commit-Ready: Don Garrett <dgarrett@chromium.org>
Tested-by: Don Garrett <dgarrett@chromium.org>
Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org>

[modify] https://crrev.com/ec02171f49658842d17f4ed30b0aa1e7a0e060be/cbuildbot/binhost_test.py
Project Member

Comment 7 by bugdroid1@chromium.org, Apr 14 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/534604989fb65f011221a41a5fd378485468b598

commit 534604989fb65f011221a41a5fd378485468b598
Author: chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Sat Apr 14 05:15:09 2018

Roll src/third_party/chromite/ c23684514..2e290076c (7 commits)

https://chromium.googlesource.com/chromiumos/chromite.git/+log/c23684514c93..2e290076c8be

$ git log c23684514..2e290076c --date=short --no-merges --format='%ad %ae %s'
2018-04-12 pwang chromeos_config: Mark kevin-arcnext important
2018-04-11 dgarrett binhost_test: Update active config definition.
2018-04-13 dgarrett chromeos-config: Add hwtests to eve chrome tot informational.
2018-04-10 pprabhu cbuildbot: Add pre-cq builder to run infra specific unittests.
2018-04-12 manojgupta cros_setup_toolchains: Update list of post cross packages.
2018-04-12 dgarrett chromeos_config: Move chromiumos-sdk to 'utility' group.
2018-04-09 dgarrett remote_try: Remove buildbot specific behaviors.

Created with:
  roll-dep src/third_party/chromite
BUG= chromium:831929 , chromium:829898 ,chromium:None,chromium:820330,chromium:None,chromium:None


The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: I15b87a3f6a81bd9abdfcc59147a98f0d59932383
Reviewed-on: https://chromium-review.googlesource.com/1013383
Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#550881}
[modify] https://crrev.com/534604989fb65f011221a41a5fd378485468b598/DEPS

Comment 8 by dgarr...@chromium.org, Apr 16 2018

Status: Fixed (was: Started)
Project Member

Comment 9 by bugdroid1@chromium.org, Apr 17 2018

Labels: merge-merged-testbranch
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/534604989fb65f011221a41a5fd378485468b598

commit 534604989fb65f011221a41a5fd378485468b598
Author: chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Sat Apr 14 05:15:09 2018

Roll src/third_party/chromite/ c23684514..2e290076c (7 commits)

https://chromium.googlesource.com/chromiumos/chromite.git/+log/c23684514c93..2e290076c8be

$ git log c23684514..2e290076c --date=short --no-merges --format='%ad %ae %s'
2018-04-12 pwang chromeos_config: Mark kevin-arcnext important
2018-04-11 dgarrett binhost_test: Update active config definition.
2018-04-13 dgarrett chromeos-config: Add hwtests to eve chrome tot informational.
2018-04-10 pprabhu cbuildbot: Add pre-cq builder to run infra specific unittests.
2018-04-12 manojgupta cros_setup_toolchains: Update list of post cross packages.
2018-04-12 dgarrett chromeos_config: Move chromiumos-sdk to 'utility' group.
2018-04-09 dgarrett remote_try: Remove buildbot specific behaviors.

Created with:
  roll-dep src/third_party/chromite
BUG= chromium:831929 , chromium:829898 ,chromium:None,chromium:820330,chromium:None,chromium:None


The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: I15b87a3f6a81bd9abdfcc59147a98f0d59932383
Reviewed-on: https://chromium-review.googlesource.com/1013383
Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#550881}
[modify] https://crrev.com/534604989fb65f011221a41a5fd378485468b598/DEPS
►

Sign in to add a comment