Clamshell device continue to power off even after release power button |
||||||
Issue descriptionWhat steps will reproduce the problem? (1) Press power button of a clamshell device to show power menu, eg.samus (2) Release power button before menu being fully shown. (3) Press power button quickly (inside 500ms) again. (4) Release power button before menu being fully shown. What is the expected result? Should cancel the showing menu animation, or should keep menu opened if menu is already fully shown and device should not be powered off. What happens instead? Device continue to power off even released the power button before trigger shutdown.
,
Apr 13 2018
,
Apr 16 2018
,
Apr 16 2018
Was this a M67 regression? When did the issue present itself?
,
Apr 16 2018
I believe that this regressed with the work for issue 799524, which is targeted for M67.
,
Apr 17 2018
Your change meets the bar and is auto-approved for M67. Please go ahead and merge the CL to branch 3396 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1e39dd5b993222f251ad451884f2408bdbe77cb9 commit 1e39dd5b993222f251ad451884f2408bdbe77cb9 Author: Min Chen <minch@google.com> Date: Fri Apr 13 04:12:01 2018 Cancel the ongoing animation for repeat power button releases. Should cancel the stated showing menu animation for repeat power button releases. Otherwise, the ongoing animation will run the callback function SetShowMenuAnimationDone to start |pre_shutdown_timer_| OnImplicitAnimationFinished after release the power button. This will lead to device power off. Bug: 831915 Change-Id: I07753f4156dfc7ba299c37f8fd7a7551d5ec858a Reviewed-on: https://chromium-review.googlesource.com/1009485 Reviewed-by: Dan Erat <derat@chromium.org> Reviewed-by: Qiang Xu <warx@google.com> Commit-Queue: Min Chen <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#550509} [modify] https://crrev.com/1e39dd5b993222f251ad451884f2408bdbe77cb9/ash/system/power/power_button_controller.cc [modify] https://crrev.com/1e39dd5b993222f251ad451884f2408bdbe77cb9/ash/system/power/power_button_controller_unittest.cc
,
Apr 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ad7ddfe7e3f80d046e636ae3ae9694863b172151 commit ad7ddfe7e3f80d046e636ae3ae9694863b172151 Author: Min Chen <minch@google.com> Date: Tue Apr 17 18:01:07 2018 [Merge to M67]Cancel the ongoing animation for repeat power button releases. TBR=minch@chromium.org Should cancel the stated showing menu animation for repeat power button releases. Otherwise, the ongoing animation will run the callback function SetShowMenuAnimationDone to start |pre_shutdown_timer_| OnImplicitAnimationFinished after release the power button. This will lead to device power off. (cherry picked from commit 1e39dd5b993222f251ad451884f2408bdbe77cb9) Bug: 831915 Change-Id: I07753f4156dfc7ba299c37f8fd7a7551d5ec858a Reviewed-on: https://chromium-review.googlesource.com/1009485 Reviewed-by: Dan Erat <derat@chromium.org> Reviewed-by: Qiang Xu <warx@google.com> Commit-Queue: Min Chen <minch@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#550509} Reviewed-on: https://chromium-review.googlesource.com/1015419 Reviewed-by: Min Chen <minch@chromium.org> Cr-Commit-Position: refs/branch-heads/3396@{#51} Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428} [modify] https://crrev.com/ad7ddfe7e3f80d046e636ae3ae9694863b172151/ash/system/power/power_button_controller.cc [modify] https://crrev.com/ad7ddfe7e3f80d046e636ae3ae9694863b172151/ash/system/power/power_button_controller_unittest.cc |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by bugdroid1@chromium.org
, Apr 13 2018