Issue 831909 link

Starred by 2 users

Issue metadata

Status:	Fixed
Owner:	rdevlin....@chromium.org
Closed:	Apr 2018
Cc:	karandeepb@chromium.org gov...@chromium.org lazyboy@chromium.org dbertoni@chromium.org
Components:	Platform>Extensions
EstimatedDays:	----
NextAction:	----
OS:	Linux , Windows , Chrome , Mac
Pri:	1
Type:	Bug
M-67 merge-merged-testbranch

Blocking:
issue 816677

Stop loading manifest v1 extensions

Project Member Reported by rdevlin....@chromium.org, Apr 12 2018

Issue description

Manifest v1 has been deprecated for many, many years. [1]  Chrome should stop loading these extensions.

[1] https://developer.chrome.com/extensions/manifestVersion

Project Member

Comment 1 by bugdroid1@chromium.org, Apr 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6c5c219bd2ad58651dcb596b1211ce948d67a53a

commit 6c5c219bd2ad58651dcb596b1211ce948d67a53a
Author: Devlin Cronin <rdevlin.cronin@chromium.org>
Date: Fri Apr 13 00:09:19 2018

[Extensions] Stop loading manifest v1 extensions

Manifest v1 extensions have been deprecated for a long time.
Stop loading these extensions unless a special (existing) commandline
flag is present. There are a few straggling tests (which rely on
packaged extension resources, like .crx files) that still need to be
updated; use the commandline flag (or a runtime variant) in those tests.
These will be cleaned up in follow-up CLs.

Bug:  831909 
Change-Id: If2323829cd75f826d54a34b713eecf7c28973667
Reviewed-on: https://chromium-review.googlesource.com/1009070
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550426}
[modify] https://crrev.com/6c5c219bd2ad58651dcb596b1211ce948d67a53a/chrome/browser/chromeos/extensions/active_tab_permission_granter_delegate_chromeos_unittest.cc
[modify] https://crrev.com/6c5c219bd2ad58651dcb596b1211ce948d67a53a/chrome/browser/chromeos/extensions/device_local_account_management_policy_provider_unittest.cc
[modify] https://crrev.com/6c5c219bd2ad58651dcb596b1211ce948d67a53a/chrome/browser/chromeos/extensions/extension_tab_util_delegate_chromeos_unittest.cc
[modify] https://crrev.com/6c5c219bd2ad58651dcb596b1211ce948d67a53a/chrome/browser/chromeos/extensions/permissions_updater_delegate_chromeos_unittest.cc
[modify] https://crrev.com/6c5c219bd2ad58651dcb596b1211ce948d67a53a/chrome/browser/chromeos/file_system_provider/service_unittest.cc
[modify] https://crrev.com/6c5c219bd2ad58651dcb596b1211ce948d67a53a/chrome/browser/chromeos/policy/device_local_account_browsertest.cc
[modify] https://crrev.com/6c5c219bd2ad58651dcb596b1211ce948d67a53a/chrome/browser/chromeos/ui/idle_app_name_notification_view_unittest.cc
[modify] https://crrev.com/6c5c219bd2ad58651dcb596b1211ce948d67a53a/chrome/browser/download/download_browsertest.cc
[modify] https://crrev.com/6c5c219bd2ad58651dcb596b1211ce948d67a53a/chrome/browser/extensions/component_loader_unittest.cc
[modify] https://crrev.com/6c5c219bd2ad58651dcb596b1211ce948d67a53a/chrome/browser/extensions/extension_browsertest.cc
[modify] https://crrev.com/6c5c219bd2ad58651dcb596b1211ce948d67a53a/chrome/browser/extensions/extension_garbage_collector_chromeos_unittest.cc
[modify] https://crrev.com/6c5c219bd2ad58651dcb596b1211ce948d67a53a/chrome/browser/extensions/extension_service_test_base.cc
[modify] https://crrev.com/6c5c219bd2ad58651dcb596b1211ce948d67a53a/chrome/browser/extensions/extension_service_test_base.h
[modify] https://crrev.com/6c5c219bd2ad58651dcb596b1211ce948d67a53a/chrome/browser/extensions/startup_helper_browsertest.cc
[modify] https://crrev.com/6c5c219bd2ad58651dcb596b1211ce948d67a53a/chrome/browser/policy/policy_browsertest.cc
[modify] https://crrev.com/6c5c219bd2ad58651dcb596b1211ce948d67a53a/chrome/browser/ui/app_list/search/launcher_search/launcher_search_icon_image_loader_unittest.cc
[modify] https://crrev.com/6c5c219bd2ad58651dcb596b1211ce948d67a53a/chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc
[modify] https://crrev.com/6c5c219bd2ad58651dcb596b1211ce948d67a53a/chrome/browser/ui/webui/extensions/extension_settings_browsertest.cc
[modify] https://crrev.com/6c5c219bd2ad58651dcb596b1211ce948d67a53a/chrome/browser/ui/webui/extensions/extension_settings_browsertest.h
[modify] https://crrev.com/6c5c219bd2ad58651dcb596b1211ce948d67a53a/chrome/common/extensions/manifest_tests/extension_manifests_manifest_version_unittest.cc
[modify] https://crrev.com/6c5c219bd2ad58651dcb596b1211ce948d67a53a/extensions/browser/sandboxed_unpacker_unittest.cc
[modify] https://crrev.com/6c5c219bd2ad58651dcb596b1211ce948d67a53a/extensions/common/BUILD.gn
[modify] https://crrev.com/6c5c219bd2ad58651dcb596b1211ce948d67a53a/extensions/common/extension.cc
[modify] https://crrev.com/6c5c219bd2ad58651dcb596b1211ce948d67a53a/extensions/common/extension.h
[add] https://crrev.com/6c5c219bd2ad58651dcb596b1211ce948d67a53a/extensions/common/extension_unittest.cc

Project Member

Comment 2 by bugdroid1@chromium.org, Apr 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/348808c076714a5422e9f6be8aca7e206d4c7464

commit 348808c076714a5422e9f6be8aca7e206d4c7464
Author: Jianpeng Chao <chaopeng@chromium.org>
Date: Fri Apr 13 03:11:24 2018

Revert "[Extensions] Stop loading manifest v1 extensions"

This reverts commit 6c5c219bd2ad58651dcb596b1211ce948d67a53a.

Reason for revert: buildbot failed

Original change's description:
> [Extensions] Stop loading manifest v1 extensions
> 
> Manifest v1 extensions have been deprecated for a long time.
> Stop loading these extensions unless a special (existing) commandline
> flag is present. There are a few straggling tests (which rely on
> packaged extension resources, like .crx files) that still need to be
> updated; use the commandline flag (or a runtime variant) in those tests.
> These will be cleaned up in follow-up CLs.
> 
> Bug:  831909 
> Change-Id: If2323829cd75f826d54a34b713eecf7c28973667
> Reviewed-on: https://chromium-review.googlesource.com/1009070
> Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
> Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
> Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
> Reviewed-by: Min Qin <qinmin@chromium.org>
> Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#550426}

TBR=stevenjb@chromium.org,pastarmovj@chromium.org,lazyboy@chromium.org,rdevlin.cronin@chromium.org,qinmin@chromium.org

Change-Id: I5a0a4c7f90421d139dce7cdc27d1affa2059c5a4
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  831909 ,  832488 
Reviewed-on: https://chromium-review.googlesource.com/1011710
Reviewed-by: Jianpeng Chao <chaopeng@chromium.org>
Commit-Queue: Jianpeng Chao <chaopeng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550482}
[modify] https://crrev.com/348808c076714a5422e9f6be8aca7e206d4c7464/chrome/browser/chromeos/extensions/active_tab_permission_granter_delegate_chromeos_unittest.cc
[modify] https://crrev.com/348808c076714a5422e9f6be8aca7e206d4c7464/chrome/browser/chromeos/extensions/device_local_account_management_policy_provider_unittest.cc
[modify] https://crrev.com/348808c076714a5422e9f6be8aca7e206d4c7464/chrome/browser/chromeos/extensions/extension_tab_util_delegate_chromeos_unittest.cc
[modify] https://crrev.com/348808c076714a5422e9f6be8aca7e206d4c7464/chrome/browser/chromeos/extensions/permissions_updater_delegate_chromeos_unittest.cc
[modify] https://crrev.com/348808c076714a5422e9f6be8aca7e206d4c7464/chrome/browser/chromeos/file_system_provider/service_unittest.cc
[modify] https://crrev.com/348808c076714a5422e9f6be8aca7e206d4c7464/chrome/browser/chromeos/policy/device_local_account_browsertest.cc
[modify] https://crrev.com/348808c076714a5422e9f6be8aca7e206d4c7464/chrome/browser/chromeos/ui/idle_app_name_notification_view_unittest.cc
[modify] https://crrev.com/348808c076714a5422e9f6be8aca7e206d4c7464/chrome/browser/download/download_browsertest.cc
[modify] https://crrev.com/348808c076714a5422e9f6be8aca7e206d4c7464/chrome/browser/extensions/component_loader_unittest.cc
[modify] https://crrev.com/348808c076714a5422e9f6be8aca7e206d4c7464/chrome/browser/extensions/extension_browsertest.cc
[modify] https://crrev.com/348808c076714a5422e9f6be8aca7e206d4c7464/chrome/browser/extensions/extension_garbage_collector_chromeos_unittest.cc
[modify] https://crrev.com/348808c076714a5422e9f6be8aca7e206d4c7464/chrome/browser/extensions/extension_service_test_base.cc
[modify] https://crrev.com/348808c076714a5422e9f6be8aca7e206d4c7464/chrome/browser/extensions/extension_service_test_base.h
[modify] https://crrev.com/348808c076714a5422e9f6be8aca7e206d4c7464/chrome/browser/extensions/startup_helper_browsertest.cc
[modify] https://crrev.com/348808c076714a5422e9f6be8aca7e206d4c7464/chrome/browser/policy/policy_browsertest.cc
[modify] https://crrev.com/348808c076714a5422e9f6be8aca7e206d4c7464/chrome/browser/ui/app_list/search/launcher_search/launcher_search_icon_image_loader_unittest.cc
[modify] https://crrev.com/348808c076714a5422e9f6be8aca7e206d4c7464/chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc
[modify] https://crrev.com/348808c076714a5422e9f6be8aca7e206d4c7464/chrome/browser/ui/webui/extensions/extension_settings_browsertest.cc
[modify] https://crrev.com/348808c076714a5422e9f6be8aca7e206d4c7464/chrome/browser/ui/webui/extensions/extension_settings_browsertest.h
[modify] https://crrev.com/348808c076714a5422e9f6be8aca7e206d4c7464/chrome/common/extensions/manifest_tests/extension_manifests_manifest_version_unittest.cc
[modify] https://crrev.com/348808c076714a5422e9f6be8aca7e206d4c7464/extensions/browser/sandboxed_unpacker_unittest.cc
[modify] https://crrev.com/348808c076714a5422e9f6be8aca7e206d4c7464/extensions/common/BUILD.gn
[modify] https://crrev.com/348808c076714a5422e9f6be8aca7e206d4c7464/extensions/common/extension.cc
[modify] https://crrev.com/348808c076714a5422e9f6be8aca7e206d4c7464/extensions/common/extension.h
[delete] https://crrev.com/0fe1d4fc31ce423c8caacd4a86dadee389474b37/extensions/common/extension_unittest.cc

Project Member

Comment 3 by bugdroid1@chromium.org, Apr 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c8dd19a1f8cdeb6a1b679c206d152fac1b05cf1d

commit c8dd19a1f8cdeb6a1b679c206d152fac1b05cf1d
Author: Devlin Cronin <rdevlin.cronin@chromium.org>
Date: Fri Apr 13 16:10:09 2018

[Reland][Extensions] Stop loading manifest v1 extensions

Manifest v1 extensions have been deprecated for a long time.
Stop loading these extensions unless a special (existing) commandline
flag is present. There are a few straggling tests (which rely on
packaged extension resources, like .crx files) that still need to be
updated; use the commandline flag (or a runtime variant) in those tests.
These will be cleaned up in follow-up CLs.

Reland note: This was reverted because of a conflict with
https://crrev.com/fef93a84a5b56945d02cada97f4ec886ae34c0e2. This has
been fixed.

TBRing original reviewers:
TBR=lazyboy@chromium.org
TBR=pastarmovj@chromium.org
TBR=qinmin@chromium.org
TBR=stevenjb@chromium.org

Bug:  831909 
Change-Id: I9141db4a15452c9cd601b279f7880e10a08c0a8c
Reviewed-on: https://chromium-review.googlesource.com/1011572
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550632}
[modify] https://crrev.com/c8dd19a1f8cdeb6a1b679c206d152fac1b05cf1d/chrome/browser/chromeos/extensions/active_tab_permission_granter_delegate_chromeos_unittest.cc
[modify] https://crrev.com/c8dd19a1f8cdeb6a1b679c206d152fac1b05cf1d/chrome/browser/chromeos/extensions/device_local_account_management_policy_provider_unittest.cc
[modify] https://crrev.com/c8dd19a1f8cdeb6a1b679c206d152fac1b05cf1d/chrome/browser/chromeos/extensions/extension_tab_util_delegate_chromeos_unittest.cc
[modify] https://crrev.com/c8dd19a1f8cdeb6a1b679c206d152fac1b05cf1d/chrome/browser/chromeos/extensions/permissions_updater_delegate_chromeos_unittest.cc
[modify] https://crrev.com/c8dd19a1f8cdeb6a1b679c206d152fac1b05cf1d/chrome/browser/chromeos/file_system_provider/service_unittest.cc
[modify] https://crrev.com/c8dd19a1f8cdeb6a1b679c206d152fac1b05cf1d/chrome/browser/chromeos/policy/device_local_account_browsertest.cc
[modify] https://crrev.com/c8dd19a1f8cdeb6a1b679c206d152fac1b05cf1d/chrome/browser/chromeos/ui/idle_app_name_notification_view_unittest.cc
[modify] https://crrev.com/c8dd19a1f8cdeb6a1b679c206d152fac1b05cf1d/chrome/browser/download/download_browsertest.cc
[modify] https://crrev.com/c8dd19a1f8cdeb6a1b679c206d152fac1b05cf1d/chrome/browser/extensions/component_loader_unittest.cc
[modify] https://crrev.com/c8dd19a1f8cdeb6a1b679c206d152fac1b05cf1d/chrome/browser/extensions/extension_browsertest.cc
[modify] https://crrev.com/c8dd19a1f8cdeb6a1b679c206d152fac1b05cf1d/chrome/browser/extensions/extension_garbage_collector_chromeos_unittest.cc
[modify] https://crrev.com/c8dd19a1f8cdeb6a1b679c206d152fac1b05cf1d/chrome/browser/extensions/extension_service_test_base.cc
[modify] https://crrev.com/c8dd19a1f8cdeb6a1b679c206d152fac1b05cf1d/chrome/browser/extensions/extension_service_test_base.h
[modify] https://crrev.com/c8dd19a1f8cdeb6a1b679c206d152fac1b05cf1d/chrome/browser/extensions/startup_helper_browsertest.cc
[modify] https://crrev.com/c8dd19a1f8cdeb6a1b679c206d152fac1b05cf1d/chrome/browser/policy/policy_browsertest.cc
[modify] https://crrev.com/c8dd19a1f8cdeb6a1b679c206d152fac1b05cf1d/chrome/browser/ui/app_list/search/launcher_search/launcher_search_icon_image_loader_unittest.cc
[modify] https://crrev.com/c8dd19a1f8cdeb6a1b679c206d152fac1b05cf1d/chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc
[modify] https://crrev.com/c8dd19a1f8cdeb6a1b679c206d152fac1b05cf1d/chrome/browser/ui/webui/extensions/extension_settings_browsertest.cc
[modify] https://crrev.com/c8dd19a1f8cdeb6a1b679c206d152fac1b05cf1d/chrome/browser/ui/webui/extensions/extension_settings_browsertest.h
[modify] https://crrev.com/c8dd19a1f8cdeb6a1b679c206d152fac1b05cf1d/chrome/common/extensions/manifest_tests/extension_manifests_manifest_version_unittest.cc
[modify] https://crrev.com/c8dd19a1f8cdeb6a1b679c206d152fac1b05cf1d/extensions/browser/sandboxed_unpacker_unittest.cc
[modify] https://crrev.com/c8dd19a1f8cdeb6a1b679c206d152fac1b05cf1d/extensions/common/BUILD.gn
[modify] https://crrev.com/c8dd19a1f8cdeb6a1b679c206d152fac1b05cf1d/extensions/common/extension.cc
[modify] https://crrev.com/c8dd19a1f8cdeb6a1b679c206d152fac1b05cf1d/extensions/common/extension.h
[add] https://crrev.com/c8dd19a1f8cdeb6a1b679c206d152fac1b05cf1d/extensions/common/extension_unittest.cc

Comment 4 by rdevlin....@chromium.org, Apr 13 2018

Labels: Merge-Request-67
Status: Fixed (was: Started)

This should be fixed with #3.

Requesting merge, as we'd like this for M67.  The original patch made the branch cut, but was reverted for a compile conflict with revision fef93a84a5b56945d02cada97f4ec886ae34c0e2 (which has since been resolved).

Project Member

Comment 5 by sheriffbot@chromium.org, Apr 14 2018

Labels: -Merge-Request-67 Merge-Review-67 Hotlist-Merge-Review

This bug requires manual review: Reverts referenced in bugdroid comments after merge request.
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 6 by gov...@chromium.org, Apr 15 2018

How is the change listed at #3 looking in canary? Seems like a big patch, is it safe and critical to merge to M67?

Comment 7 by rdevlin....@chromium.org, Apr 16 2018

Cc: gov...@chromium.org

@6 It seems to look good in Canary so far - no reports of crashes.  The patch looks large, but isn't that big - particularly in terms of production code (the vast majority is test-only).  It is desirable to merge back to 67, particularly given how early we are in the cycle (and that it originally made branch cut before being reverted for a collision).

Comment 8 by gov...@chromium.org, Apr 16 2018

Labels: -Merge-Review-67 Merge-Approved-67

Approving merge to M67 branch 3396 for cl listed at #3 per comment #7. Please merge ASAP. Thank you.

Comment 9 by rdevlin....@chromium.org, Apr 16 2018

Labels: -Hotlist-Merge-Review -Merge-Approved-67

Turns out this merge isn't required.

Original patch landed in revision 550426.
M67 branched at revision 550428.
The patch was reverted in revision 550482.

So, the patch is already in M67.  Removing merge labels.

Project Member

Comment 10 by bugdroid1@chromium.org, Apr 17 2018

Labels: merge-merged-testbranch

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6c5c219bd2ad58651dcb596b1211ce948d67a53a

commit 6c5c219bd2ad58651dcb596b1211ce948d67a53a
Author: Devlin Cronin <rdevlin.cronin@chromium.org>
Date: Fri Apr 13 00:09:19 2018

[Extensions] Stop loading manifest v1 extensions

Manifest v1 extensions have been deprecated for a long time.
Stop loading these extensions unless a special (existing) commandline
flag is present. There are a few straggling tests (which rely on
packaged extension resources, like .crx files) that still need to be
updated; use the commandline flag (or a runtime variant) in those tests.
These will be cleaned up in follow-up CLs.

Bug:  831909 
Change-Id: If2323829cd75f826d54a34b713eecf7c28973667
Reviewed-on: https://chromium-review.googlesource.com/1009070
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550426}
[modify] https://crrev.com/6c5c219bd2ad58651dcb596b1211ce948d67a53a/chrome/browser/chromeos/extensions/active_tab_permission_granter_delegate_chromeos_unittest.cc
[modify] https://crrev.com/6c5c219bd2ad58651dcb596b1211ce948d67a53a/chrome/browser/chromeos/extensions/device_local_account_management_policy_provider_unittest.cc
[modify] https://crrev.com/6c5c219bd2ad58651dcb596b1211ce948d67a53a/chrome/browser/chromeos/extensions/extension_tab_util_delegate_chromeos_unittest.cc
[modify] https://crrev.com/6c5c219bd2ad58651dcb596b1211ce948d67a53a/chrome/browser/chromeos/extensions/permissions_updater_delegate_chromeos_unittest.cc
[modify] https://crrev.com/6c5c219bd2ad58651dcb596b1211ce948d67a53a/chrome/browser/chromeos/file_system_provider/service_unittest.cc
[modify] https://crrev.com/6c5c219bd2ad58651dcb596b1211ce948d67a53a/chrome/browser/chromeos/policy/device_local_account_browsertest.cc
[modify] https://crrev.com/6c5c219bd2ad58651dcb596b1211ce948d67a53a/chrome/browser/chromeos/ui/idle_app_name_notification_view_unittest.cc
[modify] https://crrev.com/6c5c219bd2ad58651dcb596b1211ce948d67a53a/chrome/browser/download/download_browsertest.cc
[modify] https://crrev.com/6c5c219bd2ad58651dcb596b1211ce948d67a53a/chrome/browser/extensions/component_loader_unittest.cc
[modify] https://crrev.com/6c5c219bd2ad58651dcb596b1211ce948d67a53a/chrome/browser/extensions/extension_browsertest.cc
[modify] https://crrev.com/6c5c219bd2ad58651dcb596b1211ce948d67a53a/chrome/browser/extensions/extension_garbage_collector_chromeos_unittest.cc
[modify] https://crrev.com/6c5c219bd2ad58651dcb596b1211ce948d67a53a/chrome/browser/extensions/extension_service_test_base.cc
[modify] https://crrev.com/6c5c219bd2ad58651dcb596b1211ce948d67a53a/chrome/browser/extensions/extension_service_test_base.h
[modify] https://crrev.com/6c5c219bd2ad58651dcb596b1211ce948d67a53a/chrome/browser/extensions/startup_helper_browsertest.cc
[modify] https://crrev.com/6c5c219bd2ad58651dcb596b1211ce948d67a53a/chrome/browser/policy/policy_browsertest.cc
[modify] https://crrev.com/6c5c219bd2ad58651dcb596b1211ce948d67a53a/chrome/browser/ui/app_list/search/launcher_search/launcher_search_icon_image_loader_unittest.cc
[modify] https://crrev.com/6c5c219bd2ad58651dcb596b1211ce948d67a53a/chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc
[modify] https://crrev.com/6c5c219bd2ad58651dcb596b1211ce948d67a53a/chrome/browser/ui/webui/extensions/extension_settings_browsertest.cc
[modify] https://crrev.com/6c5c219bd2ad58651dcb596b1211ce948d67a53a/chrome/browser/ui/webui/extensions/extension_settings_browsertest.h
[modify] https://crrev.com/6c5c219bd2ad58651dcb596b1211ce948d67a53a/chrome/common/extensions/manifest_tests/extension_manifests_manifest_version_unittest.cc
[modify] https://crrev.com/6c5c219bd2ad58651dcb596b1211ce948d67a53a/extensions/browser/sandboxed_unpacker_unittest.cc
[modify] https://crrev.com/6c5c219bd2ad58651dcb596b1211ce948d67a53a/extensions/common/BUILD.gn
[modify] https://crrev.com/6c5c219bd2ad58651dcb596b1211ce948d67a53a/extensions/common/extension.cc
[modify] https://crrev.com/6c5c219bd2ad58651dcb596b1211ce948d67a53a/extensions/common/extension.h
[add] https://crrev.com/6c5c219bd2ad58651dcb596b1211ce948d67a53a/extensions/common/extension_unittest.cc

Project Member

Comment 11 by bugdroid1@chromium.org, Apr 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/348808c076714a5422e9f6be8aca7e206d4c7464

commit 348808c076714a5422e9f6be8aca7e206d4c7464
Author: Jianpeng Chao <chaopeng@chromium.org>
Date: Fri Apr 13 03:11:24 2018

Revert "[Extensions] Stop loading manifest v1 extensions"

This reverts commit 6c5c219bd2ad58651dcb596b1211ce948d67a53a.

Reason for revert: buildbot failed

Original change's description:
> [Extensions] Stop loading manifest v1 extensions
> 
> Manifest v1 extensions have been deprecated for a long time.
> Stop loading these extensions unless a special (existing) commandline
> flag is present. There are a few straggling tests (which rely on
> packaged extension resources, like .crx files) that still need to be
> updated; use the commandline flag (or a runtime variant) in those tests.
> These will be cleaned up in follow-up CLs.
> 
> Bug:  831909 
> Change-Id: If2323829cd75f826d54a34b713eecf7c28973667
> Reviewed-on: https://chromium-review.googlesource.com/1009070
> Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
> Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
> Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
> Reviewed-by: Min Qin <qinmin@chromium.org>
> Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#550426}

TBR=stevenjb@chromium.org,pastarmovj@chromium.org,lazyboy@chromium.org,rdevlin.cronin@chromium.org,qinmin@chromium.org

Change-Id: I5a0a4c7f90421d139dce7cdc27d1affa2059c5a4
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  831909 ,  832488 
Reviewed-on: https://chromium-review.googlesource.com/1011710
Reviewed-by: Jianpeng Chao <chaopeng@chromium.org>
Commit-Queue: Jianpeng Chao <chaopeng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550482}
[modify] https://crrev.com/348808c076714a5422e9f6be8aca7e206d4c7464/chrome/browser/chromeos/extensions/active_tab_permission_granter_delegate_chromeos_unittest.cc
[modify] https://crrev.com/348808c076714a5422e9f6be8aca7e206d4c7464/chrome/browser/chromeos/extensions/device_local_account_management_policy_provider_unittest.cc
[modify] https://crrev.com/348808c076714a5422e9f6be8aca7e206d4c7464/chrome/browser/chromeos/extensions/extension_tab_util_delegate_chromeos_unittest.cc
[modify] https://crrev.com/348808c076714a5422e9f6be8aca7e206d4c7464/chrome/browser/chromeos/extensions/permissions_updater_delegate_chromeos_unittest.cc
[modify] https://crrev.com/348808c076714a5422e9f6be8aca7e206d4c7464/chrome/browser/chromeos/file_system_provider/service_unittest.cc
[modify] https://crrev.com/348808c076714a5422e9f6be8aca7e206d4c7464/chrome/browser/chromeos/policy/device_local_account_browsertest.cc
[modify] https://crrev.com/348808c076714a5422e9f6be8aca7e206d4c7464/chrome/browser/chromeos/ui/idle_app_name_notification_view_unittest.cc
[modify] https://crrev.com/348808c076714a5422e9f6be8aca7e206d4c7464/chrome/browser/download/download_browsertest.cc
[modify] https://crrev.com/348808c076714a5422e9f6be8aca7e206d4c7464/chrome/browser/extensions/component_loader_unittest.cc
[modify] https://crrev.com/348808c076714a5422e9f6be8aca7e206d4c7464/chrome/browser/extensions/extension_browsertest.cc
[modify] https://crrev.com/348808c076714a5422e9f6be8aca7e206d4c7464/chrome/browser/extensions/extension_garbage_collector_chromeos_unittest.cc
[modify] https://crrev.com/348808c076714a5422e9f6be8aca7e206d4c7464/chrome/browser/extensions/extension_service_test_base.cc
[modify] https://crrev.com/348808c076714a5422e9f6be8aca7e206d4c7464/chrome/browser/extensions/extension_service_test_base.h
[modify] https://crrev.com/348808c076714a5422e9f6be8aca7e206d4c7464/chrome/browser/extensions/startup_helper_browsertest.cc
[modify] https://crrev.com/348808c076714a5422e9f6be8aca7e206d4c7464/chrome/browser/policy/policy_browsertest.cc
[modify] https://crrev.com/348808c076714a5422e9f6be8aca7e206d4c7464/chrome/browser/ui/app_list/search/launcher_search/launcher_search_icon_image_loader_unittest.cc
[modify] https://crrev.com/348808c076714a5422e9f6be8aca7e206d4c7464/chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc
[modify] https://crrev.com/348808c076714a5422e9f6be8aca7e206d4c7464/chrome/browser/ui/webui/extensions/extension_settings_browsertest.cc
[modify] https://crrev.com/348808c076714a5422e9f6be8aca7e206d4c7464/chrome/browser/ui/webui/extensions/extension_settings_browsertest.h
[modify] https://crrev.com/348808c076714a5422e9f6be8aca7e206d4c7464/chrome/common/extensions/manifest_tests/extension_manifests_manifest_version_unittest.cc
[modify] https://crrev.com/348808c076714a5422e9f6be8aca7e206d4c7464/extensions/browser/sandboxed_unpacker_unittest.cc
[modify] https://crrev.com/348808c076714a5422e9f6be8aca7e206d4c7464/extensions/common/BUILD.gn
[modify] https://crrev.com/348808c076714a5422e9f6be8aca7e206d4c7464/extensions/common/extension.cc
[modify] https://crrev.com/348808c076714a5422e9f6be8aca7e206d4c7464/extensions/common/extension.h
[delete] https://crrev.com/0fe1d4fc31ce423c8caacd4a86dadee389474b37/extensions/common/extension_unittest.cc

Project Member

Comment 12 by bugdroid1@chromium.org, Apr 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c8dd19a1f8cdeb6a1b679c206d152fac1b05cf1d

commit c8dd19a1f8cdeb6a1b679c206d152fac1b05cf1d
Author: Devlin Cronin <rdevlin.cronin@chromium.org>
Date: Fri Apr 13 16:10:09 2018

[Reland][Extensions] Stop loading manifest v1 extensions

Manifest v1 extensions have been deprecated for a long time.
Stop loading these extensions unless a special (existing) commandline
flag is present. There are a few straggling tests (which rely on
packaged extension resources, like .crx files) that still need to be
updated; use the commandline flag (or a runtime variant) in those tests.
These will be cleaned up in follow-up CLs.

Reland note: This was reverted because of a conflict with
https://crrev.com/fef93a84a5b56945d02cada97f4ec886ae34c0e2. This has
been fixed.

TBRing original reviewers:
TBR=lazyboy@chromium.org
TBR=pastarmovj@chromium.org
TBR=qinmin@chromium.org
TBR=stevenjb@chromium.org

Bug:  831909 
Change-Id: I9141db4a15452c9cd601b279f7880e10a08c0a8c
Reviewed-on: https://chromium-review.googlesource.com/1011572
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550632}
[modify] https://crrev.com/c8dd19a1f8cdeb6a1b679c206d152fac1b05cf1d/chrome/browser/chromeos/extensions/active_tab_permission_granter_delegate_chromeos_unittest.cc
[modify] https://crrev.com/c8dd19a1f8cdeb6a1b679c206d152fac1b05cf1d/chrome/browser/chromeos/extensions/device_local_account_management_policy_provider_unittest.cc
[modify] https://crrev.com/c8dd19a1f8cdeb6a1b679c206d152fac1b05cf1d/chrome/browser/chromeos/extensions/extension_tab_util_delegate_chromeos_unittest.cc
[modify] https://crrev.com/c8dd19a1f8cdeb6a1b679c206d152fac1b05cf1d/chrome/browser/chromeos/extensions/permissions_updater_delegate_chromeos_unittest.cc
[modify] https://crrev.com/c8dd19a1f8cdeb6a1b679c206d152fac1b05cf1d/chrome/browser/chromeos/file_system_provider/service_unittest.cc
[modify] https://crrev.com/c8dd19a1f8cdeb6a1b679c206d152fac1b05cf1d/chrome/browser/chromeos/policy/device_local_account_browsertest.cc
[modify] https://crrev.com/c8dd19a1f8cdeb6a1b679c206d152fac1b05cf1d/chrome/browser/chromeos/ui/idle_app_name_notification_view_unittest.cc
[modify] https://crrev.com/c8dd19a1f8cdeb6a1b679c206d152fac1b05cf1d/chrome/browser/download/download_browsertest.cc
[modify] https://crrev.com/c8dd19a1f8cdeb6a1b679c206d152fac1b05cf1d/chrome/browser/extensions/component_loader_unittest.cc
[modify] https://crrev.com/c8dd19a1f8cdeb6a1b679c206d152fac1b05cf1d/chrome/browser/extensions/extension_browsertest.cc
[modify] https://crrev.com/c8dd19a1f8cdeb6a1b679c206d152fac1b05cf1d/chrome/browser/extensions/extension_garbage_collector_chromeos_unittest.cc
[modify] https://crrev.com/c8dd19a1f8cdeb6a1b679c206d152fac1b05cf1d/chrome/browser/extensions/extension_service_test_base.cc
[modify] https://crrev.com/c8dd19a1f8cdeb6a1b679c206d152fac1b05cf1d/chrome/browser/extensions/extension_service_test_base.h
[modify] https://crrev.com/c8dd19a1f8cdeb6a1b679c206d152fac1b05cf1d/chrome/browser/extensions/startup_helper_browsertest.cc
[modify] https://crrev.com/c8dd19a1f8cdeb6a1b679c206d152fac1b05cf1d/chrome/browser/policy/policy_browsertest.cc
[modify] https://crrev.com/c8dd19a1f8cdeb6a1b679c206d152fac1b05cf1d/chrome/browser/ui/app_list/search/launcher_search/launcher_search_icon_image_loader_unittest.cc
[modify] https://crrev.com/c8dd19a1f8cdeb6a1b679c206d152fac1b05cf1d/chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc
[modify] https://crrev.com/c8dd19a1f8cdeb6a1b679c206d152fac1b05cf1d/chrome/browser/ui/webui/extensions/extension_settings_browsertest.cc
[modify] https://crrev.com/c8dd19a1f8cdeb6a1b679c206d152fac1b05cf1d/chrome/browser/ui/webui/extensions/extension_settings_browsertest.h
[modify] https://crrev.com/c8dd19a1f8cdeb6a1b679c206d152fac1b05cf1d/chrome/common/extensions/manifest_tests/extension_manifests_manifest_version_unittest.cc
[modify] https://crrev.com/c8dd19a1f8cdeb6a1b679c206d152fac1b05cf1d/extensions/browser/sandboxed_unpacker_unittest.cc
[modify] https://crrev.com/c8dd19a1f8cdeb6a1b679c206d152fac1b05cf1d/extensions/common/BUILD.gn
[modify] https://crrev.com/c8dd19a1f8cdeb6a1b679c206d152fac1b05cf1d/extensions/common/extension.cc
[modify] https://crrev.com/c8dd19a1f8cdeb6a1b679c206d152fac1b05cf1d/extensions/common/extension.h
[add] https://crrev.com/c8dd19a1f8cdeb6a1b679c206d152fac1b05cf1d/extensions/common/extension_unittest.cc

►

Issue 831909 link

Issue metadata

Stop loading manifest v1 extensions

Issue description

Comment 1 by bugdroid1@chromium.org, Apr 13 2018

Comment 1 Deleted

Comment 2 by bugdroid1@chromium.org, Apr 13 2018

Comment 2 Deleted

Comment 3 by bugdroid1@chromium.org, Apr 13 2018

Comment 3 Deleted

Comment 4 by rdevlin....@chromium.org, Apr 13 2018

Comment 4 Deleted

Comment 5 by sheriffbot@chromium.org, Apr 14 2018

Comment 5 Deleted

Comment 6 by gov...@chromium.org, Apr 15 2018

Comment 6 Deleted

Comment 7 by rdevlin....@chromium.org, Apr 16 2018

Comment 7 Deleted

Comment 8 by gov...@chromium.org, Apr 16 2018

Comment 8 Deleted

Comment 9 by rdevlin....@chromium.org, Apr 16 2018

Comment 9 Deleted

Comment 10 by bugdroid1@chromium.org, Apr 17 2018

Comment 10 Deleted

Comment 11 by bugdroid1@chromium.org, Apr 17 2018

Comment 11 Deleted

Comment 12 by bugdroid1@chromium.org, Apr 17 2018

Comment 12 Deleted

Sign in to add a comment