New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 831902 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Long OOO (go/where-is-mgiuca)
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

AppMenuButton: Lifetime of AppMenu and AppMenuModel is error prone (refactor)

Project Member Reported by mgiuca@chromium.org, Apr 12 2018

Issue description

In the AppMenuButton class, there is an AppMenu and AppMenuModel member, which have complicated lifetime requirements (the AppMenu contains a raw pointer to the AppMenuModel owned by the AppMenuButton, which means the AppMenu must be destroyed first).

This has caused accidents in the past (Issue 831504). We should make the lifetime less complicated so such accidents can't happen.
 

Sign in to add a comment