New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 831880 link

Starred by 1 user
Status: Fixed
Owner:
█ robert...@chromium.org
Last visit > 30 days ago
Closed: May 2018
Cc:
█ robert...@chromium.org
chanli@chromium.org
lijeffrey@chromium.org
liaoyuke@chromium.org
st...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

[cr-audit-commits] Support auto-revert for flake.

Project Member Reported by robert...@chromium.org, Apr 11 2018 
The rules remain unchanged except for the two following differences
 - The culprit may not be contained in the referenced failed build
 - The prefix for the flaky step is "Flaky step name:"
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 13 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/e54613030d26eacf2284295fbbe35a7e755f7ad9

commit e54613030d26eacf2284295fbbe35a7e755f7ad9
Author: Roberto Carrillo <robertocn@google.com>
Date: Fri Apr 13 20:10:34 2018

[cr-audit-commits] Support auditing Findit auto-reverts for flake.

This change bypasses one of the rules because the build with the first
failure of the affected test may not contain the culprit of the
flakiness, as it may be older than those in the build.

This change relies on the prefix "Flaky test name: " used by Findit to
indicate the name of the test that is flaky, being present in the commit
message of such auto-reverts to determine if they are meant to address a
flake and thus bypass this rule.

R=wylieb,chanli,stgao,lijeffrey
BUG= 831880 

Change-Id: I1a3f3964d5fc5fb302935798b95967b134ba7891
Reviewed-on: https://chromium-review.googlesource.com/1008983
Reviewed-by: Shuotao Gao <stgao@chromium.org>
Reviewed-by: Brandon Wylie <wylieb@chromium.org>
Reviewed-by: Chan Li <chanli@chromium.org>
Commit-Queue: Roberto Carrillo <robertocn@chromium.org>

[modify] https://crrev.com/e54613030d26eacf2284295fbbe35a7e755f7ad9/go/src/infra/appengine/cr-audit-commits/app/findit_rules_test.go
[modify] https://crrev.com/e54613030d26eacf2284295fbbe35a7e755f7ad9/go/src/infra/appengine/cr-audit-commits/app/utils.go
[modify] https://crrev.com/e54613030d26eacf2284295fbbe35a7e755f7ad9/go/src/infra/appengine/cr-audit-commits/app/findit_rules.go

Comment 2 by robert...@chromium.org, Apr 14 2018

Components: Infra>Audit

Comment 3 by robert...@chromium.org, May 3 2018

Status: Fixed (was: Started)
►

Sign in to add a comment