New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 831878 link

Starred by 1 user
Status: Assigned
Owner:
█ tiansong@chromium.org
User never visited
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[Web BT] Can't subscribe to notifications to a characteristic without a CCCD

Project Member Reported by bcf@chromium.org, Apr 11 2018 
Some non-standards complaint devices may not have a CCCD.

Comment 1 by bcf@chromium.org, Apr 11 2018

Components: Blink>Bluetooth
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 14 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1bc120e7343390962139635e27d4720866ecf6c4

commit 1bc120e7343390962139635e27d4720866ecf6c4
Author: Bailey Forrest <bcf@chromium.org>
Date: Sat Apr 14 02:33:33 2018

[chromecast] Create fake CCCD when it's supposed to exist

This is necessary for Web Bluetooth notifications to work on these
non-compliant devices.

BUG=831878
TEST=cast_bluetooth_unittests, manual

Change-Id: I21b83328461311033a34153efee20cf4529eae39
Reviewed-on: https://chromium-review.googlesource.com/1013333
Commit-Queue: Bailey Forrest <bcf@chromium.org>
Reviewed-by: Stephen Lanham <slan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550863}
[modify] https://crrev.com/1bc120e7343390962139635e27d4720866ecf6c4/chromecast/device/bluetooth/le/gatt_client_manager_impl_test.cc
[modify] https://crrev.com/1bc120e7343390962139635e27d4720866ecf6c4/chromecast/device/bluetooth/le/remote_characteristic_impl.cc
[modify] https://crrev.com/1bc120e7343390962139635e27d4720866ecf6c4/chromecast/device/bluetooth/le/remote_characteristic_impl.h
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 17 2018

Labels: merge-merged-testbranch
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1bc120e7343390962139635e27d4720866ecf6c4

commit 1bc120e7343390962139635e27d4720866ecf6c4
Author: Bailey Forrest <bcf@chromium.org>
Date: Sat Apr 14 02:33:33 2018

[chromecast] Create fake CCCD when it's supposed to exist

This is necessary for Web Bluetooth notifications to work on these
non-compliant devices.

BUG=831878
TEST=cast_bluetooth_unittests, manual

Change-Id: I21b83328461311033a34153efee20cf4529eae39
Reviewed-on: https://chromium-review.googlesource.com/1013333
Commit-Queue: Bailey Forrest <bcf@chromium.org>
Reviewed-by: Stephen Lanham <slan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550863}
[modify] https://crrev.com/1bc120e7343390962139635e27d4720866ecf6c4/chromecast/device/bluetooth/le/gatt_client_manager_impl_test.cc
[modify] https://crrev.com/1bc120e7343390962139635e27d4720866ecf6c4/chromecast/device/bluetooth/le/remote_characteristic_impl.cc
[modify] https://crrev.com/1bc120e7343390962139635e27d4720866ecf6c4/chromecast/device/bluetooth/le/remote_characteristic_impl.h

Comment 5 by bcf@chromium.org, Sep 10

Owner: tiansong@chromium.org
►

Sign in to add a comment