New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 831846 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2018
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 838498



Sign in to add a comment

Move zygote code to service_manager

Project Member Reported by jcivelli@chromium.org, Apr 11 2018

Issue description

As part of the effort to move process launching to the service manager, we should move the zygote code to service manager.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b9348579a405305785140d5d946c4b03567e807b

commit b9348579a405305785140d5d946c4b03567e807b
Author: Jay Civelli <jcivelli@google.com>
Date: Thu Apr 12 20:33:45 2018

Move content presandbox init to ContentMainRunner

In preparation for the move of the zygote code from content/ to
services/service_manager, moving the content specific presandbox
initialization code to from zygote_main to ContentMainRunner.

Bug:  831846 
Change-Id: I4c2f160039f21bd1814d1bd9d3fd6664bbb0cf17
Reviewed-on: https://chromium-review.googlesource.com/1008865
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Jay Civelli <jcivelli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550335}
[modify] https://crrev.com/b9348579a405305785140d5d946c4b03567e807b/content/app/content_main_runner.cc
[modify] https://crrev.com/b9348579a405305785140d5d946c4b03567e807b/content/zygote/zygote_main_linux.cc

Project Member

Comment 2 by bugdroid1@chromium.org, Apr 17 2018

Labels: merge-merged-testbranch
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b9348579a405305785140d5d946c4b03567e807b

commit b9348579a405305785140d5d946c4b03567e807b
Author: Jay Civelli <jcivelli@google.com>
Date: Thu Apr 12 20:33:45 2018

Move content presandbox init to ContentMainRunner

In preparation for the move of the zygote code from content/ to
services/service_manager, moving the content specific presandbox
initialization code to from zygote_main to ContentMainRunner.

Bug:  831846 
Change-Id: I4c2f160039f21bd1814d1bd9d3fd6664bbb0cf17
Reviewed-on: https://chromium-review.googlesource.com/1008865
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Jay Civelli <jcivelli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550335}
[modify] https://crrev.com/b9348579a405305785140d5d946c4b03567e807b/content/app/content_main_runner.cc
[modify] https://crrev.com/b9348579a405305785140d5d946c4b03567e807b/content/zygote/zygote_main_linux.cc

Project Member

Comment 3 by bugdroid1@chromium.org, Apr 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3ae893eff562f0e1a44bff3c61da86098881a268

commit 3ae893eff562f0e1a44bff3c61da86098881a268
Author: Jay Civelli <jcivelli@google.com>
Date: Tue Apr 17 20:07:05 2018

Dedupe the sandbox related switches

Makes services/service_manager/sandbox/switches.h the only place for
sandbox related switches, removing the dupped ones in content and
changing all call sites.

Tbr: bradnelson@chromium.org
Bug:  831846 
Change-Id: I08928c664e0e2340ac5168d6fd94a07bbeb81266
Reviewed-on: https://chromium-review.googlesource.com/1012986
Commit-Queue: Jay Civelli <jcivelli@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551448}
[modify] https://crrev.com/3ae893eff562f0e1a44bff3c61da86098881a268/apps/DEPS
[modify] https://crrev.com/3ae893eff562f0e1a44bff3c61da86098881a268/apps/load_and_launch_browsertest.cc
[modify] https://crrev.com/3ae893eff562f0e1a44bff3c61da86098881a268/chrome/BUILD.gn
[modify] https://crrev.com/3ae893eff562f0e1a44bff3c61da86098881a268/chrome/app/main_dll_loader_win.cc
[modify] https://crrev.com/3ae893eff562f0e1a44bff3c61da86098881a268/chrome/browser/chromeos/login/chrome_restart_request.cc
[modify] https://crrev.com/3ae893eff562f0e1a44bff3c61da86098881a268/chrome/browser/infobars/infobars_browsertest.cc
[modify] https://crrev.com/3ae893eff562f0e1a44bff3c61da86098881a268/chrome/browser/ui/startup/bad_flags_prompt.cc
[modify] https://crrev.com/3ae893eff562f0e1a44bff3c61da86098881a268/chrome/browser/ui/views/chrome_browser_main_extra_parts_views.cc
[modify] https://crrev.com/3ae893eff562f0e1a44bff3c61da86098881a268/chrome/service/service_utility_process_host.cc
[modify] https://crrev.com/3ae893eff562f0e1a44bff3c61da86098881a268/chrome/test/nacl/nacl_browsertest.cc
[modify] https://crrev.com/3ae893eff562f0e1a44bff3c61da86098881a268/components/nacl/browser/DEPS
[modify] https://crrev.com/3ae893eff562f0e1a44bff3c61da86098881a268/components/nacl/browser/nacl_process_host.cc
[modify] https://crrev.com/3ae893eff562f0e1a44bff3c61da86098881a268/components/nacl/common/nacl_cmd_line.cc
[modify] https://crrev.com/3ae893eff562f0e1a44bff3c61da86098881a268/components/nacl/loader/nacl_main.cc
[modify] https://crrev.com/3ae893eff562f0e1a44bff3c61da86098881a268/components/nacl/zygote/nacl_fork_delegate_linux.cc
[modify] https://crrev.com/3ae893eff562f0e1a44bff3c61da86098881a268/content/DEPS
[modify] https://crrev.com/3ae893eff562f0e1a44bff3c61da86098881a268/content/app/content_main_runner.cc
[modify] https://crrev.com/3ae893eff562f0e1a44bff3c61da86098881a268/content/browser/child_process_launcher_helper_android.cc
[modify] https://crrev.com/3ae893eff562f0e1a44bff3c61da86098881a268/content/browser/child_process_launcher_helper_mac.cc
[modify] https://crrev.com/3ae893eff562f0e1a44bff3c61da86098881a268/content/browser/gpu/gpu_process_host.cc
[modify] https://crrev.com/3ae893eff562f0e1a44bff3c61da86098881a268/content/browser/linux_ipc_browsertest.cc
[modify] https://crrev.com/3ae893eff562f0e1a44bff3c61da86098881a268/content/browser/ppapi_plugin_process_host.cc
[modify] https://crrev.com/3ae893eff562f0e1a44bff3c61da86098881a268/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/3ae893eff562f0e1a44bff3c61da86098881a268/content/browser/sandbox_parameters_mac.mm
[modify] https://crrev.com/3ae893eff562f0e1a44bff3c61da86098881a268/content/browser/utility_process_host.cc
[modify] https://crrev.com/3ae893eff562f0e1a44bff3c61da86098881a268/content/browser/zygote_host/zygote_host_impl_linux.cc
[modify] https://crrev.com/3ae893eff562f0e1a44bff3c61da86098881a268/content/common/sandbox_policy_fuchsia.cc
[modify] https://crrev.com/3ae893eff562f0e1a44bff3c61da86098881a268/content/public/common/content_switches.cc
[modify] https://crrev.com/3ae893eff562f0e1a44bff3c61da86098881a268/content/public/common/content_switches.h
[modify] https://crrev.com/3ae893eff562f0e1a44bff3c61da86098881a268/content/renderer/renderer_main.cc
[modify] https://crrev.com/3ae893eff562f0e1a44bff3c61da86098881a268/content/renderer/renderer_main_platform_delegate_win.cc
[modify] https://crrev.com/3ae893eff562f0e1a44bff3c61da86098881a268/content/test/content_browser_test_test.cc
[modify] https://crrev.com/3ae893eff562f0e1a44bff3c61da86098881a268/content/zygote/zygote_browsertest.cc
[modify] https://crrev.com/3ae893eff562f0e1a44bff3c61da86098881a268/content/zygote/zygote_main_linux.cc
[modify] https://crrev.com/3ae893eff562f0e1a44bff3c61da86098881a268/headless/DEPS
[modify] https://crrev.com/3ae893eff562f0e1a44bff3c61da86098881a268/headless/lib/headless_content_main_delegate.cc
[modify] https://crrev.com/3ae893eff562f0e1a44bff3c61da86098881a268/services/service_manager/sandbox/switches.cc
[modify] https://crrev.com/3ae893eff562f0e1a44bff3c61da86098881a268/services/service_manager/sandbox/switches.h

Project Member

Comment 4 by bugdroid1@chromium.org, Apr 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0

commit dbe3973e8ff5eb249dd35474b69f9316c15ca1f0
Author: Jay Civelli <jcivelli@google.com>
Date: Mon Apr 30 22:28:27 2018

Move zygote code to service_manager

This CL moves the zygote code from content/ to
services/service_manager/zygote. This involves moving some switches from
content_switches.h to services/service_manager/embedder/switches.h and
moving some codes from content/public/common/result_codes.h to the new
services/service_manager/embedder/result_codes.h.

Bug:  831846 
Change-Id: I9776a30412ea43c2c7f511967d2b7d05f18aa841
Reviewed-on: https://chromium-review.googlesource.com/1012194
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Stephen Lanham <slan@chromium.org>
Reviewed-by: Eric Seckler <eseckler@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Jay Civelli <jcivelli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554902}
[modify] https://crrev.com/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0/android_webview/browser/aw_browser_main_parts.cc
[modify] https://crrev.com/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0/apps/DEPS
[modify] https://crrev.com/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0/chrome/DEPS
[modify] https://crrev.com/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0/chrome/android/java/DEPS
[modify] https://crrev.com/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0/chrome/android/javatests/DEPS
[modify] https://crrev.com/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0/chrome/app/DEPS
[modify] https://crrev.com/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0/chrome/app/chrome_crash_reporter_client.cc
[modify] https://crrev.com/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0/chrome/app/chrome_main_delegate.cc
[modify] https://crrev.com/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0/chrome/app/chrome_main_delegate.h
[modify] https://crrev.com/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0/chrome/browser/DEPS
[modify] https://crrev.com/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0/chrome/browser/chrome_browser_main.cc
[modify] https://crrev.com/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0/chrome/browser/chrome_browser_main_posix.cc
[modify] https://crrev.com/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0/chrome/browser/chrome_browser_main_win.cc
[modify] https://crrev.com/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0/chrome/browser/memory_details.cc
[modify] https://crrev.com/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0/chrome/browser/resource_coordinator/tab_manager_delegate_chromeos.cc
[modify] https://crrev.com/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0/chrome/browser/ui/uninstall_browser_prompt.h
[modify] https://crrev.com/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0/chrome/browser/ui/views/uninstall_view.cc
[modify] https://crrev.com/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0/chrome/browser/ui/webui/sandbox_internals_ui.cc
[modify] https://crrev.com/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0/chrome/common/DEPS
[modify] https://crrev.com/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0/chrome/common/thread_profiler.cc
[modify] https://crrev.com/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0/chrome/gpu/DEPS
[modify] https://crrev.com/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0/chrome/installer/setup/uninstall.cc
[modify] https://crrev.com/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0/chrome/renderer/DEPS
[modify] https://crrev.com/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0/chrome/renderer/pepper/pepper_flash_font_file_host.cc
[modify] https://crrev.com/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0/chrome/service/DEPS
[modify] https://crrev.com/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0/chrome/service/service_utility_process_host.cc
[modify] https://crrev.com/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0/chrome/utility/DEPS
[modify] https://crrev.com/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0/chrome/utility/importer/firefox_importer_unittest_utils_mac.cc
[modify] https://crrev.com/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0/chromecast/app/DEPS
[modify] https://crrev.com/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0/chromecast/app/android/DEPS
[modify] https://crrev.com/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0/chromecast/app/android/crash_handler.cc
[modify] https://crrev.com/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0/chromecast/app/cast_main_delegate.cc
[modify] https://crrev.com/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0/chromecast/app/linux/cast_crash_reporter_client.cc
[modify] https://crrev.com/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0/chromecast/browser/DEPS
[modify] https://crrev.com/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0/chromecast/browser/cast_content_browser_client.cc
[modify] https://crrev.com/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0/components/crash/content/app/breakpad_linux.cc
[modify] https://crrev.com/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0/components/crash/content/app/crashpad_linux.cc
[modify] https://crrev.com/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0/components/nacl/DEPS
[modify] https://crrev.com/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0/components/nacl/broker/BUILD.gn
[modify] https://crrev.com/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0/components/nacl/broker/nacl_broker_listener.cc
[modify] https://crrev.com/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0/components/nacl/browser/BUILD.gn
[modify] https://crrev.com/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0/components/nacl/browser/nacl_broker_host_win.cc
[modify] https://crrev.com/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0/components/nacl/browser/nacl_process_host.cc
[modify] https://crrev.com/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0/components/nacl/common/BUILD.gn
[modify] https://crrev.com/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0/components/nacl/common/nacl_service.cc
[modify] https://crrev.com/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0/components/nacl/loader/BUILD.gn
[modify] https://crrev.com/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0/components/nacl/loader/nacl_helper_linux.cc
[modify] https://crrev.com/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0/components/nacl/loader/nacl_listener.cc
[modify] https://crrev.com/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0/components/nacl/loader/nonsfi/nonsfi_listener.cc
[modify] https://crrev.com/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0/components/nacl/zygote/nacl_fork_delegate_linux.cc
[modify] https://crrev.com/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0/components/nacl/zygote/nacl_fork_delegate_linux.h
[modify] https://crrev.com/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0/content/BUILD.gn
[modify] https://crrev.com/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0/content/DEPS
[modify] https://crrev.com/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0/content/app/content_main_runner.cc
[modify] https://crrev.com/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0/content/app/content_service_manager_main_delegate.cc
[modify] https://crrev.com/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0/content/browser/BUILD.gn
[modify] https://crrev.com/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0/content/browser/browser_child_process_host_impl.cc
[modify] https://crrev.com/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0/content/browser/browser_main_loop.cc
[modify] https://crrev.com/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0/content/browser/child_process_launcher.cc
[modify] https://crrev.com/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0/content/browser/child_process_launcher_helper.h
[modify] https://crrev.com/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0/content/browser/child_process_launcher_helper_fuchsia.cc
[modify] https://crrev.com/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0/content/browser/child_process_launcher_helper_linux.cc
[modify] https://crrev.com/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0/content/browser/child_process_launcher_helper_mac.cc
[modify] https://crrev.com/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0/content/browser/child_process_launcher_helper_posix.cc
[modify] https://crrev.com/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0/content/browser/child_process_launcher_helper_win.cc
[modify] https://crrev.com/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0/content/browser/gpu/gpu_process_host.cc
[modify] https://crrev.com/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0/content/browser/ppapi_plugin_process_host.cc
[modify] https://crrev.com/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0/content/browser/renderer_host/pepper/pepper_truetype_font_linux.cc
[modify] https://crrev.com/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0/content/browser/utility_process_host.cc
[modify] https://crrev.com/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0/content/child/BUILD.gn
[modify] https://crrev.com/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0/content/child/child_process_sandbox_support_impl_linux.cc
[modify] https://crrev.com/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0/content/child/child_thread_impl.cc
[modify] https://crrev.com/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0/content/common/BUILD.gn
[modify] https://crrev.com/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0/content/common/common_sandbox_support_linux.cc
[delete] https://crrev.com/92a290bf6ca7efc30ed73fabb7de8f3c24f1c603/content/common/send_zygote_child_ping_linux.cc
[modify] https://crrev.com/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0/content/gpu/BUILD.gn
[modify] https://crrev.com/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0/content/gpu/gpu_main.cc
[modify] https://crrev.com/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0/content/public/android/BUILD.gn
[modify] https://crrev.com/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0/content/public/app/content_main_delegate.cc
[modify] https://crrev.com/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0/content/public/app/content_main_delegate.h
[modify] https://crrev.com/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0/content/public/browser/BUILD.gn
[modify] https://crrev.com/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0/content/public/browser/browser_main_parts.cc
[modify] https://crrev.com/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0/content/public/browser/child_process_termination_info.h
[modify] https://crrev.com/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0/content/public/common/BUILD.gn
[modify] https://crrev.com/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0/content/public/common/common_sandbox_support_linux.h
[modify] https://crrev.com/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0/content/public/common/content_descriptors.h
[modify] https://crrev.com/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0/content/public/common/content_switches.cc
[modify] https://crrev.com/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0/content/public/common/content_switches.h
[delete] https://crrev.com/92a290bf6ca7efc30ed73fabb7de8f3c24f1c603/content/public/common/mojo_channel_switches.cc
[delete] https://crrev.com/92a290bf6ca7efc30ed73fabb7de8f3c24f1c603/content/public/common/mojo_channel_switches.h
[modify] https://crrev.com/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0/content/public/common/result_codes.h
[modify] https://crrev.com/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0/content/public/common/sandboxed_process_launcher_delegate.cc
[modify] https://crrev.com/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0/content/public/common/sandboxed_process_launcher_delegate.h
[delete] https://crrev.com/92a290bf6ca7efc30ed73fabb7de8f3c24f1c603/content/public/common/send_zygote_child_ping_linux.h
[modify] https://crrev.com/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0/content/renderer/BUILD.gn
[modify] https://crrev.com/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0/content/renderer/renderer_main.cc
[modify] https://crrev.com/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0/content/shell/BUILD.gn
[modify] https://crrev.com/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0/content/shell/DEPS
[modify] https://crrev.com/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0/content/shell/app/shell_crash_reporter_client.cc
[modify] https://crrev.com/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0/content/shell/app/shell_main_delegate.cc
[modify] https://crrev.com/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0/content/shell/browser/shell_browser_main_parts.cc
[modify] https://crrev.com/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0/content/shell/browser/shell_content_browser_client.cc
[modify] https://crrev.com/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0/content/zygote/OWNERS
[modify] https://crrev.com/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0/content/zygote/zygote_browsertest.cc
[delete] https://crrev.com/92a290bf6ca7efc30ed73fabb7de8f3c24f1c603/content/zygote/zygote_main.h
[modify] https://crrev.com/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0/extensions/shell/app/DEPS
[modify] https://crrev.com/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0/extensions/shell/app/shell_crash_reporter_client.cc
[modify] https://crrev.com/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0/extensions/shell/app/shell_main_delegate.cc
[modify] https://crrev.com/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0/extensions/shell/app/shell_main_delegate.h
[modify] https://crrev.com/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0/extensions/shell/browser/shell_browser_main_parts.cc
[modify] https://crrev.com/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0/headless/DEPS
[modify] https://crrev.com/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0/headless/lib/browser/headless_content_browser_client.cc
[modify] https://crrev.com/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0/headless/lib/headless_content_main_delegate.cc
[modify] https://crrev.com/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0/headless/lib/headless_crash_reporter_client.cc
[modify] https://crrev.com/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0/services/service_manager/embedder/BUILD.gn
[add] https://crrev.com/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0/services/service_manager/embedder/descriptors.h
[add] https://crrev.com/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0/services/service_manager/embedder/result_codes.h
[modify] https://crrev.com/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0/services/service_manager/embedder/switches.cc
[modify] https://crrev.com/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0/services/service_manager/embedder/switches.h
[add] https://crrev.com/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0/services/service_manager/zygote/BUILD.gn
[add] https://crrev.com/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0/services/service_manager/zygote/DEPS
[add] https://crrev.com/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0/services/service_manager/zygote/OWNERS
[add] https://crrev.com/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0/services/service_manager/zygote/common/common_sandbox_support_linux.cc
[add] https://crrev.com/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0/services/service_manager/zygote/common/common_sandbox_support_linux.h
[add] https://crrev.com/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0/services/service_manager/zygote/common/send_zygote_child_ping_linux.cc
[add] https://crrev.com/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0/services/service_manager/zygote/common/send_zygote_child_ping_linux.h
[rename] https://crrev.com/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0/services/service_manager/zygote/common/zygote_commands_linux.h
[rename] https://crrev.com/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0/services/service_manager/zygote/common/zygote_features.gni
[rename] https://crrev.com/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0/services/service_manager/zygote/common/zygote_fork_delegate_linux.h
[rename] https://crrev.com/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0/services/service_manager/zygote/common/zygote_handle.h
[rename] https://crrev.com/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0/services/service_manager/zygote/host/zygote_communication_linux.cc
[rename] https://crrev.com/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0/services/service_manager/zygote/host/zygote_communication_linux.h
[rename] https://crrev.com/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0/services/service_manager/zygote/host/zygote_handle_linux.cc
[rename] https://crrev.com/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0/services/service_manager/zygote/host/zygote_host_impl_linux.cc
[rename] https://crrev.com/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0/services/service_manager/zygote/host/zygote_host_impl_linux.h
[rename] https://crrev.com/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0/services/service_manager/zygote/zygote_host_linux.h
[rename] https://crrev.com/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0/services/service_manager/zygote/zygote_linux.cc
[rename] https://crrev.com/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0/services/service_manager/zygote/zygote_linux.h
[add] https://crrev.com/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0/services/service_manager/zygote/zygote_main.h
[rename] https://crrev.com/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0/services/service_manager/zygote/zygote_main_linux.cc
[modify] https://crrev.com/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0/tools/ipc_fuzzer/message_replay/DEPS
[modify] https://crrev.com/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0/tools/ipc_fuzzer/message_replay/replay_process.cc
[modify] https://crrev.com/dbe3973e8ff5eb249dd35474b69f9316c15ca1f0/tools/metrics/histograms/enums.xml

Blockedon: 838498
Project Member

Comment 6 by bugdroid1@chromium.org, May 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/35f7133120bbe69c2f68512d3d3d82c6a39ba35e

commit 35f7133120bbe69c2f68512d3d3d82c6a39ba35e
Author: Matt Giuca <mgiuca@chromium.org>
Date: Tue May 01 05:28:23 2018

Revert "Move zygote code to service_manager"

This reverts commit dbe3973e8ff5eb249dd35474b69f9316c15ca1f0.

Reason for revert: Broke compile on LKGR and local builds.
See  https://crbug.com/838498 .

Original change's description:
> Move zygote code to service_manager
> 
> This CL moves the zygote code from content/ to
> services/service_manager/zygote. This involves moving some switches from
> content_switches.h to services/service_manager/embedder/switches.h and
> moving some codes from content/public/common/result_codes.h to the new
> services/service_manager/embedder/result_codes.h.
> 
> Bug:  831846 
> Change-Id: I9776a30412ea43c2c7f511967d2b7d05f18aa841
> Reviewed-on: https://chromium-review.googlesource.com/1012194
> Reviewed-by: Avi Drissman <avi@chromium.org>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Reviewed-by: Scott Graham <scottmg@chromium.org>
> Reviewed-by: Ken Rockot <rockot@chromium.org>
> Reviewed-by: Stephen Lanham <slan@chromium.org>
> Reviewed-by: Eric Seckler <eseckler@chromium.org>
> Reviewed-by: Robert Sesek <rsesek@chromium.org>
> Commit-Queue: Jay Civelli <jcivelli@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#554902}

TBR=avi@chromium.org,sky@chromium.org,dschuff@chromium.org,jcivelli@chromium.org,rockot@chromium.org,slan@chromium.org,scottmg@chromium.org,rsesek@chromium.org,eseckler@chromium.org

Change-Id: I318b3d8d74520b1fa7eda3d6d612d54e9dc2f040
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  831846 ,  838498 
Reviewed-on: https://chromium-review.googlesource.com/1036706
Commit-Queue: Matt Giuca <mgiuca@chromium.org>
Reviewed-by: Matt Giuca <mgiuca@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555001}
[modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/android_webview/browser/aw_browser_main_parts.cc
[modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/apps/DEPS
[modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/chrome/DEPS
[modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/chrome/android/java/DEPS
[modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/chrome/android/javatests/DEPS
[modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/chrome/app/DEPS
[modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/chrome/app/chrome_crash_reporter_client.cc
[modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/chrome/app/chrome_main_delegate.cc
[modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/chrome/app/chrome_main_delegate.h
[modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/chrome/browser/DEPS
[modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/chrome/browser/chrome_browser_main.cc
[modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/chrome/browser/chrome_browser_main_posix.cc
[modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/chrome/browser/chrome_browser_main_win.cc
[modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/chrome/browser/memory_details.cc
[modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/chrome/browser/resource_coordinator/tab_manager_delegate_chromeos.cc
[modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/chrome/browser/ui/uninstall_browser_prompt.h
[modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/chrome/browser/ui/views/uninstall_view.cc
[modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/chrome/browser/ui/webui/sandbox_internals_ui.cc
[modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/chrome/common/DEPS
[modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/chrome/common/thread_profiler.cc
[modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/chrome/gpu/DEPS
[modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/chrome/installer/setup/uninstall.cc
[modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/chrome/renderer/DEPS
[modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/chrome/renderer/pepper/pepper_flash_font_file_host.cc
[modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/chrome/service/DEPS
[modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/chrome/service/service_utility_process_host.cc
[modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/chrome/utility/DEPS
[modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/chrome/utility/importer/firefox_importer_unittest_utils_mac.cc
[modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/chromecast/app/DEPS
[modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/chromecast/app/android/DEPS
[modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/chromecast/app/android/crash_handler.cc
[modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/chromecast/app/cast_main_delegate.cc
[modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/chromecast/app/linux/cast_crash_reporter_client.cc
[modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/chromecast/browser/DEPS
[modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/chromecast/browser/cast_content_browser_client.cc
[modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/components/crash/content/app/breakpad_linux.cc
[modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/components/crash/content/app/crashpad_linux.cc
[modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/components/nacl/DEPS
[modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/components/nacl/broker/BUILD.gn
[modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/components/nacl/broker/nacl_broker_listener.cc
[modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/components/nacl/browser/BUILD.gn
[modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/components/nacl/browser/nacl_broker_host_win.cc
[modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/components/nacl/browser/nacl_process_host.cc
[modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/components/nacl/common/BUILD.gn
[modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/components/nacl/common/nacl_service.cc
[modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/components/nacl/loader/BUILD.gn
[modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/components/nacl/loader/nacl_helper_linux.cc
[modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/components/nacl/loader/nacl_listener.cc
[modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/components/nacl/loader/nonsfi/nonsfi_listener.cc
[modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/components/nacl/zygote/nacl_fork_delegate_linux.cc
[modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/components/nacl/zygote/nacl_fork_delegate_linux.h
[modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/content/BUILD.gn
[modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/content/DEPS
[modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/content/app/content_main_runner.cc
[modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/content/app/content_service_manager_main_delegate.cc
[modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/content/browser/BUILD.gn
[modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/content/browser/browser_child_process_host_impl.cc
[modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/content/browser/browser_main_loop.cc
[modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/content/browser/child_process_launcher.cc
[modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/content/browser/child_process_launcher_helper.h
[modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/content/browser/child_process_launcher_helper_fuchsia.cc
[modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/content/browser/child_process_launcher_helper_linux.cc
[modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/content/browser/child_process_launcher_helper_mac.cc
[modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/content/browser/child_process_launcher_helper_posix.cc
[modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/content/browser/child_process_launcher_helper_win.cc
[modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/content/browser/gpu/gpu_process_host.cc
[modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/content/browser/ppapi_plugin_process_host.cc
[modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/content/browser/renderer_host/pepper/pepper_truetype_font_linux.cc
[modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/content/browser/utility_process_host.cc
[rename] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/content/browser/zygote_host/zygote_communication_linux.cc
[rename] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/content/browser/zygote_host/zygote_communication_linux.h
[rename] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/content/browser/zygote_host/zygote_handle_linux.cc
[rename] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/content/browser/zygote_host/zygote_host_impl_linux.cc
[rename] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/content/browser/zygote_host/zygote_host_impl_linux.h
[modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/content/child/BUILD.gn
[modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/content/child/child_process_sandbox_support_impl_linux.cc
[modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/content/child/child_thread_impl.cc
[modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/content/common/BUILD.gn
[modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/content/common/common_sandbox_support_linux.cc
[add] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/content/common/send_zygote_child_ping_linux.cc
[rename] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/content/common/zygote_commands_linux.h
[modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/content/gpu/BUILD.gn
[modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/content/gpu/gpu_main.cc
[modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/content/public/android/BUILD.gn
[modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/content/public/app/content_main_delegate.cc
[modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/content/public/app/content_main_delegate.h
[modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/content/public/browser/BUILD.gn
[modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/content/public/browser/browser_main_parts.cc
[modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/content/public/browser/child_process_termination_info.h
[rename] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/content/public/browser/zygote_host_linux.h
[modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/content/public/common/BUILD.gn
[modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/content/public/common/common_sandbox_support_linux.h
[modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/content/public/common/content_descriptors.h
[modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/content/public/common/content_switches.cc
[modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/content/public/common/content_switches.h
[add] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/content/public/common/mojo_channel_switches.cc
[add] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/content/public/common/mojo_channel_switches.h
[modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/content/public/common/result_codes.h
[modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/content/public/common/sandboxed_process_launcher_delegate.cc
[modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/content/public/common/sandboxed_process_launcher_delegate.h
[add] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/content/public/common/send_zygote_child_ping_linux.h
[rename] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/content/public/common/zygote_features.gni
[rename] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/content/public/common/zygote_fork_delegate_linux.h
[rename] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/content/public/common/zygote_handle.h
[modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/content/renderer/BUILD.gn
[modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/content/renderer/renderer_main.cc
[modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/content/shell/BUILD.gn
[modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/content/shell/DEPS
[modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/content/shell/app/shell_crash_reporter_client.cc
[modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/content/shell/app/shell_main_delegate.cc
[modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/content/shell/browser/shell_browser_main_parts.cc
[modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/content/shell/browser/shell_content_browser_client.cc
[modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/content/zygote/OWNERS
[modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/content/zygote/zygote_browsertest.cc
[rename] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/content/zygote/zygote_linux.cc
[rename] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/content/zygote/zygote_linux.h
[add] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/content/zygote/zygote_main.h
[rename] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/content/zygote/zygote_main_linux.cc
[modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/extensions/shell/app/DEPS
[modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/extensions/shell/app/shell_crash_reporter_client.cc
[modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/extensions/shell/app/shell_main_delegate.cc
[modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/extensions/shell/app/shell_main_delegate.h
[modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/extensions/shell/browser/shell_browser_main_parts.cc
[modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/headless/DEPS
[modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/headless/lib/browser/headless_content_browser_client.cc
[modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/headless/lib/headless_content_main_delegate.cc
[modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/headless/lib/headless_crash_reporter_client.cc
[modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/services/service_manager/embedder/BUILD.gn
[delete] https://crrev.com/82fd02342d240c3f6d728b0cbd35d7841338d0d0/services/service_manager/embedder/descriptors.h
[delete] https://crrev.com/82fd02342d240c3f6d728b0cbd35d7841338d0d0/services/service_manager/embedder/result_codes.h
[modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/services/service_manager/embedder/switches.cc
[modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/services/service_manager/embedder/switches.h
[delete] https://crrev.com/82fd02342d240c3f6d728b0cbd35d7841338d0d0/services/service_manager/zygote/BUILD.gn
[delete] https://crrev.com/82fd02342d240c3f6d728b0cbd35d7841338d0d0/services/service_manager/zygote/DEPS
[delete] https://crrev.com/82fd02342d240c3f6d728b0cbd35d7841338d0d0/services/service_manager/zygote/OWNERS
[delete] https://crrev.com/82fd02342d240c3f6d728b0cbd35d7841338d0d0/services/service_manager/zygote/common/common_sandbox_support_linux.cc
[delete] https://crrev.com/82fd02342d240c3f6d728b0cbd35d7841338d0d0/services/service_manager/zygote/common/common_sandbox_support_linux.h
[delete] https://crrev.com/82fd02342d240c3f6d728b0cbd35d7841338d0d0/services/service_manager/zygote/common/send_zygote_child_ping_linux.cc
[delete] https://crrev.com/82fd02342d240c3f6d728b0cbd35d7841338d0d0/services/service_manager/zygote/common/send_zygote_child_ping_linux.h
[delete] https://crrev.com/82fd02342d240c3f6d728b0cbd35d7841338d0d0/services/service_manager/zygote/zygote_main.h
[modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/tools/ipc_fuzzer/message_replay/DEPS
[modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/tools/ipc_fuzzer/message_replay/replay_process.cc
[modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/tools/metrics/histograms/enums.xml

Project Member

Comment 7 by bugdroid1@chromium.org, May 3 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1536dfa3f03e3aa847aa374f1bdd17ce98350c26

commit 1536dfa3f03e3aa847aa374f1bdd17ce98350c26
Author: Jay Civelli <jcivelli@google.com>
Date: Thu May 03 20:07:09 2018

Reland "Move zygote code to service_manager"

Relanding the move zygote to the service manager. It was breaking the
non NaCl build.

Original description:

"This CL moves the zygote code from content/ to
services/service_manager/zygote. This involves moving some switches from
content_switches.h to services/service_manager/embedder/switches.h and
moving some codes from content/public/common/result_codes.h to the new
services/service_manager/embedder/result_codes.h."

Tbr: avi@chromium.org
Tbr: sky@chromium.org
Tbr: scottmg@chromium.org
Tbr: rockot@chromium.org
Tbr: slan@chromium.org
Tbr: eseckler@chromium.org
Tbr: rsesek@chromium.org
Bug:  831846 
Change-Id: I8a4ceb2fe6b402d512a2f45b7fab0735b891c578
Reviewed-on: https://chromium-review.googlesource.com/1037633
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Eric Seckler <eseckler@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Jay Civelli <jcivelli@chromium.org>
Commit-Queue: Jay Civelli <jcivelli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555851}
[modify] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/android_webview/browser/aw_browser_main_parts.cc
[modify] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/apps/DEPS
[modify] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/chrome/DEPS
[modify] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/chrome/android/java/DEPS
[modify] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/chrome/android/javatests/DEPS
[modify] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/chrome/app/DEPS
[modify] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/chrome/app/chrome_crash_reporter_client.cc
[modify] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/chrome/app/chrome_main_delegate.cc
[modify] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/chrome/app/chrome_main_delegate.h
[modify] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/chrome/browser/BUILD.gn
[modify] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/chrome/browser/DEPS
[modify] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/chrome/browser/chrome_browser_main.cc
[modify] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/chrome/browser/chrome_browser_main_posix.cc
[modify] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/chrome/browser/chrome_browser_main_win.cc
[modify] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/chrome/browser/memory_details.cc
[modify] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/chrome/browser/resource_coordinator/tab_manager_delegate_chromeos.cc
[modify] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/chrome/browser/ui/uninstall_browser_prompt.h
[modify] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/chrome/browser/ui/views/uninstall_view.cc
[modify] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/chrome/browser/ui/webui/sandbox_internals_ui.cc
[modify] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/chrome/common/DEPS
[modify] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/chrome/common/thread_profiler.cc
[modify] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/chrome/gpu/DEPS
[modify] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/chrome/installer/setup/uninstall.cc
[modify] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/chrome/renderer/DEPS
[modify] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/chrome/renderer/pepper/pepper_flash_font_file_host.cc
[modify] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/chrome/service/DEPS
[modify] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/chrome/service/service_utility_process_host.cc
[modify] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/chrome/utility/DEPS
[modify] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/chrome/utility/importer/firefox_importer_unittest_utils_mac.cc
[modify] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/chromecast/app/DEPS
[modify] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/chromecast/app/android/DEPS
[modify] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/chromecast/app/android/crash_handler.cc
[modify] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/chromecast/app/cast_main_delegate.cc
[modify] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/chromecast/app/linux/cast_crash_reporter_client.cc
[modify] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/chromecast/browser/DEPS
[modify] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/chromecast/browser/cast_content_browser_client.cc
[modify] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/components/crash/content/app/breakpad_linux.cc
[modify] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/components/crash/content/app/crashpad_linux.cc
[modify] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/components/nacl/DEPS
[modify] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/components/nacl/broker/BUILD.gn
[modify] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/components/nacl/broker/nacl_broker_listener.cc
[modify] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/components/nacl/browser/BUILD.gn
[modify] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/components/nacl/browser/nacl_broker_host_win.cc
[modify] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/components/nacl/browser/nacl_process_host.cc
[modify] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/components/nacl/common/BUILD.gn
[modify] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/components/nacl/common/nacl_service.cc
[modify] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/components/nacl/loader/BUILD.gn
[modify] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/components/nacl/loader/nacl_helper_linux.cc
[modify] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/components/nacl/loader/nacl_listener.cc
[modify] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/components/nacl/loader/nonsfi/nonsfi_listener.cc
[modify] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/components/nacl/zygote/nacl_fork_delegate_linux.cc
[modify] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/components/nacl/zygote/nacl_fork_delegate_linux.h
[modify] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/content/BUILD.gn
[modify] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/content/DEPS
[modify] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/content/app/content_main_runner.cc
[modify] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/content/app/content_service_manager_main_delegate.cc
[modify] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/content/browser/BUILD.gn
[modify] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/content/browser/browser_child_process_host_impl.cc
[modify] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/content/browser/browser_main_loop.cc
[modify] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/content/browser/child_process_launcher.cc
[modify] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/content/browser/child_process_launcher_helper.h
[modify] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/content/browser/child_process_launcher_helper_fuchsia.cc
[modify] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/content/browser/child_process_launcher_helper_linux.cc
[modify] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/content/browser/child_process_launcher_helper_mac.cc
[modify] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/content/browser/child_process_launcher_helper_posix.cc
[modify] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/content/browser/child_process_launcher_helper_win.cc
[modify] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/content/browser/gpu/gpu_process_host.cc
[modify] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/content/browser/ppapi_plugin_process_host.cc
[modify] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/content/browser/renderer_host/pepper/pepper_truetype_font_linux.cc
[modify] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/content/browser/utility_process_host.cc
[modify] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/content/child/BUILD.gn
[modify] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/content/child/child_process_sandbox_support_impl_linux.cc
[modify] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/content/child/child_thread_impl.cc
[modify] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/content/common/BUILD.gn
[modify] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/content/common/common_sandbox_support_linux.cc
[delete] https://crrev.com/3ad656139b76dff5d5b42fc7eefd4bceec14e069/content/common/send_zygote_child_ping_linux.cc
[modify] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/content/gpu/BUILD.gn
[modify] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/content/gpu/gpu_main.cc
[modify] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/content/public/android/BUILD.gn
[modify] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/content/public/app/content_main_delegate.cc
[modify] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/content/public/app/content_main_delegate.h
[modify] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/content/public/browser/BUILD.gn
[modify] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/content/public/browser/browser_main_parts.cc
[modify] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/content/public/browser/child_process_termination_info.h
[modify] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/content/public/common/BUILD.gn
[modify] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/content/public/common/common_sandbox_support_linux.h
[modify] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/content/public/common/content_descriptors.h
[modify] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/content/public/common/content_switches.cc
[modify] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/content/public/common/content_switches.h
[delete] https://crrev.com/3ad656139b76dff5d5b42fc7eefd4bceec14e069/content/public/common/mojo_channel_switches.cc
[delete] https://crrev.com/3ad656139b76dff5d5b42fc7eefd4bceec14e069/content/public/common/mojo_channel_switches.h
[modify] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/content/public/common/result_codes.h
[modify] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/content/public/common/sandboxed_process_launcher_delegate.cc
[modify] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/content/public/common/sandboxed_process_launcher_delegate.h
[delete] https://crrev.com/3ad656139b76dff5d5b42fc7eefd4bceec14e069/content/public/common/send_zygote_child_ping_linux.h
[modify] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/content/renderer/BUILD.gn
[modify] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/content/renderer/renderer_main.cc
[modify] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/content/shell/BUILD.gn
[modify] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/content/shell/DEPS
[modify] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/content/shell/app/shell_crash_reporter_client.cc
[modify] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/content/shell/app/shell_main_delegate.cc
[modify] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/content/shell/browser/shell_browser_main_parts.cc
[modify] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/content/shell/browser/shell_content_browser_client.cc
[modify] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/content/zygote/OWNERS
[modify] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/content/zygote/zygote_browsertest.cc
[delete] https://crrev.com/3ad656139b76dff5d5b42fc7eefd4bceec14e069/content/zygote/zygote_main.h
[modify] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/extensions/shell/app/DEPS
[modify] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/extensions/shell/app/shell_crash_reporter_client.cc
[modify] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/extensions/shell/app/shell_main_delegate.cc
[modify] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/extensions/shell/app/shell_main_delegate.h
[modify] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/extensions/shell/browser/shell_browser_main_parts.cc
[modify] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/headless/DEPS
[modify] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/headless/lib/browser/headless_content_browser_client.cc
[modify] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/headless/lib/headless_content_main_delegate.cc
[modify] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/headless/lib/headless_crash_reporter_client.cc
[modify] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/services/service_manager/embedder/BUILD.gn
[add] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/services/service_manager/embedder/descriptors.h
[add] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/services/service_manager/embedder/result_codes.h
[modify] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/services/service_manager/embedder/switches.cc
[modify] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/services/service_manager/embedder/switches.h
[add] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/services/service_manager/zygote/BUILD.gn
[add] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/services/service_manager/zygote/DEPS
[add] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/services/service_manager/zygote/OWNERS
[add] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/services/service_manager/zygote/common/common_sandbox_support_linux.cc
[add] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/services/service_manager/zygote/common/common_sandbox_support_linux.h
[add] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/services/service_manager/zygote/common/send_zygote_child_ping_linux.cc
[add] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/services/service_manager/zygote/common/send_zygote_child_ping_linux.h
[rename] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/services/service_manager/zygote/common/zygote_commands_linux.h
[rename] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/services/service_manager/zygote/common/zygote_features.gni
[rename] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/services/service_manager/zygote/common/zygote_fork_delegate_linux.h
[rename] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/services/service_manager/zygote/common/zygote_handle.h
[rename] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/services/service_manager/zygote/host/zygote_communication_linux.cc
[rename] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/services/service_manager/zygote/host/zygote_communication_linux.h
[rename] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/services/service_manager/zygote/host/zygote_handle_linux.cc
[rename] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/services/service_manager/zygote/host/zygote_host_impl_linux.cc
[rename] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/services/service_manager/zygote/host/zygote_host_impl_linux.h
[rename] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/services/service_manager/zygote/zygote_host_linux.h
[rename] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/services/service_manager/zygote/zygote_linux.cc
[rename] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/services/service_manager/zygote/zygote_linux.h
[add] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/services/service_manager/zygote/zygote_main.h
[rename] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/services/service_manager/zygote/zygote_main_linux.cc
[modify] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/tools/ipc_fuzzer/message_replay/DEPS
[modify] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/tools/ipc_fuzzer/message_replay/replay_process.cc
[modify] https://crrev.com/1536dfa3f03e3aa847aa374f1bdd17ce98350c26/tools/metrics/histograms/enums.xml

Status: Fixed (was: Untriaged)
Project Member

Comment 9 by bugdroid1@chromium.org, May 3 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d6679a3fa2b86749aa4dee531923ab975d146061

commit d6679a3fa2b86749aa4dee531923ab975d146061
Author: CJ DiMeglio <lethalantidote@chromium.org>
Date: Thu May 03 21:40:35 2018

Revert "Reland "Move zygote code to service_manager""

This reverts commit 1536dfa3f03e3aa847aa374f1bdd17ce98350c26.

Reason for revert: Causes data race in DownloadContentTest.ForceDownloadMessageRfc822Page test 
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20TSan%20Tests/21108

Original change's description:
> Reland "Move zygote code to service_manager"
> 
> Relanding the move zygote to the service manager. It was breaking the
> non NaCl build.
> 
> Original description:
> 
> "This CL moves the zygote code from content/ to
> services/service_manager/zygote. This involves moving some switches from
> content_switches.h to services/service_manager/embedder/switches.h and
> moving some codes from content/public/common/result_codes.h to the new
> services/service_manager/embedder/result_codes.h."
> 
> Tbr: avi@chromium.org
> Tbr: sky@chromium.org
> Tbr: scottmg@chromium.org
> Tbr: rockot@chromium.org
> Tbr: slan@chromium.org
> Tbr: eseckler@chromium.org
> Tbr: rsesek@chromium.org
> Bug:  831846 
> Change-Id: I8a4ceb2fe6b402d512a2f45b7fab0735b891c578
> Reviewed-on: https://chromium-review.googlesource.com/1037633
> Reviewed-by: Avi Drissman <avi@chromium.org>
> Reviewed-by: Tom Sepez <tsepez@chromium.org>
> Reviewed-by: Eric Seckler <eseckler@chromium.org>
> Reviewed-by: Scott Graham <scottmg@chromium.org>
> Reviewed-by: Luke Halliwell <halliwell@chromium.org>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Reviewed-by: Ken Rockot <rockot@chromium.org>
> Reviewed-by: Jay Civelli <jcivelli@chromium.org>
> Commit-Queue: Jay Civelli <jcivelli@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#555851}

TBR=avi@chromium.org,sky@chromium.org,jcivelli@chromium.org,rockot@chromium.org,tsepez@chromium.org,slan@chromium.org,halliwell@chromium.org,scottmg@chromium.org,rsesek@chromium.org,eseckler@chromium.org

Change-Id: If3e2d0985960aaafec57f0a6db26e6f078dd7ad9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  831846 
Reviewed-on: https://chromium-review.googlesource.com/1043185
Reviewed-by: CJ DiMeglio <lethalantidote@chromium.org>
Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555884}
[modify] https://crrev.com/d6679a3fa2b86749aa4dee531923ab975d146061/android_webview/browser/aw_browser_main_parts.cc
[modify] https://crrev.com/d6679a3fa2b86749aa4dee531923ab975d146061/apps/DEPS
[modify] https://crrev.com/d6679a3fa2b86749aa4dee531923ab975d146061/chrome/DEPS
[modify] https://crrev.com/d6679a3fa2b86749aa4dee531923ab975d146061/chrome/android/java/DEPS
[modify] https://crrev.com/d6679a3fa2b86749aa4dee531923ab975d146061/chrome/android/javatests/DEPS
[modify] https://crrev.com/d6679a3fa2b86749aa4dee531923ab975d146061/chrome/app/DEPS
[modify] https://crrev.com/d6679a3fa2b86749aa4dee531923ab975d146061/chrome/app/chrome_crash_reporter_client.cc
[modify] https://crrev.com/d6679a3fa2b86749aa4dee531923ab975d146061/chrome/app/chrome_main_delegate.cc
[modify] https://crrev.com/d6679a3fa2b86749aa4dee531923ab975d146061/chrome/app/chrome_main_delegate.h
[modify] https://crrev.com/d6679a3fa2b86749aa4dee531923ab975d146061/chrome/browser/BUILD.gn
[modify] https://crrev.com/d6679a3fa2b86749aa4dee531923ab975d146061/chrome/browser/DEPS
[modify] https://crrev.com/d6679a3fa2b86749aa4dee531923ab975d146061/chrome/browser/chrome_browser_main.cc
[modify] https://crrev.com/d6679a3fa2b86749aa4dee531923ab975d146061/chrome/browser/chrome_browser_main_posix.cc
[modify] https://crrev.com/d6679a3fa2b86749aa4dee531923ab975d146061/chrome/browser/chrome_browser_main_win.cc
[modify] https://crrev.com/d6679a3fa2b86749aa4dee531923ab975d146061/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/d6679a3fa2b86749aa4dee531923ab975d146061/chrome/browser/memory_details.cc
[modify] https://crrev.com/d6679a3fa2b86749aa4dee531923ab975d146061/chrome/browser/resource_coordinator/tab_manager_delegate_chromeos.cc
[modify] https://crrev.com/d6679a3fa2b86749aa4dee531923ab975d146061/chrome/browser/ui/uninstall_browser_prompt.h
[modify] https://crrev.com/d6679a3fa2b86749aa4dee531923ab975d146061/chrome/browser/ui/views/uninstall_view.cc
[modify] https://crrev.com/d6679a3fa2b86749aa4dee531923ab975d146061/chrome/browser/ui/webui/sandbox_internals_ui.cc
[modify] https://crrev.com/d6679a3fa2b86749aa4dee531923ab975d146061/chrome/common/DEPS
[modify] https://crrev.com/d6679a3fa2b86749aa4dee531923ab975d146061/chrome/common/thread_profiler.cc
[modify] https://crrev.com/d6679a3fa2b86749aa4dee531923ab975d146061/chrome/gpu/DEPS
[modify] https://crrev.com/d6679a3fa2b86749aa4dee531923ab975d146061/chrome/installer/setup/uninstall.cc
[modify] https://crrev.com/d6679a3fa2b86749aa4dee531923ab975d146061/chrome/renderer/DEPS
[modify] https://crrev.com/d6679a3fa2b86749aa4dee531923ab975d146061/chrome/renderer/pepper/pepper_flash_font_file_host.cc
[modify] https://crrev.com/d6679a3fa2b86749aa4dee531923ab975d146061/chrome/service/DEPS
[modify] https://crrev.com/d6679a3fa2b86749aa4dee531923ab975d146061/chrome/service/service_utility_process_host.cc
[modify] https://crrev.com/d6679a3fa2b86749aa4dee531923ab975d146061/chrome/utility/DEPS
[modify] https://crrev.com/d6679a3fa2b86749aa4dee531923ab975d146061/chrome/utility/importer/firefox_importer_unittest_utils_mac.cc
[modify] https://crrev.com/d6679a3fa2b86749aa4dee531923ab975d146061/chromecast/app/DEPS
[modify] https://crrev.com/d6679a3fa2b86749aa4dee531923ab975d146061/chromecast/app/android/DEPS
[modify] https://crrev.com/d6679a3fa2b86749aa4dee531923ab975d146061/chromecast/app/android/crash_handler.cc
[modify] https://crrev.com/d6679a3fa2b86749aa4dee531923ab975d146061/chromecast/app/cast_main_delegate.cc
[modify] https://crrev.com/d6679a3fa2b86749aa4dee531923ab975d146061/chromecast/app/linux/cast_crash_reporter_client.cc
[modify] https://crrev.com/d6679a3fa2b86749aa4dee531923ab975d146061/chromecast/browser/DEPS
[modify] https://crrev.com/d6679a3fa2b86749aa4dee531923ab975d146061/chromecast/browser/cast_content_browser_client.cc
[modify] https://crrev.com/d6679a3fa2b86749aa4dee531923ab975d146061/components/crash/content/app/breakpad_linux.cc
[modify] https://crrev.com/d6679a3fa2b86749aa4dee531923ab975d146061/components/crash/content/app/crashpad_linux.cc
[modify] https://crrev.com/d6679a3fa2b86749aa4dee531923ab975d146061/components/nacl/DEPS
[modify] https://crrev.com/d6679a3fa2b86749aa4dee531923ab975d146061/components/nacl/broker/BUILD.gn
[modify] https://crrev.com/d6679a3fa2b86749aa4dee531923ab975d146061/components/nacl/broker/nacl_broker_listener.cc
[modify] https://crrev.com/d6679a3fa2b86749aa4dee531923ab975d146061/components/nacl/browser/BUILD.gn
[modify] https://crrev.com/d6679a3fa2b86749aa4dee531923ab975d146061/components/nacl/browser/nacl_broker_host_win.cc
[modify] https://crrev.com/d6679a3fa2b86749aa4dee531923ab975d146061/components/nacl/browser/nacl_process_host.cc
[modify] https://crrev.com/d6679a3fa2b86749aa4dee531923ab975d146061/components/nacl/common/BUILD.gn
[modify] https://crrev.com/d6679a3fa2b86749aa4dee531923ab975d146061/components/nacl/common/nacl_service.cc
[modify] https://crrev.com/d6679a3fa2b86749aa4dee531923ab975d146061/components/nacl/loader/BUILD.gn
[modify] https://crrev.com/d6679a3fa2b86749aa4dee531923ab975d146061/components/nacl/loader/nacl_helper_linux.cc
[modify] https://crrev.com/d6679a3fa2b86749aa4dee531923ab975d146061/components/nacl/loader/nacl_listener.cc
[modify] https://crrev.com/d6679a3fa2b86749aa4dee531923ab975d146061/components/nacl/loader/nonsfi/nonsfi_listener.cc
[modify] https://crrev.com/d6679a3fa2b86749aa4dee531923ab975d146061/components/nacl/zygote/nacl_fork_delegate_linux.cc
[modify] https://crrev.com/d6679a3fa2b86749aa4dee531923ab975d146061/components/nacl/zygote/nacl_fork_delegate_linux.h
[modify] https://crrev.com/d6679a3fa2b86749aa4dee531923ab975d146061/content/BUILD.gn
[modify] https://crrev.com/d6679a3fa2b86749aa4dee531923ab975d146061/content/DEPS
[modify] https://crrev.com/d6679a3fa2b86749aa4dee531923ab975d146061/content/app/content_main_runner.cc
[modify] https://crrev.com/d6679a3fa2b86749aa4dee531923ab975d146061/content/app/content_service_manager_main_delegate.cc
[modify] https://crrev.com/d6679a3fa2b86749aa4dee531923ab975d146061/content/browser/BUILD.gn
[modify] https://crrev.com/d6679a3fa2b86749aa4dee531923ab975d146061/content/browser/browser_child_process_host_impl.cc
[modify] https://crrev.com/d6679a3fa2b86749aa4dee531923ab975d146061/content/browser/browser_main_loop.cc
[modify] https://crrev.com/d6679a3fa2b86749aa4dee531923ab975d146061/content/browser/child_process_launcher.cc
[modify] https://crrev.com/d6679a3fa2b86749aa4dee531923ab975d146061/content/browser/child_process_launcher_helper.h
[modify] https://crrev.com/d6679a3fa2b86749aa4dee531923ab975d146061/content/browser/child_process_launcher_helper_fuchsia.cc
[modify] https://crrev.com/d6679a3fa2b86749aa4dee531923ab975d146061/content/browser/child_process_launcher_helper_linux.cc
[modify] https://crrev.com/d6679a3fa2b86749aa4dee531923ab975d146061/content/browser/child_process_launcher_helper_mac.cc
[modify] https://crrev.com/d6679a3fa2b86749aa4dee531923ab975d146061/content/browser/child_process_launcher_helper_posix.cc
[modify] https://crrev.com/d6679a3fa2b86749aa4dee531923ab975d146061/content/browser/child_process_launcher_helper_win.cc
[modify] https://crrev.com/d6679a3fa2b86749aa4dee531923ab975d146061/content/browser/gpu/gpu_process_host.cc
[modify] https://crrev.com/d6679a3fa2b86749aa4dee531923ab975d146061/content/browser/ppapi_plugin_process_host.cc
[modify] https://crrev.com/d6679a3fa2b86749aa4dee531923ab975d146061/content/browser/renderer_host/pepper/pepper_truetype_font_linux.cc
[modify] https://crrev.com/d6679a3fa2b86749aa4dee531923ab975d146061/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/d6679a3fa2b86749aa4dee531923ab975d146061/content/browser/utility_process_host.cc
[rename] https://crrev.com/d6679a3fa2b86749aa4dee531923ab975d146061/content/browser/zygote_host/zygote_communication_linux.cc
[rename] https://crrev.com/d6679a3fa2b86749aa4dee531923ab975d146061/content/browser/zygote_host/zygote_communication_linux.h
[rename] https://crrev.com/d6679a3fa2b86749aa4dee531923ab975d146061/content/browser/zygote_host/zygote_handle_linux.cc
[rename] https://crrev.com/d6679a3fa2b86749aa4dee531923ab975d146061/content/browser/zygote_host/zygote_host_impl_linux.cc
[rename] https://crrev.com/d6679a3fa2b86749aa4dee531923ab975d146061/content/browser/zygote_host/zygote_host_impl_linux.h
[modify] https://crrev.com/d6679a3fa2b86749aa4dee531923ab975d146061/content/child/BUILD.gn
[modify] https://crrev.com/d6679a3fa2b86749aa4dee531923ab975d146061/content/child/child_process_sandbox_support_impl_linux.cc
[modify] https://crrev.com/d6679a3fa2b86749aa4dee531923ab975d146061/content/child/child_thread_impl.cc
[modify] https://crrev.com/d6679a3fa2b86749aa4dee531923ab975d146061/content/common/BUILD.gn
[modify] https://crrev.com/d6679a3fa2b86749aa4dee531923ab975d146061/content/common/common_sandbox_support_linux.cc
[add] https://crrev.com/d6679a3fa2b86749aa4dee531923ab975d146061/content/common/send_zygote_child_ping_linux.cc
[rename] https://crrev.com/d6679a3fa2b86749aa4dee531923ab975d146061/content/common/zygote_commands_linux.h
[modify] https://crrev.com/d6679a3fa2b86749aa4dee531923ab975d146061/content/gpu/BUILD.gn
[modify] https://crrev.com/d6679a3fa2b86749aa4dee531923ab975d146061/content/gpu/gpu_main.cc
[modify] https://crrev.com/d6679a3fa2b86749aa4dee531923ab975d146061/content/public/android/BUILD.gn
[modify] https://crrev.com/d6679a3fa2b86749aa4dee531923ab975d146061/content/public/app/content_main_delegate.cc
[modify] https://crrev.com/d6679a3fa2b86749aa4dee531923ab975d146061/content/public/app/content_main_delegate.h
[modify] https://crrev.com/d6679a3fa2b86749aa4dee531923ab975d146061/content/public/browser/BUILD.gn
[modify] https://crrev.com/d6679a3fa2b86749aa4dee531923ab975d146061/content/public/browser/browser_main_parts.cc
[modify] https://crrev.com/d6679a3fa2b86749aa4dee531923ab975d146061/content/public/browser/child_process_termination_info.h
[rename] https://crrev.com/d6679a3fa2b86749aa4dee531923ab975d146061/content/public/browser/zygote_host_linux.h
[modify] https://crrev.com/d6679a3fa2b86749aa4dee531923ab975d146061/content/public/common/BUILD.gn
[modify] https://crrev.com/d6679a3fa2b86749aa4dee531923ab975d146061/content/public/common/common_sandbox_support_linux.h
[modify] https://crrev.com/d6679a3fa2b86749aa4dee531923ab975d146061/content/public/common/content_descriptors.h
[modify] https://crrev.com/d6679a3fa2b86749aa4dee531923ab975d146061/content/public/common/content_switches.cc
[modify] https://crrev.com/d6679a3fa2b86749aa4dee531923ab975d146061/content/public/common/content_switches.h
[add] https://crrev.com/d6679a3fa2b86749aa4dee531923ab975d146061/content/public/common/mojo_channel_switches.cc
[add] https://crrev.com/d6679a3fa2b86749aa4dee531923ab975d146061/content/public/common/mojo_channel_switches.h
[modify] https://crrev.com/d6679a3fa2b86749aa4dee531923ab975d146061/content/public/common/result_codes.h
[modify] https://crrev.com/d6679a3fa2b86749aa4dee531923ab975d146061/content/public/common/sandboxed_process_launcher_delegate.cc
[modify] https://crrev.com/d6679a3fa2b86749aa4dee531923ab975d146061/content/public/common/sandboxed_process_launcher_delegate.h
[add] https://crrev.com/d6679a3fa2b86749aa4dee531923ab975d146061/content/public/common/send_zygote_child_ping_linux.h
[rename] https://crrev.com/d6679a3fa2b86749aa4dee531923ab975d146061/content/public/common/zygote_features.gni
[rename] https://crrev.com/d6679a3fa2b86749aa4dee531923ab975d146061/content/public/common/zygote_fork_delegate_linux.h
[rename] https://crrev.com/d6679a3fa2b86749aa4dee531923ab975d146061/content/public/common/zygote_handle.h
[modify] https://crrev.com/d6679a3fa2b86749aa4dee531923ab975d146061/content/renderer/BUILD.gn
[modify] https://crrev.com/d6679a3fa2b86749aa4dee531923ab975d146061/content/renderer/renderer_main.cc
[modify] https://crrev.com/d6679a3fa2b86749aa4dee531923ab975d146061/content/shell/BUILD.gn
[modify] https://crrev.com/d6679a3fa2b86749aa4dee531923ab975d146061/content/shell/DEPS
[modify] https://crrev.com/d6679a3fa2b86749aa4dee531923ab975d146061/content/shell/app/shell_crash_reporter_client.cc
[modify] https://crrev.com/d6679a3fa2b86749aa4dee531923ab975d146061/content/shell/app/shell_main_delegate.cc
[modify] https://crrev.com/d6679a3fa2b86749aa4dee531923ab975d146061/content/shell/browser/shell_browser_main_parts.cc
[modify] https://crrev.com/d6679a3fa2b86749aa4dee531923ab975d146061/content/shell/browser/shell_content_browser_client.cc
[modify] https://crrev.com/d6679a3fa2b86749aa4dee531923ab975d146061/content/zygote/OWNERS
[modify] https://crrev.com/d6679a3fa2b86749aa4dee531923ab975d146061/content/zygote/zygote_browsertest.cc
[rename] https://crrev.com/d6679a3fa2b86749aa4dee531923ab975d146061/content/zygote/zygote_linux.cc
[rename] https://crrev.com/d6679a3fa2b86749aa4dee531923ab975d146061/content/zygote/zygote_linux.h
[add] https://crrev.com/d6679a3fa2b86749aa4dee531923ab975d146061/content/zygote/zygote_main.h
[rename] https://crrev.com/d6679a3fa2b86749aa4dee531923ab975d146061/content/zygote/zygote_main_linux.cc
[modify] https://crrev.com/d6679a3fa2b86749aa4dee531923ab975d146061/extensions/shell/app/DEPS
[modify] https://crrev.com/d6679a3fa2b86749aa4dee531923ab975d146061/extensions/shell/app/shell_crash_reporter_client.cc
[modify] https://crrev.com/d6679a3fa2b86749aa4dee531923ab975d146061/extensions/shell/app/shell_main_delegate.cc
[modify] https://crrev.com/d6679a3fa2b86749aa4dee531923ab975d146061/extensions/shell/app/shell_main_delegate.h
[modify] https://crrev.com/d6679a3fa2b86749aa4dee531923ab975d146061/extensions/shell/browser/shell_browser_main_parts.cc
[modify] https://crrev.com/d6679a3fa2b86749aa4dee531923ab975d146061/headless/DEPS
[modify] https://crrev.com/d6679a3fa2b86749aa4dee531923ab975d146061/headless/lib/browser/headless_content_browser_client.cc
[modify] https://crrev.com/d6679a3fa2b86749aa4dee531923ab975d146061/headless/lib/headless_content_main_delegate.cc
[modify] https://crrev.com/d6679a3fa2b86749aa4dee531923ab975d146061/headless/lib/headless_crash_reporter_client.cc
[modify] https://crrev.com/d6679a3fa2b86749aa4dee531923ab975d146061/services/service_manager/embedder/BUILD.gn
[delete] https://crrev.com/a718130e0470c54259f2c9181f1a1a83fcf2a5ef/services/service_manager/embedder/descriptors.h
[delete] https://crrev.com/a718130e0470c54259f2c9181f1a1a83fcf2a5ef/services/service_manager/embedder/result_codes.h
[modify] https://crrev.com/d6679a3fa2b86749aa4dee531923ab975d146061/services/service_manager/embedder/switches.cc
[modify] https://crrev.com/d6679a3fa2b86749aa4dee531923ab975d146061/services/service_manager/embedder/switches.h
[delete] https://crrev.com/a718130e0470c54259f2c9181f1a1a83fcf2a5ef/services/service_manager/zygote/BUILD.gn
[delete] https://crrev.com/a718130e0470c54259f2c9181f1a1a83fcf2a5ef/services/service_manager/zygote/DEPS
[delete] https://crrev.com/a718130e0470c54259f2c9181f1a1a83fcf2a5ef/services/service_manager/zygote/OWNERS
[delete] https://crrev.com/a718130e0470c54259f2c9181f1a1a83fcf2a5ef/services/service_manager/zygote/common/common_sandbox_support_linux.cc
[delete] https://crrev.com/a718130e0470c54259f2c9181f1a1a83fcf2a5ef/services/service_manager/zygote/common/common_sandbox_support_linux.h
[delete] https://crrev.com/a718130e0470c54259f2c9181f1a1a83fcf2a5ef/services/service_manager/zygote/common/send_zygote_child_ping_linux.cc
[delete] https://crrev.com/a718130e0470c54259f2c9181f1a1a83fcf2a5ef/services/service_manager/zygote/common/send_zygote_child_ping_linux.h
[delete] https://crrev.com/a718130e0470c54259f2c9181f1a1a83fcf2a5ef/services/service_manager/zygote/zygote_main.h
[modify] https://crrev.com/d6679a3fa2b86749aa4dee531923ab975d146061/tools/ipc_fuzzer/message_replay/DEPS
[modify] https://crrev.com/d6679a3fa2b86749aa4dee531923ab975d146061/tools/ipc_fuzzer/message_replay/replay_process.cc
[modify] https://crrev.com/d6679a3fa2b86749aa4dee531923ab975d146061/tools/metrics/histograms/enums.xml

Project Member

Comment 10 by bugdroid1@chromium.org, May 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/668c097f9a63111240b9117bae1e73c770e15d51

commit 668c097f9a63111240b9117bae1e73c770e15d51
Author: Jay Civelli <jcivelli@google.com>
Date: Wed May 16 20:44:13 2018

Reland "Move zygote code to service_manager"

Relanding the move zygote to the service manager. It was causing an TSAN
failure that now cannot be reproduced.

Original description:

"This CL moves the zygote code from content/ to
services/service_manager/zygote. This involves moving some switches from
content_switches.h to services/service_manager/embedder/switches.h and
moving some codes from content/public/common/result_codes.h to the new
services/service_manager/embedder/result_codes.h."

Tbr: avi@chromium.org
Tbr: sky@chromium.org
Tbr: scottmg@chromium.org
Tbr: rockot@chromium.org
Tbr: slan@chromium.org
Tbr: eseckler@chromium.org
Tbr: rsesek@chromium.org
Bug:  831846 
Change-Id: Ief3c55a1d76ab0b0ded922770d14402c0c3b37b9
Reviewed-on: https://chromium-review.googlesource.com/1048040
Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Eric Seckler <eseckler@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Jay Civelli <jcivelli@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Reviewed-by: Stephen Lanham <slan@chromium.org>
Commit-Queue: Jay Civelli <jcivelli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559276}
[modify] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/android_webview/browser/aw_browser_main_parts.cc
[modify] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/apps/DEPS
[modify] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/chrome/DEPS
[modify] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/chrome/android/java/DEPS
[modify] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/chrome/android/javatests/DEPS
[modify] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/chrome/app/DEPS
[modify] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/chrome/app/chrome_crash_reporter_client.cc
[modify] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/chrome/app/chrome_main_delegate.cc
[modify] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/chrome/app/chrome_main_delegate.h
[modify] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/chrome/browser/BUILD.gn
[modify] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/chrome/browser/DEPS
[modify] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/chrome/browser/chrome_browser_main.cc
[modify] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/chrome/browser/chrome_browser_main_posix.cc
[modify] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/chrome/browser/chrome_browser_main_win.cc
[modify] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/chrome/browser/memory_details.cc
[modify] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/chrome/browser/resource_coordinator/tab_manager_delegate_chromeos.cc
[modify] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/chrome/browser/ui/uninstall_browser_prompt.h
[modify] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/chrome/browser/ui/views/uninstall_view.cc
[modify] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/chrome/browser/ui/webui/sandbox_internals_ui.cc
[modify] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/chrome/common/DEPS
[modify] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/chrome/common/thread_profiler.cc
[modify] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/chrome/gpu/DEPS
[modify] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/chrome/installer/setup/uninstall.cc
[modify] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/chrome/renderer/DEPS
[modify] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/chrome/renderer/pepper/pepper_flash_font_file_host.cc
[modify] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/chrome/service/DEPS
[modify] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/chrome/service/service_utility_process_host.cc
[modify] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/chrome/utility/DEPS
[modify] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/chrome/utility/importer/firefox_importer_unittest_utils_mac.cc
[modify] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/chromecast/app/DEPS
[modify] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/chromecast/app/android/DEPS
[modify] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/chromecast/app/android/crash_handler.cc
[modify] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/chromecast/app/cast_main_delegate.cc
[modify] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/chromecast/app/linux/cast_crash_reporter_client.cc
[modify] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/chromecast/browser/DEPS
[modify] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/chromecast/browser/cast_content_browser_client.cc
[modify] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/components/crash/content/app/breakpad_linux.cc
[modify] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/components/crash/content/app/crashpad_linux.cc
[modify] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/components/nacl/DEPS
[modify] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/components/nacl/broker/BUILD.gn
[modify] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/components/nacl/broker/nacl_broker_listener.cc
[modify] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/components/nacl/browser/BUILD.gn
[modify] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/components/nacl/browser/nacl_broker_host_win.cc
[modify] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/components/nacl/browser/nacl_process_host.cc
[modify] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/components/nacl/common/BUILD.gn
[modify] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/components/nacl/common/nacl_service.cc
[modify] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/components/nacl/loader/BUILD.gn
[modify] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/components/nacl/loader/nacl_helper_linux.cc
[modify] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/components/nacl/loader/nacl_listener.cc
[modify] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/components/nacl/loader/nonsfi/nonsfi_listener.cc
[modify] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/components/nacl/zygote/nacl_fork_delegate_linux.cc
[modify] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/components/nacl/zygote/nacl_fork_delegate_linux.h
[modify] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/content/BUILD.gn
[modify] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/content/DEPS
[modify] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/content/app/content_main_runner_impl.cc
[modify] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/content/app/content_service_manager_main_delegate.cc
[modify] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/content/browser/BUILD.gn
[modify] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/content/browser/browser_child_process_host_impl.cc
[modify] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/content/browser/browser_main_loop.cc
[modify] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/content/browser/child_process_launcher.cc
[modify] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/content/browser/child_process_launcher_helper.h
[modify] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/content/browser/child_process_launcher_helper_fuchsia.cc
[modify] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/content/browser/child_process_launcher_helper_linux.cc
[modify] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/content/browser/child_process_launcher_helper_mac.cc
[modify] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/content/browser/child_process_launcher_helper_posix.cc
[modify] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/content/browser/child_process_launcher_helper_win.cc
[modify] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/content/browser/gpu/gpu_process_host.cc
[modify] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/content/browser/ppapi_plugin_process_host.cc
[modify] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/content/browser/renderer_host/pepper/pepper_truetype_font_linux.cc
[modify] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/content/browser/utility_process_host.cc
[modify] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/content/child/BUILD.gn
[modify] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/content/child/child_process_sandbox_support_impl_linux.cc
[modify] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/content/child/child_thread_impl.cc
[modify] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/content/common/BUILD.gn
[modify] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/content/common/common_sandbox_support_linux.cc
[delete] https://crrev.com/2028c1da1380e7f4f508675ca8d98083952c69b3/content/common/send_zygote_child_ping_linux.cc
[modify] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/content/gpu/BUILD.gn
[modify] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/content/gpu/gpu_main.cc
[modify] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/content/public/android/BUILD.gn
[modify] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/content/public/app/content_main_delegate.cc
[modify] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/content/public/app/content_main_delegate.h
[modify] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/content/public/browser/BUILD.gn
[modify] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/content/public/browser/browser_main_parts.cc
[modify] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/content/public/browser/child_process_termination_info.h
[modify] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/content/public/common/BUILD.gn
[modify] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/content/public/common/common_sandbox_support_linux.h
[modify] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/content/public/common/content_descriptors.h
[modify] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/content/public/common/content_switches.cc
[modify] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/content/public/common/content_switches.h
[delete] https://crrev.com/2028c1da1380e7f4f508675ca8d98083952c69b3/content/public/common/mojo_channel_switches.cc
[delete] https://crrev.com/2028c1da1380e7f4f508675ca8d98083952c69b3/content/public/common/mojo_channel_switches.h
[modify] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/content/public/common/result_codes.h
[modify] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/content/public/common/sandboxed_process_launcher_delegate.cc
[modify] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/content/public/common/sandboxed_process_launcher_delegate.h
[delete] https://crrev.com/2028c1da1380e7f4f508675ca8d98083952c69b3/content/public/common/send_zygote_child_ping_linux.h
[modify] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/content/renderer/BUILD.gn
[modify] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/content/renderer/renderer_main.cc
[modify] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/content/shell/BUILD.gn
[modify] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/content/shell/DEPS
[modify] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/content/shell/app/shell_crash_reporter_client.cc
[modify] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/content/shell/app/shell_main_delegate.cc
[modify] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/content/shell/browser/shell_browser_main_parts.cc
[modify] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/content/shell/browser/shell_content_browser_client.cc
[modify] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/content/zygote/OWNERS
[modify] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/content/zygote/zygote_browsertest.cc
[delete] https://crrev.com/2028c1da1380e7f4f508675ca8d98083952c69b3/content/zygote/zygote_main.h
[modify] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/extensions/shell/app/DEPS
[modify] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/extensions/shell/app/shell_crash_reporter_client.cc
[modify] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/extensions/shell/app/shell_main_delegate.cc
[modify] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/extensions/shell/app/shell_main_delegate.h
[modify] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/extensions/shell/browser/shell_browser_main_parts.cc
[modify] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/headless/DEPS
[modify] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/headless/lib/browser/headless_content_browser_client.cc
[modify] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/headless/lib/headless_content_main_delegate.cc
[modify] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/headless/lib/headless_crash_reporter_client.cc
[modify] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/services/service_manager/embedder/BUILD.gn
[add] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/services/service_manager/embedder/descriptors.h
[add] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/services/service_manager/embedder/result_codes.h
[modify] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/services/service_manager/embedder/switches.cc
[modify] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/services/service_manager/embedder/switches.h
[add] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/services/service_manager/zygote/BUILD.gn
[add] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/services/service_manager/zygote/DEPS
[add] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/services/service_manager/zygote/OWNERS
[add] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/services/service_manager/zygote/common/common_sandbox_support_linux.cc
[add] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/services/service_manager/zygote/common/common_sandbox_support_linux.h
[add] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/services/service_manager/zygote/common/send_zygote_child_ping_linux.cc
[add] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/services/service_manager/zygote/common/send_zygote_child_ping_linux.h
[rename] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/services/service_manager/zygote/common/zygote_commands_linux.h
[rename] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/services/service_manager/zygote/common/zygote_features.gni
[rename] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/services/service_manager/zygote/common/zygote_fork_delegate_linux.h
[rename] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/services/service_manager/zygote/common/zygote_handle.h
[rename] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/services/service_manager/zygote/host/zygote_communication_linux.cc
[rename] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/services/service_manager/zygote/host/zygote_communication_linux.h
[rename] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/services/service_manager/zygote/host/zygote_handle_linux.cc
[rename] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/services/service_manager/zygote/host/zygote_host_impl_linux.cc
[rename] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/services/service_manager/zygote/host/zygote_host_impl_linux.h
[rename] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/services/service_manager/zygote/zygote_host_linux.h
[rename] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/services/service_manager/zygote/zygote_linux.cc
[rename] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/services/service_manager/zygote/zygote_linux.h
[add] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/services/service_manager/zygote/zygote_main.h
[rename] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/services/service_manager/zygote/zygote_main_linux.cc
[modify] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/tools/ipc_fuzzer/message_replay/DEPS
[modify] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/tools/ipc_fuzzer/message_replay/replay_process.cc
[modify] https://crrev.com/668c097f9a63111240b9117bae1e73c770e15d51/tools/metrics/histograms/enums.xml

Sign in to add a comment