New issue
Advanced search Search tips

Issue 831831 link

Starred by 1 user
Status: Fixed
Owner:
jianli@chromium.org
Closed: Apr 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Opening untrusted MHTML files from Astro File Manager does not show offline chip

Project Member Reported by jianli@chromium.org, Apr 11 2018 
Repro steps:
1) Receive a MHTML file from other devices
2) Open it from Astro File Manager

The offline chip is not shown. The omnibox does contain content URL.

It is expected to show the offline chip.
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 12 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5fb3a62541301740e3a24e24aac220d93bfccf12

commit 5fb3a62541301740e3a24e24aac220d93bfccf12
Author: Jian Li <jianli@chromium.org>
Date: Thu Apr 12 02:07:23 2018

Create untrusted offline page for content URL with message/rfc822 type

Bug:  831831 
Change-Id: If1a36fbec7e73571d7d8c6a921afb3d8fa9b70c3
Reviewed-on: https://chromium-review.googlesource.com/1008635
Reviewed-by: Yafei Duan <romax@chromium.org>
Commit-Queue: Jian Li <jianli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549998}
[modify] https://crrev.com/5fb3a62541301740e3a24e24aac220d93bfccf12/chrome/browser/offline_pages/offline_page_tab_helper.cc
[modify] https://crrev.com/5fb3a62541301740e3a24e24aac220d93bfccf12/chrome/browser/offline_pages/offline_page_tab_helper_unittest.cc

Comment 2 by jianli@chromium.org, Apr 12 2018

Status: Fixed (was: Started)

Comment 3 by jianli@chromium.org, Apr 23 2018

Labels: Merge-Request-67

Comment 4 by jianli@chromium.org, Apr 23 2018 

Verified with Chrome Canary 68.0.3404.0

Comment 5 by gov...@chromium.org, Apr 23 2018 

Pls add appropriate OSs labels. Thank you.

Comment 6 by jianli@chromium.org, Apr 23 2018

Labels: OS-Android
Project Member

Comment 7 by sheriffbot@chromium.org, Apr 24 2018

Labels: -Merge-Request-67 Merge-Approved-67 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M67. Please go ahead and merge the CL to branch 3396 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 8 by jianli@chromium.org, Apr 24 2018

Labels: -Hotlist-Merge-Approved -Merge-Approved-67
The CL is already in the branch.
►

Sign in to add a comment