New issue
Advanced search Search tips

Issue 831829 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

WebView autofill UMA

Project Member Reported by michaelbai@chromium.org, Apr 11 2018

Issue description

Labels: -Pri-3 Pri-2

Comment 2 by ma...@chromium.org, May 1 2018

Components: UI>Browser>Autofill
Project Member

Comment 3 by bugdroid1@chromium.org, May 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/851aad4c8ea88fde4872d0919d5bcebf8488ab56

commit 851aad4c8ea88fde4872d0919d5bcebf8488ab56
Author: Tao Bai <michaelbai@chromium.org>
Date: Tue May 01 17:58:17 2018

[Web Autofill] First UMA implementation

This patch implements 3 UMA histograms, these are
- Whether autofill service enabled
- Autofill session state
- Submission source.

Bug: 831829
Change-Id: I904466832db8296924d51a055b1c630deab6553c
Reviewed-on: https://chromium-review.googlesource.com/1008862
Reviewed-by: Changwan Ryu <changwan@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Tao Bai <michaelbai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555108}
[modify] https://crrev.com/851aad4c8ea88fde4872d0919d5bcebf8488ab56/android_webview/BUILD.gn
[modify] https://crrev.com/851aad4c8ea88fde4872d0919d5bcebf8488ab56/android_webview/java/src/org/chromium/android_webview/AwAutofillManager.java
[modify] https://crrev.com/851aad4c8ea88fde4872d0919d5bcebf8488ab56/android_webview/java/src/org/chromium/android_webview/AwAutofillProvider.java
[add] https://crrev.com/851aad4c8ea88fde4872d0919d5bcebf8488ab56/android_webview/java/src/org/chromium/android_webview/AwAutofillUMA.java
[modify] https://crrev.com/851aad4c8ea88fde4872d0919d5bcebf8488ab56/android_webview/javatests/src/org/chromium/android_webview/test/AwAutofillTest.java
[modify] https://crrev.com/851aad4c8ea88fde4872d0919d5bcebf8488ab56/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/851aad4c8ea88fde4872d0919d5bcebf8488ab56/tools/metrics/histograms/histograms.xml

Comment 4 by dlkumar@google.com, May 1 2018

Cc: dlkumar@google.com
Project Member

Comment 5 by bugdroid1@chromium.org, May 11 2018

Labels: Merge-Request-68
The 3rd patch landed https://chromium-review.googlesource.com/c/chromium/src/+/1065204 , it need to merge to m68
Project Member

Comment 7 by sheriffbot@chromium.org, May 26 2018

Labels: -Merge-Request-68 Hotlist-Merge-Approved Merge-Approved-68
Your change meets the bar and is auto-approved for M68. Please go ahead and merge the CL to branch 3440 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 8 by sheriffbot@chromium.org, May 30 2018

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 9 by bugdroid1@chromium.org, May 30 2018

Labels: -merge-approved-68 merge-merged-3440
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5cbd6cdbe7e5abfdbe1666e599a4045de8d585b5

commit 5cbd6cdbe7e5abfdbe1666e599a4045de8d585b5
Author: Tao Bai <michaelbai@chromium.org>
Date: Wed May 30 20:00:12 2018

[WebView Autofill] add metric for suggestion time and context

Bug: 831829
Change-Id: Ibfeee6aefedcc4c46b432d1f2df02089d521d214
Reviewed-on: https://chromium-review.googlesource.com/1065204
Reviewed-by: Changwan Ryu <changwan@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Tao Bai <michaelbai@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#561741}(cherry picked from commit 197818c81c85326544b9c294ec682183ed96ad9d)
Reviewed-on: https://chromium-review.googlesource.com/1079728
Reviewed-by: Tao Bai <michaelbai@chromium.org>
Cr-Commit-Position: refs/branch-heads/3440@{#48}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}
[modify] https://crrev.com/5cbd6cdbe7e5abfdbe1666e599a4045de8d585b5/android_webview/java/src/org/chromium/android_webview/AwAutofillProvider.java
[modify] https://crrev.com/5cbd6cdbe7e5abfdbe1666e599a4045de8d585b5/android_webview/java/src/org/chromium/android_webview/AwAutofillUMA.java
[modify] https://crrev.com/5cbd6cdbe7e5abfdbe1666e599a4045de8d585b5/android_webview/javatests/src/org/chromium/android_webview/test/AwAutofillTest.java
[modify] https://crrev.com/5cbd6cdbe7e5abfdbe1666e599a4045de8d585b5/tools/metrics/histograms/histograms.xml

Sign in to add a comment