New issue
Advanced search Search tips

Issue 831826 link

Starred by 1 user

Issue metadata

Status: Archived
Owner: ----
Closed: Nov 8
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug

Blocked on:
issue 682402



Sign in to add a comment

mash: some browser tests use ash::Shell::display_manager()

Project Member Reported by est...@chromium.org, Apr 11 2018

Issue description

# ash::Shell::display_manager() to update displays.
-ForceMaximizeOnFirstRunTest.*
-ForceMaximizePolicyFalseTest.*
-PolicyDisplayRotationDefault/DisplayRotationBootTest.*
-PolicyDisplayRotationDefault/DisplayRotationDefaultTest.*

# ash::Shell::display_manager() to get display state.
-PolicyTest.UnifiedDesktopEnabledByDefault

These can be updated after there's a mojo api for display configuration.
 
Components: Internals>Services>Ash
Labels: -Proj-Mustash-Mash
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f3685308f01a845d435546d2c0031b6aca501839

commit f3685308f01a845d435546d2c0031b6aca501839
Author: James Cook <jamescook@chromium.org>
Date: Wed Oct 24 03:19:16 2018

Enable DisplayRotationDefaultTest under SingleProcessMash

It seems to pass now.

Bug:  831826 
Change-Id: Idacf939fcc05a76fa14824ffa3f5f2cc4f68f984
Reviewed-on: https://chromium-review.googlesource.com/c/1297403
Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602243}
[modify] https://crrev.com/f3685308f01a845d435546d2c0031b6aca501839/testing/buildbot/filters/chromeos.single_process_mash.browser_tests.filter

Status: Archived (was: Available)
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cbef26d16616d7bd2ce80287b570f424da7f8666

commit cbef26d16616d7bd2ce80287b570f424da7f8666
Author: Evan Stade <estade@chromium.org>
Date: Wed Jan 02 23:17:56 2019

Disable more device display resolution tests which don't work with mash

TBR=jamescook@chromium.org

Bug:  831826 
Change-Id: Ic089f47b5069c54f79d9daaa66d1c6d6bde25657
Reviewed-on: https://chromium-review.googlesource.com/c/1393555
Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619530}
[modify] https://crrev.com/cbef26d16616d7bd2ce80287b570f424da7f8666/testing/buildbot/filters/chromeos.mash.fyi.browser_tests.filter

Project Member

Comment 5 by bugdroid1@chromium.org, Jan 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eaf82f712f17387022761d7f03b503f49aa683eb

commit eaf82f712f17387022761d7f03b503f49aa683eb
Author: Evan Stade <estade@chromium.org>
Date: Thu Jan 03 17:36:05 2019

Disable all PolicyDeviceDisplayResolution tests for mash.

There are still some failing, so instead of filtering many individual
tests, filter them all.

TBR=jamescook@chromium.org
BUG= 831826 

Change-Id: I42236102982a270917c96c6a9c030b6bd029543f
Reviewed-on: https://chromium-review.googlesource.com/c/1394392
Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619677}
[modify] https://crrev.com/eaf82f712f17387022761d7f03b503f49aa683eb/testing/buildbot/filters/chromeos.mash.fyi.browser_tests.filter

Sign in to add a comment