Figure out long-term solution for signing into Google on Chromium builds |
|||
Issue descriptionWhen Dice M2 rolled out, we broke Google sign-in for unsigned 3P Chromium builds. This is the tracking bug to figure out a long-term solution.
,
May 14 2018
Looks like the solution we're discussing over email is to simply allow 3P API keys with limited quota. Mihai - can we mark this as WontFix, since that shouldn't require any client changes?
,
Jun 14 2018
what about putting `enable_dice_support` in declare_args and fixing the broken ENABLE_DICE_SUPPORT guards on GetDisplayEmail and GetAccountsForDicePromos?
,
Jun 14 2018
Indeed I see a missing #if guard around GetDisplayEmail in signin_ui_util.cc. I will fix that. What is the problem with GetAccountsForDicePromos? About the declare_args: would this be used to force-disable Dice? I don't think that is something we want to support in the long term.
,
Jun 14 2018
I'm doing a minor fix for the GetDisplayEmail guard: https://chromium-review.googlesource.com/c/chromium/src/+/1100470/1/chrome/browser/signin/signin_ui_util.cc I'm afraid that this is not really the one you were expecting though.
,
Jun 14 2018
try building with `enable_dice_support = false` and you will see the other problems
,
Jun 14 2018
seems like `enable_dice_support` should only be true for `is_chrome_branded`. Most Chromium builds won't have an API key to use and there is no other practical way to turn it off at the moment.
,
Jun 14 2018
This flag is always set for Windows, macOS and Linux. We do not plan to support this flag being set to false on these platforms in the long-run. Note that signing in to Gmail on Chromium builds without API keys continue to work even when Desktop Identity Consistency is enabled - the last CL has landed yesterday as part of Issue 844250 . I am closing out this bug. brian@brianjohnson.cc: Please let me or droger@ know if you experience any issues to sign in to Google web properties when this flag is enabled.
,
Jun 14 2018
I'll check it out, thanks! |
|||
►
Sign in to add a comment |
|||
Comment 1 by sheriffbot@chromium.org
, May 14 2018