New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 831824 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Figure out long-term solution for signing into Google on Chromium builds

Project Member Reported by ew...@chromium.org, Apr 11 2018

Issue description

When Dice M2 rolled out, we broke Google sign-in for unsigned 3P Chromium builds. This is the tracking bug to figure out a long-term solution.
 
Project Member

Comment 1 by sheriffbot@chromium.org, May 14 2018

Status: Available (was: Assigned)
--Chrome Identity automated triaging--

This bug is Assigned and has gone one month without any activity, so it is being moved to Available to indicate that it is not actively being worked on. If you are working on this bug, please mark yourself as the owner and move back to Assigned. Please see https://goo.gl/78kbny for more details. Please remove the Services>SignIn or UI>Browser>Profiles components if this bug isn't related to Chrome Identity.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 2 by ew...@chromium.org, May 14 2018

Status: Assigned (was: Available)
Looks like the solution we're discussing over email is to simply allow 3P API keys with limited quota. Mihai - can we mark this as WontFix, since that shouldn't require any client changes?
what about putting `enable_dice_support` in declare_args and fixing the broken ENABLE_DICE_SUPPORT guards on GetDisplayEmail and GetAccountsForDicePromos?

Comment 4 by droger@chromium.org, Jun 14 2018

Indeed I see a missing #if guard around GetDisplayEmail in signin_ui_util.cc. I will fix that.

What is the problem with GetAccountsForDicePromos?

About the declare_args: would this be used to force-disable Dice? I don't think that is something we want to support in the long term.

Comment 5 by droger@chromium.org, Jun 14 2018

I'm doing a minor fix for the GetDisplayEmail guard:
https://chromium-review.googlesource.com/c/chromium/src/+/1100470/1/chrome/browser/signin/signin_ui_util.cc

I'm afraid that this is not really the one you were expecting though.
try building with `enable_dice_support = false` and you will see the other problems
seems like `enable_dice_support` should only be true for `is_chrome_branded`. Most Chromium builds won't have an API key to use and there is no other practical way to turn it off at the moment.

Comment 8 by msarda@chromium.org, Jun 14 2018

Status: Fixed (was: Assigned)
This flag is always set for Windows, macOS and Linux. We do not plan to support this flag being set to false on these platforms in the long-run.

Note that signing in to Gmail on Chromium builds without API keys continue to work even when Desktop Identity Consistency is enabled - the last CL has landed yesterday as part of  Issue 844250 . I am closing out this bug.
brian@brianjohnson.cc: Please let me or droger@ know if you experience any issues to sign in to Google web properties when this flag is enabled.
I'll check it out, thanks!

Sign in to add a comment