Add support for experimentation with new Previews on new URLs |
|||||
Issue descriptionIf the hints coming from the Optimization Hints component contains an "experimental" hint, the client should apply that hint with some probability < 1 rather than just blindly trusting it. This allows us to try Previews on new URLs for which we are not fully certain will work or not.
,
May 2 2018
,
May 4 2018
Accepted. :)
,
Jul 11
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c8940b1c9de6fb2951013a8d2bb78770e62598b7 commit c8940b1c9de6fb2951013a8d2bb78770e62598b7 Author: Jeremy Elson <jelson@chromium.org> Date: Wed Jul 11 22:28:10 2018 Allow optimization hints to be marked as experimental. Experimental hints are tagged (in the Optimization proto) with an experiment name. Experimental hints are not enabled unless an experiment with a matching name is enabled. Experiments are enabled by turning on the new base::Feature called kOptimizationHintsExperiments, with the name of the experiment in a parameter called experiment_name. Bug: 831817 Change-Id: I6141c70f8f3a8f9adb2c9772b747ee2a0c59b227 Reviewed-on: https://chromium-review.googlesource.com/1132491 Commit-Queue: Jeremy Elson <jelson@chromium.org> Reviewed-by: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#574380} [modify] https://crrev.com/c8940b1c9de6fb2951013a8d2bb78770e62598b7/components/optimization_guide/proto/hints.proto [modify] https://crrev.com/c8940b1c9de6fb2951013a8d2bb78770e62598b7/components/previews/content/previews_hints.cc [modify] https://crrev.com/c8940b1c9de6fb2951013a8d2bb78770e62598b7/components/previews/content/previews_optimization_guide_unittest.cc [modify] https://crrev.com/c8940b1c9de6fb2951013a8d2bb78770e62598b7/components/previews/core/previews_features.cc [modify] https://crrev.com/c8940b1c9de6fb2951013a8d2bb78770e62598b7/components/previews/core/previews_features.h
,
Jul 12
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2d5b014813423439467e645f6d5ecde5c9388eb6 commit 2d5b014813423439467e645f6d5ecde5c9388eb6 Author: Jeremy Elson <jelson@chromium.org> Date: Thu Jul 12 21:56:15 2018 Clarify comment in proto (and synchronize to match google internal proto) Bug: 831817 Change-Id: I016ce747bfbdce22c045ec24d49d1397d7deac35 Reviewed-on: https://chromium-review.googlesource.com/1135768 Reviewed-by: Tarun Bansal <tbansal@chromium.org> Commit-Queue: Jeremy Elson <jelson@chromium.org> Cr-Commit-Position: refs/heads/master@{#574742} [modify] https://crrev.com/2d5b014813423439467e645f6d5ecde5c9388eb6/components/optimization_guide/proto/hints.proto
,
Sep 21
Is this done?
,
Sep 21
,
Sep 21
It's never had an end-to-end test but it is code-complete
,
Sep 22
I guess we can mark it as fixed for now? We can file separate bugs if we see some issues.
,
Oct 31
Removing jeremy and jon from this but i think we should mark this as fixed if the E2E works or maybe dupe this over to the new bug?
,
Oct 31
Marking this as fixed. Lets file separate bugs if we find some issues during E2E testing. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by bengr@chromium.org
, May 2 2018Owner: jelson@chromium.org