New issue
Advanced search Search tips

Issue 831811 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: 2018-05-03
OS: Chrome
Pri: 3
Type: Feature

Blocking:
issue 831253



Sign in to add a comment

Run ozone_gl_unittests on CrOs autotest

Project Member Reported by mcasas@chromium.org, Apr 11 2018

Issue description

ozone_unittests is known to break from time to time and we'd like
to run this automatically on the chromebook fleet.
 

Comment 1 by mcasas@chromium.org, Apr 12 2018

Blockedon: 831253
Summary: Run ozone_gl_unittests on CrOs autotest (was: Run ozone_unittests on CrOs autotest)
After offline discussion, what we'd like to run is actually
 ozone_gl_unittests (and not ozone_unittests).

Comment 2 by ihf@chromium.org, Apr 12 2018

For tests that a rebuilt with Chrome we have a pretty standard way of building these tests (add to list in chromeos-chrome.ebuild) and fishing them out for testing.

The general problem is to keep failure counts from regressing, considering this usually happens after Chrome uprevs. And we don't normally want to hold Chrome uprev for such tests (bad experience in the past).

So, we could add an autotest to run ozone_gl_unittests, but just as FYI. And then report the failure counts to the perf dashboard, which would send us emails when problems get worse. Then it would become the graphics guard's duty to bisect Chrome to find the culprit, often a week or two after it landed.


Comment 3 by mcasas@chromium.org, Apr 12 2018

#2: WIP CLs: crrev.com/c/1008703 for fishing out the binary and 
crrev.com/c/1008782 to run it (temporarily developing w/ ozone_unittests
because ozone_gl_unittests are broken).

'FYI' SGTM - as long as there's an automated way to get notified when
they fail. dcastagna@ has probably more input as to how and when this
has happened in the past...
It happened often that ozone_gl_unittests broke, many times when Ozone initialization code changed. We don't want to block Chrome uprev in those cases.

When it breaks because we have an issue with RGBA GLImages we usually notice as soon as Chrome uprevs.
Adding it just FYI with notification seems good to me.
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/6685d13cde74e890ef00775f041bbd983959a26e

commit 6685d13cde74e890ef00775f041bbd983959a26e
Author: Miguel Casas <mcasas@chromium.org>
Date: Wed Apr 25 21:40:55 2018

autotest: add graphics_Chrome.ozone_gl_unittests

This CL adds a new graphics_Chrome to run a given Chrome unittests
binary, and uses it to run ozone_gl_unittests. This is a tiny test
that allocates a DmaBuf and fills it in, but needs a bunch of Chrome
subsystems to be OK and is known to have regressed in the past
inadvertently.

This CL also wires the |timeout| parameter in run_chrome_test_binary()
down to its call to utils.system(), and uses it.

Bug:  chromium:831811 
Change-Id: I5e85c05031e8e43ce8f8478ead5fc5433a81c57e
Reviewed-on: https://chromium-review.googlesource.com/1008782
Commit-Ready: Miguel Casas <mcasas@chromium.org>
Tested-by: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Ilja H. Friedel <ihf@chromium.org>

[modify] https://crrev.com/6685d13cde74e890ef00775f041bbd983959a26e/client/cros/chrome_binary_test.py
[add] https://crrev.com/6685d13cde74e890ef00775f041bbd983959a26e/client/site_tests/graphics_Chrome/graphics_Chrome.py
[add] https://crrev.com/6685d13cde74e890ef00775f041bbd983959a26e/client/site_tests/graphics_Chrome/control.ozone_gl_unittests

Project Member

Comment 6 by bugdroid1@chromium.org, Apr 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/433c9869b94ac4f91b7196d466c364885ac301a8

commit 433c9869b94ac4f91b7196d466c364885ac301a8
Author: Miguel Casas <mcasas@chromium.org>
Date: Wed Apr 25 23:52:32 2018

autotest: add forgotten import statement in graphics_Chrome.py

Bug:  chromium:831811 

Change-Id: Ibeaafcff7c66e5713339787dd64e9526ee4a4358
Reviewed-on: https://chromium-review.googlesource.com/1029011
Reviewed-by: Ilja H. Friedel <ihf@chromium.org>
Reviewed-by: Pohsien Wang <pwang@chromium.org>
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Tested-by: Miguel Casas <mcasas@chromium.org>

[modify] https://crrev.com/433c9869b94ac4f91b7196d466c364885ac301a8/client/site_tests/graphics_Chrome/graphics_Chrome.py

Project Member

Comment 7 by bugdroid1@chromium.org, Apr 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/a49071c344213764bba06bc1d9640b22f184b828

commit a49071c344213764bba06bc1d9640b22f184b828
Author: Miguel Casas <mcasas@chromium.org>
Date: Thu Apr 26 20:01:48 2018

chromeos-chrome: add ozone_gl_unittests binary

This CL adds ozone_gl_unittests to chromeos-chrome so it can be
called from an autotest running it.

Bug: chromium:831811 
Change-Id: I038323264e857eef5f5dcaaed9a1e17ff988f706
Reviewed-on: https://chromium-review.googlesource.com/1008703
Commit-Ready: Ilja H. Friedel <ihf@chromium.org>
Tested-by: Ilja H. Friedel <ihf@chromium.org>
Reviewed-by: Ilja H. Friedel <ihf@chromium.org>

[modify] https://crrev.com/a49071c344213764bba06bc1d9640b22f184b828/chromeos-base/chromeos-chrome/chromeos-chrome-9999.ebuild

Project Member

Comment 8 by bugdroid1@chromium.org, Apr 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/bdcfd67992f2af5f9c87934718effe56ce7f401b

commit bdcfd67992f2af5f9c87934718effe56ce7f401b
Author: Miguel Casas <mcasas@chromium.org>
Date: Fri Apr 27 16:30:00 2018

autotest-chrome: Add graphics_Chrome

This CL adds graphics_Chrome to autotest-chrome (because it needs
a Chrome binary) so that it'll be called and its results parsed.

BUG= chromium:831811 
TEST= built locally `emerge-${BOARD} autotest-chrome` see
 https://pastebin.com/LvvKN6Zf (some video_ errors are unrelated).
CQ-DEPEND=CL:1008703

Change-Id: If53fa9051a7d07edded77948a2d70a5716cfaeea
Reviewed-on: https://chromium-review.googlesource.com/1027804
Commit-Ready: Miguel Casas <mcasas@chromium.org>
Tested-by: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Ilja H. Friedel <ihf@chromium.org>

[modify] https://crrev.com/bdcfd67992f2af5f9c87934718effe56ce7f401b/chromeos-base/autotest-chrome/autotest-chrome-9999.ebuild

Comment 9 by mcasas@chromium.org, Apr 28 2018

NextAction: 2018-05-03
Status: Fixed (was: Assigned)
Fixed, let's verify in a week or so.
Project Member

Comment 10 by bugdroid1@chromium.org, May 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/58279b90488611b838349c10d674a9439caf8458

commit 58279b90488611b838349c10d674a9439caf8458
Author: Ilja H. Friedel <ihf@chromium.org>
Date: Wed May 02 19:52:47 2018

graphics_Chrome: fix test.

1) timeout is internally used.
2) add error import.
3) a bit more failure handling, but could be better.

BUG= chromium:831811 
TEST=It executes on caroline-arcnext, but fails with retries.

Change-Id: I9b5fe8cfb45c77ff2cf51a8e2e90bf5a7ee3c18c
Reviewed-on: https://chromium-review.googlesource.com/1039005
Commit-Queue: Ilja H. Friedel <ihf@chromium.org>
Tested-by: Ilja H. Friedel <ihf@chromium.org>
Trybot-Ready: Ilja H. Friedel <ihf@chromium.org>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Pohsien Wang <pwang@chromium.org>

[modify] https://crrev.com/58279b90488611b838349c10d674a9439caf8458/client/site_tests/graphics_Chrome/graphics_Chrome.py
[modify] https://crrev.com/58279b90488611b838349c10d674a9439caf8458/client/site_tests/graphics_Chrome/control.ozone_gl_unittests

The NextAction date has arrived: 2018-05-03
Project Member

Comment 12 by bugdroid1@chromium.org, May 3 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/7d84ac9f156fb0d2dcc80a85ff49d9d0962e815f

commit 7d84ac9f156fb0d2dcc80a85ff49d9d0962e815f
Author: Miguel Casas <mcasas@chromium.org>
Date: Thu May 03 18:39:15 2018

autotest: graphics_Chrome: add missing format specifier

This CL prevents the error below:
  File "/usr/local/autotest/tests/graphics_Chrome/graphics_Chrome.py", line 28, in run_once
    raise error.TestFail('Failed %' % unittests_binary_name)
  ValueError: incomplete format

by adding the missing 's'.

BUG= chromium:831811 
TEST=test_that... on my nautilus

Change-Id: I8fa7786a2ced284b7ded3197e51ad9db462d6508
Reviewed-on: https://chromium-review.googlesource.com/1042447
Tested-by: Miguel Casas <mcasas@chromium.org>
Trybot-Ready: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Ilja H. Friedel <ihf@chromium.org>

[modify] https://crrev.com/7d84ac9f156fb0d2dcc80a85ff49d9d0962e815f/client/site_tests/graphics_Chrome/graphics_Chrome.py

Project Member

Comment 13 by bugdroid1@chromium.org, May 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/60f4f6736988b4abbb436f63aeaf95d98902b001

commit 60f4f6736988b4abbb436f63aeaf95d98902b001
Author: Po-Hsien Wang <pwang@chromium.org>
Date: Fri May 11 01:09:32 2018

autotest: Add graphics_Chrome to perf_dashboard_config.json

Add graphics_Chrome to perf_dashboard_config.json

BUG= chromium:831811 
TEST=None

Change-Id: I17e0d5e70a3c6e2cbe3c7c7829e026cd547f25e7
Reviewed-on: https://chromium-review.googlesource.com/1040658
Commit-Ready: Pohsien Wang <pwang@chromium.org>
Tested-by: Pohsien Wang <pwang@chromium.org>
Reviewed-by: Ilja H. Friedel <ihf@chromium.org>
Reviewed-by: Miguel Casas <mcasas@chromium.org>

[modify] https://crrev.com/60f4f6736988b4abbb436f63aeaf95d98902b001/tko/perf_upload/perf_dashboard_config.json

Blocking: 831253
Blockedon: -831253

Sign in to add a comment