Refactor logitech-updater for PTZ Pro 2
Reported by
l...@logitech.com,
Apr 11 2018
|
||||
Issue descriptionUserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/65.0.3325.181 Safari/537.36 Steps to reproduce the problem: N/A What is the expected behavior? Update Logitech PTZ Pro device firmware when run logitech-updater command or on plug-in/system reboot. What went wrong? The previous updater still works but should be refactored to add more support for other devices Did this work before? Yes Chrome version: 65.0.3325.181 Channel: stable OS Version: Flash Version: Refactoring code for issue 750297 https://bugs.chromium.org/p/chromium/issues/detail?id=750297
,
Apr 12 2018
,
Apr 13 2018
This issue seems to be out of TE scope as this is related to tools. Hence adding TE-NeedsTriageHelp label for further investigation from dev team and cc'ing bhthompson@ from above linked bug 750297 . Thanks!
,
May 9 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/logitech-updater/+/d08fba1244f890cbbddefe645505fd8f21b84d8f commit d08fba1244f890cbbddefe645505fd8f21b84d8f Author: Lam Lu <llu7@logitech.com> Date: Wed May 09 00:44:29 2018 Refactor logitech-updater for PTZ Pro 2. This CL refactors the existing PTZ Pro 2 logitech-updater to support future update process for other Logitech devices and renames classes and variables according to Google C++ style. Refactor CL 583727 and CL 710511. BUG=chromium:831809 TEST=Run /sbin/minijail0 -u cfm-firmware-updaters -u cfm-firmware-updaters -G -e -i -l -r -n -p -v -S /usr/share/policy/logitech-updater-seccomp.policy /usr/sbin/logitech-updater --lock --delay=10 --update_components. Change-Id: Ib8520f7d2e5fb745d99d8db3a4ac3194660a002b Reviewed-on: https://chromium-review.googlesource.com/1008733 Commit-Ready: Lam Lu <llu7@logitech.com> Tested-by: Lam Lu <llu7@logitech.com> Reviewed-by: Zhongze Hu <frankhu@google.com> [modify] https://crrev.com/d08fba1244f890cbbddefe645505fd8f21b84d8f/src/eeprom_device.cc [modify] https://crrev.com/d08fba1244f890cbbddefe645505fd8f21b84d8f/src/main.cc [modify] https://crrev.com/d08fba1244f890cbbddefe645505fd8f21b84d8f/src/composite_device.cc [modify] https://crrev.com/d08fba1244f890cbbddefe645505fd8f21b84d8f/src/video_device.h [modify] https://crrev.com/d08fba1244f890cbbddefe645505fd8f21b84d8f/src/video_device.cc [modify] https://crrev.com/d08fba1244f890cbbddefe645505fd8f21b84d8f/src/mcu2_device.cc [modify] https://crrev.com/d08fba1244f890cbbddefe645505fd8f21b84d8f/src/mcu2_device.h [modify] https://crrev.com/d08fba1244f890cbbddefe645505fd8f21b84d8f/conf/99-logitech-updater.rules [modify] https://crrev.com/d08fba1244f890cbbddefe645505fd8f21b84d8f/seccomp/logitech-updater-seccomp-x86_64.policy [modify] https://crrev.com/d08fba1244f890cbbddefe645505fd8f21b84d8f/src/usb_device.h [modify] https://crrev.com/d08fba1244f890cbbddefe645505fd8f21b84d8f/seccomp/logitech-updater-seccomp-amd64.policy [modify] https://crrev.com/d08fba1244f890cbbddefe645505fd8f21b84d8f/src/usb_device.cc [modify] https://crrev.com/d08fba1244f890cbbddefe645505fd8f21b84d8f/src/version.h [modify] https://crrev.com/d08fba1244f890cbbddefe645505fd8f21b84d8f/src/composite_device.h [modify] https://crrev.com/d08fba1244f890cbbddefe645505fd8f21b84d8f/src/utilities.cc [modify] https://crrev.com/d08fba1244f890cbbddefe645505fd8f21b84d8f/src/utilities.h [modify] https://crrev.com/d08fba1244f890cbbddefe645505fd8f21b84d8f/src/eeprom_device.h
,
Jul 31
|
||||
►
Sign in to add a comment |
||||
Comment 1 by krajshree@chromium.org
, Apr 12 2018