New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 831806 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2018
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Stays in CCT for current WebAPK urls

Project Member Reported by ranj@chromium.org, Apr 11 2018

Issue description

This fixes the oauth signin through popup.
https://bugs.chromium.org/p/chromium/issues/detail?id=771418

If a CCT is opened by WebAPK, for redirection URLs that can be handled by the current WebAPK, we should stay in the CCT and let the CCT do the navigation.
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/16c3177a76dd7f69334c37cdfe15c7c21ac8d6e6

commit 16c3177a76dd7f69334c37cdfe15c7c21ac8d6e6
Author: Ran Ji <ranj@chromium.org>
Date: Thu May 10 02:37:32 2018

Stays in CCT for current WebAPK urls

This cl made two changes:
1. If a url is opened from WebAPK through window.open(), and that url is
within the current WebAPK scope. Open it in CCT instead of using WebAPK

2. If a CCT is opened by a WebAPK, and the CCT redirects to a url within
the WebAPK scope, stay in the CCT instead of using WebAPK to open the url.

Bug:  831806 , 771418
Change-Id: Ibf522b3b49599ec8bbb76f515f3b96b07707b56d
Reviewed-on: https://chromium-review.googlesource.com/1008735
Commit-Queue: Ran Ji <ranj@chromium.org>
Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557433}
[modify] https://crrev.com/16c3177a76dd7f69334c37cdfe15c7c21ac8d6e6/chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegateImpl.java
[modify] https://crrev.com/16c3177a76dd7f69334c37cdfe15c7c21ac8d6e6/chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandler.java
[modify] https://crrev.com/16c3177a76dd7f69334c37cdfe15c7c21ac8d6e6/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java
[modify] https://crrev.com/16c3177a76dd7f69334c37cdfe15c7c21ac8d6e6/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappTabDelegate.java
[modify] https://crrev.com/16c3177a76dd7f69334c37cdfe15c7c21ac8d6e6/chrome/android/javatests/src/org/chromium/chrome/browser/FullscreenActivityTest.java
[modify] https://crrev.com/16c3177a76dd7f69334c37cdfe15c7c21ac8d6e6/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebApkIntegrationTest.java
[modify] https://crrev.com/16c3177a76dd7f69334c37cdfe15c7c21ac8d6e6/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappActivityTestRule.java
[modify] https://crrev.com/16c3177a76dd7f69334c37cdfe15c7c21ac8d6e6/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappNavigationTest.java
[modify] https://crrev.com/16c3177a76dd7f69334c37cdfe15c7c21ac8d6e6/chrome/test/android/javatests/src/org/chromium/chrome/test/ChromeActivityTestRule.java
[add] https://crrev.com/16c3177a76dd7f69334c37cdfe15c7c21ac8d6e6/chrome/test/data/android/form.html

Comment 2 by ranj@chromium.org, May 11 2018

Status: Fixed (was: Untriaged)

Sign in to add a comment