P2P sharing: Sharing an un-opened offline page to Gmail does not use its title as the subject |
||||
Issue descriptionWhat steps will reproduce the problem? (1) Open downloads home and share an offline page from there (3-dots) (2) Choose Gmail as the destination (3) Note the subject line What is the expected result? The title of the page should be used for the email subject. What happens instead? The email subject is empty. The same doesn't happen when sharing an offline page that is opened in a tab.
,
Apr 17 2018
This could be related to filling out the share intent differently for the Downloads Home case from the Sharing from a Tab case.
,
Apr 17 2018
Sharing a file from DH also does not set the subject. DownloadUtils.createShareIntent() does not set the title field when creating the share intent, we also see this on other file types such as .jpg. OfflinePageUtils.sharePage() uses a ShareParams.Builder which sets the title. We should see if it makes sense to set the title for downloads too.
,
May 8 2018
,
May 16 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c98d2060c6a1706d996ddb38d1afae13bd504c4d commit c98d2060c6a1706d996ddb38d1afae13bd504c4d Author: Pete Williamson <petewil@chromium.org> Date: Wed May 16 23:31:04 2018 Include filename when sharing a file from Download Home. Bug: 831803 Change-Id: Ib1d125d22cbec36fc09e544db00d8c4cd10b5190 Reviewed-on: https://chromium-review.googlesource.com/1045839 Commit-Queue: Peter Williamson <petewil@chromium.org> Reviewed-by: David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#559334} [modify] https://crrev.com/c98d2060c6a1706d996ddb38d1afae13bd504c4d/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadUtils.java [modify] https://crrev.com/c98d2060c6a1706d996ddb38d1afae13bd504c4d/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryItemWrapper.java [modify] https://crrev.com/c98d2060c6a1706d996ddb38d1afae13bd504c4d/chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadUtilsTest.java
,
May 17 2018
We fixed the case where a single file is shared. If multiple files are shared, the title is still left blank. |
||||
►
Sign in to add a comment |
||||
Comment 1 by petewil@chromium.org
, Apr 16 2018Owner: petewil@chromium.org
Status: Assigned (was: Untriaged)