New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 831798 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Apr 2018
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Build basic page switching functionality for MultiDevice unified setup WebUI

Project Member Reported by jordynass@chromium.org, Apr 11 2018

Issue description

In order to start and frame the WebUI project, we need to build a skeleton for the functionality of the multidevice-setup polymer element. The natural starting point is implementing the page switching logic with placeholder pages to be filled in by the specs described in the design doc https://docs.google.com/document/d/1M-hpfEwq8P964ej-tWsX1lq47Lz8c3jG-exu846zkmk/edit#heading=h.xuw8zghlav8f
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b587dffc1f06a30bce1369ec5c3f2353bfeba0c0

commit b587dffc1f06a30bce1369ec5c3f2353bfeba0c0
Author: Jordy Greenblatt <jordynass@chromium.org>
Date: Fri Apr 13 20:45:23 2018

[CrOS MultiDevice] Basic page selection functionality for WebUI

Bug:  831798 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Id27d20963ae03a92aff7ae6d5e0fb6ab04da0773
Reviewed-on: https://chromium-review.googlesource.com/1008602
Commit-Queue: Jordy Greenblatt <jordynass@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550753}
[add] https://crrev.com/b587dffc1f06a30bce1369ec5c3f2353bfeba0c0/chrome/browser/resources/chromeos/multidevice_setup/button_navigation_behavior.html
[add] https://crrev.com/b587dffc1f06a30bce1369ec5c3f2353bfeba0c0/chrome/browser/resources/chromeos/multidevice_setup/button_navigation_behavior.js
[modify] https://crrev.com/b587dffc1f06a30bce1369ec5c3f2353bfeba0c0/chrome/browser/resources/chromeos/multidevice_setup/compiled_resources2.gyp
[modify] https://crrev.com/b587dffc1f06a30bce1369ec5c3f2353bfeba0c0/chrome/browser/resources/chromeos/multidevice_setup/multidevice_setup.html
[modify] https://crrev.com/b587dffc1f06a30bce1369ec5c3f2353bfeba0c0/chrome/browser/resources/chromeos/multidevice_setup/multidevice_setup.js
[modify] https://crrev.com/b587dffc1f06a30bce1369ec5c3f2353bfeba0c0/chrome/browser/resources/chromeos/multidevice_setup/multidevice_setup_resources.grd
[add] https://crrev.com/b587dffc1f06a30bce1369ec5c3f2353bfeba0c0/chrome/browser/resources/chromeos/multidevice_setup/setting_up_page.html
[add] https://crrev.com/b587dffc1f06a30bce1369ec5c3f2353bfeba0c0/chrome/browser/resources/chromeos/multidevice_setup/setting_up_page.js
[add] https://crrev.com/b587dffc1f06a30bce1369ec5c3f2353bfeba0c0/chrome/browser/resources/chromeos/multidevice_setup/setup_failed_page.html
[add] https://crrev.com/b587dffc1f06a30bce1369ec5c3f2353bfeba0c0/chrome/browser/resources/chromeos/multidevice_setup/setup_failed_page.js
[add] https://crrev.com/b587dffc1f06a30bce1369ec5c3f2353bfeba0c0/chrome/browser/resources/chromeos/multidevice_setup/setup_succeeded_page.html
[add] https://crrev.com/b587dffc1f06a30bce1369ec5c3f2353bfeba0c0/chrome/browser/resources/chromeos/multidevice_setup/setup_succeeded_page.js
[add] https://crrev.com/b587dffc1f06a30bce1369ec5c3f2353bfeba0c0/chrome/browser/resources/chromeos/multidevice_setup/start_setup_page.html
[add] https://crrev.com/b587dffc1f06a30bce1369ec5c3f2353bfeba0c0/chrome/browser/resources/chromeos/multidevice_setup/start_setup_page.js

Status: Fixed (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 17 2018

Labels: merge-merged-testbranch
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b587dffc1f06a30bce1369ec5c3f2353bfeba0c0

commit b587dffc1f06a30bce1369ec5c3f2353bfeba0c0
Author: Jordy Greenblatt <jordynass@chromium.org>
Date: Fri Apr 13 20:45:23 2018

[CrOS MultiDevice] Basic page selection functionality for WebUI

Bug:  831798 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Id27d20963ae03a92aff7ae6d5e0fb6ab04da0773
Reviewed-on: https://chromium-review.googlesource.com/1008602
Commit-Queue: Jordy Greenblatt <jordynass@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550753}
[add] https://crrev.com/b587dffc1f06a30bce1369ec5c3f2353bfeba0c0/chrome/browser/resources/chromeos/multidevice_setup/button_navigation_behavior.html
[add] https://crrev.com/b587dffc1f06a30bce1369ec5c3f2353bfeba0c0/chrome/browser/resources/chromeos/multidevice_setup/button_navigation_behavior.js
[modify] https://crrev.com/b587dffc1f06a30bce1369ec5c3f2353bfeba0c0/chrome/browser/resources/chromeos/multidevice_setup/compiled_resources2.gyp
[modify] https://crrev.com/b587dffc1f06a30bce1369ec5c3f2353bfeba0c0/chrome/browser/resources/chromeos/multidevice_setup/multidevice_setup.html
[modify] https://crrev.com/b587dffc1f06a30bce1369ec5c3f2353bfeba0c0/chrome/browser/resources/chromeos/multidevice_setup/multidevice_setup.js
[modify] https://crrev.com/b587dffc1f06a30bce1369ec5c3f2353bfeba0c0/chrome/browser/resources/chromeos/multidevice_setup/multidevice_setup_resources.grd
[add] https://crrev.com/b587dffc1f06a30bce1369ec5c3f2353bfeba0c0/chrome/browser/resources/chromeos/multidevice_setup/setting_up_page.html
[add] https://crrev.com/b587dffc1f06a30bce1369ec5c3f2353bfeba0c0/chrome/browser/resources/chromeos/multidevice_setup/setting_up_page.js
[add] https://crrev.com/b587dffc1f06a30bce1369ec5c3f2353bfeba0c0/chrome/browser/resources/chromeos/multidevice_setup/setup_failed_page.html
[add] https://crrev.com/b587dffc1f06a30bce1369ec5c3f2353bfeba0c0/chrome/browser/resources/chromeos/multidevice_setup/setup_failed_page.js
[add] https://crrev.com/b587dffc1f06a30bce1369ec5c3f2353bfeba0c0/chrome/browser/resources/chromeos/multidevice_setup/setup_succeeded_page.html
[add] https://crrev.com/b587dffc1f06a30bce1369ec5c3f2353bfeba0c0/chrome/browser/resources/chromeos/multidevice_setup/setup_succeeded_page.js
[add] https://crrev.com/b587dffc1f06a30bce1369ec5c3f2353bfeba0c0/chrome/browser/resources/chromeos/multidevice_setup/start_setup_page.html
[add] https://crrev.com/b587dffc1f06a30bce1369ec5c3f2353bfeba0c0/chrome/browser/resources/chromeos/multidevice_setup/start_setup_page.js

Sign in to add a comment