Square wallpapers may be improperly resized when display size changes |
|||
Issue descriptionChrome Version: 67.0.3390.0 OS: Chrome OS What steps will reproduce the problem? (1) Set "original_image" as wallpaper in landscape mode. (2) Observe the wallpaper has the same look with the attached "landscape" image. (3) Rotate the device. What is the expected result? The wallpaper should look the same with the "portrait_expected" image. What happens instead? The wallpaper looks the same with the "portrait_actual" image. This issue is a bug. And it's related to the feedback report: https://listnr.corp.google.com/report/85281054688 The user in the report is requesting to see the entire wallpaper in portrait mode (and doesn't mind having black empty areas). So the feedback report is a different issue and needs UX's opinions first.
,
Apr 12 2018
,
Apr 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/11ba24f9ca851a2c2b32015fbd59c1d782bdcbb0 commit 11ba24f9ca851a2c2b32015fbd59c1d782bdcbb0 Author: Wenzhao Zang <wzang@chromium.org> Date: Thu Apr 12 18:13:21 2018 cros: Fix wallpaper improper resizing issue The "current_wallpaper_.reset()" call in |ReloadWallpaper| was deleted earlier since it was believed to be useless, but without it, the |WallpaperIsAlreadyLoaded| check returns true which prevents wallpaper reloading. This results in a bug when the wallpaper has special shape (e.g. square) and it must be reloaded in order to fit a different display size. Also modified the |WallpaperBlurDisabledByPolicy| test since the author of the test was not aware that DEVCIE wallpaper only exists in login screen so most parts of the test are not meaningful. Bug: 831794 Change-Id: I7e2c78157eacc9034bb39de1a7a00729f8a26ec2 Reviewed-on: https://chromium-review.googlesource.com/1008604 Reviewed-by: Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#550271} [modify] https://crrev.com/11ba24f9ca851a2c2b32015fbd59c1d782bdcbb0/ash/wallpaper/wallpaper_controller.cc [modify] https://crrev.com/11ba24f9ca851a2c2b32015fbd59c1d782bdcbb0/ash/wallpaper/wallpaper_controller_unittest.cc |
|||
►
Sign in to add a comment |
|||
Comment 1 by bugdroid1@chromium.org
, Apr 12 2018