cros-workon'ed builds ignore board/profile package.mask |
|||
Issue descriptionExample: $ cat src/third_party/chromiumos-overlay/profiles/base/package.mask sys-kernel/chromeos-kernel-4_4 $ cros_workon-kevin stop chromeos-kernel-4_4 $ emerge-kevin chromeos-kernel-4_4 <fails with mask warning, as expected> $ cros_workon-kevin start chromeos-kernel-4_4 $ emerge-kevin chromeos-kernel-4_4 <succeeds; unexpected> This can cause problems with stuff like bug 831025, where different profiles may use different versions of the same package. package.mask works fine for masking the non-cros-workon'ed build, but as soon as I cros_workon the package, it looks like it's somewhat arbitrary which one will get selected. Is this a known issue? Does it make sense to try to fix this?
,
Apr 11 2018
So how does one properly handle something like bug 831025? If I cros_workon hostapd or wpa_supplicant for gale or whirlwind testbed-ap, it seems arbitrary as to which one I'll get -- jetstream's version or chromiumos's version. I guess I can always be sure to emerge with a ::chromiumos suffix, but that's tricky and means I can't rely on build_packages at that point... e.g., for gale --profile=testbed-ap: emerge-gale net-wireless/hostapd::chromiumos
,
Apr 11 2018
I don't know of a good answer for that. I'm guessing that when we wrote cros_workon we never intended for packages that use it to also be masked via the normal method. Maybe we can change the name of the package to something like hostapd-jetstream, add it to target-chromium-os in the jestream overlay, and then add hostapd to the package.provided file. It's hacky but I can't really think of a better way right now.
,
Apr 12 2018
OK, thanks. Since this is likely only biting people like me (specifically around jetstream-like platforms where we don't want to use jetstream software), I'll assign to me, with the expectation that I'll likely only try this if it gets really annoying.
,
Apr 24 2018
yeah, Chirantan covered it all well. we've exceeded original design goals quite a bit when it comes to cros-workon. before writing the package.unmask entry, we could have it query the overlay where the current version is visible from, and then we include that in our package.unmask line. i think that'd address scenarios like issue 831025. |
|||
►
Sign in to add a comment |
|||
Comment 1 by chirantan@chromium.org
, Apr 11 2018