Add UMA for screenshare track ended |
||||
Issue descriptionWe should add a histogram for tracking when a screen share video track ends and what the reason was. This would have been very useful when debugging current screen share issues.
,
Apr 13 2018
The following revision refers to this bug: https://webrtc.googlesource.com/src.git/+/c6416fbe167df739b6551109d48eb435e26a89f9 commit c6416fbe167df739b6551109d48eb435e26a89f9 Author: braveyao <braveyao@webrtc.org> Date: Fri Apr 13 21:15:59 2018 [desktopCapture] add some logs into trace event While investigating some screen-capture-track-end-in-meeting issues, the relevant rtc error logs are not uploaded to server as other webrtc modules do, which cause great hardness to identify the reason. This cl is to use existing trace event methods to store error logs of desktop capturers. Bug: chromium:831756 Change-Id: Id0c1b439f9b63916fb9417cf4e6f2b8f3c556fcd Reviewed-on: https://webrtc-review.googlesource.com/69783 Reviewed-by: Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Brave Yao <braveyao@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22866} [modify] https://crrev.com/c6416fbe167df739b6551109d48eb435e26a89f9/modules/desktop_capture/cropping_window_capturer_win.cc [modify] https://crrev.com/c6416fbe167df739b6551109d48eb435e26a89f9/modules/desktop_capture/mac/desktop_configuration_monitor.cc [modify] https://crrev.com/c6416fbe167df739b6551109d48eb435e26a89f9/modules/desktop_capture/mac/screen_capturer_mac.mm [modify] https://crrev.com/c6416fbe167df739b6551109d48eb435e26a89f9/modules/desktop_capture/screen_capturer_x11.cc [modify] https://crrev.com/c6416fbe167df739b6551109d48eb435e26a89f9/modules/desktop_capture/win/screen_capturer_win_directx.cc [modify] https://crrev.com/c6416fbe167df739b6551109d48eb435e26a89f9/modules/desktop_capture/win/screen_capturer_win_gdi.cc [modify] https://crrev.com/c6416fbe167df739b6551109d48eb435e26a89f9/modules/desktop_capture/window_capturer_mac.mm [modify] https://crrev.com/c6416fbe167df739b6551109d48eb435e26a89f9/modules/desktop_capture/window_capturer_win.cc [modify] https://crrev.com/c6416fbe167df739b6551109d48eb435e26a89f9/modules/desktop_capture/window_capturer_x11.cc
,
Apr 14 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cca5fb486974e3819b06c12e490fa4fc94e7319a commit cca5fb486974e3819b06c12e490fa4fc94e7319a Author: webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Sat Apr 14 05:49:05 2018 Roll src/third_party/webrtc/ 3acffc3b1..365381fdf (3 commits) https://webrtc.googlesource.com/src.git/+log/3acffc3b1668..365381fdf1cd $ git log 3acffc3b1..365381fdf --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG= chromium:831756 ,chromium:None The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Id11b4397d911eda8fefc1ea35cf47e4e7f1fe30d Reviewed-on: https://chromium-review.googlesource.com/1013397 Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#550883} [modify] https://crrev.com/cca5fb486974e3819b06c12e490fa4fc94e7319a/DEPS
,
Apr 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cca5fb486974e3819b06c12e490fa4fc94e7319a commit cca5fb486974e3819b06c12e490fa4fc94e7319a Author: webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Sat Apr 14 05:49:05 2018 Roll src/third_party/webrtc/ 3acffc3b1..365381fdf (3 commits) https://webrtc.googlesource.com/src.git/+log/3acffc3b1668..365381fdf1cd $ git log 3acffc3b1..365381fdf --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG= chromium:831756 ,chromium:None The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Id11b4397d911eda8fefc1ea35cf47e4e7f1fe30d Reviewed-on: https://chromium-review.googlesource.com/1013397 Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#550883} [modify] https://crrev.com/cca5fb486974e3819b06c12e490fa4fc94e7319a/DEPS
,
Apr 20 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e3ee9b1984106e6a2074af2cfdd1dffe8aaa221d commit e3ee9b1984106e6a2074af2cfdd1dffe8aaa221d Author: Weiyong Yao <braveyao@chromium.org> Date: Fri Apr 20 17:41:38 2018 [desktopCapture] Add UMA for screenshare track ended When desktop capturer, screen/window, has permantent error, the corresponding media track will end internally. Lacking of such statistics causes many trouble to track related issues recently. This cl is to add those stats. Bug: 831756 Change-Id: I86377be4919bbbc2eca5388a4e12a1749d4dc943 Reviewed-on: https://chromium-review.googlesource.com/1014365 Reviewed-by: Zijie He <zijiehe@chromium.org> Reviewed-by: Yuri Wiitala <miu@chromium.org> Commit-Queue: Weiyong Yao <braveyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#552374} [modify] https://crrev.com/e3ee9b1984106e6a2074af2cfdd1dffe8aaa221d/content/browser/media/capture/desktop_capture_device.cc [modify] https://crrev.com/e3ee9b1984106e6a2074af2cfdd1dffe8aaa221d/content/browser/media/capture/desktop_capture_device_uma_types.h [modify] https://crrev.com/e3ee9b1984106e6a2074af2cfdd1dffe8aaa221d/tools/metrics/histograms/enums.xml
,
Apr 27 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fce5284688994e2562b06175b8661f117f8071df commit fce5284688994e2562b06175b8661f117f8071df Author: braveyao <braveyao@chromium.org> Date: Fri Apr 27 23:38:52 2018 [desktopCapture] Let UMA only count the first permanent capture error In some recent testings it looks like there may be multiple PERMANENT capture error reported before the track is ended due to the first error report. So it's necesary to log the permanent error only once for one session. Bug: 831756 Change-Id: Icf969f0a1f1d644bd362811cf8658cabb7d3a3a1 Reviewed-on: https://chromium-review.googlesource.com/1033818 Reviewed-by: Zijie He <zijiehe@chromium.org> Commit-Queue: Weiyong Yao <braveyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#554560} [modify] https://crrev.com/fce5284688994e2562b06175b8661f117f8071df/content/browser/media/capture/desktop_capture_device.cc
,
Apr 27 2018
,
Jun 7 2018
[bulk-edit: disregard if N/A] Can the owner please set milestone to this bug if applicable?
,
Jun 7 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by braveyao@chromium.org
, Apr 11 2018