New issue
Advanced search Search tips

Issue 831754 link

Starred by 1 user

Issue metadata

Status: Untriaged
Owner: ----
Cc:
EstimatedDays: ----
NextAction: 2019-07-09
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

gclient sync error: src/third_party/harfbuzz-ng/src (ERROR)

Project Member Reported by warx@chromium.org, Apr 11 2018

Issue description

ToT commit: 287dfd85909c516f77bed4b011e8c1030f6d3b1f

warx@warx0:~/chromium/src$ gsync
Syncing projects:  95% (117/123) src/third_party/libphonenumber/dist

src/third_party/harfbuzz-ng/src (ERROR)
----------------------------------------
[0:00:14] Started.
----------------------------------------
Error: 96>
96> ____ src/third_party/harfbuzz-ng/src at 957e7756634a4fdf1654041e20e883cf964ecac9
96>     You have unstaged changes.
96>     Please commit, stash, or reset.


Assigned to gardener for triage.

 

Comment 1 by warx@chromium.org, Apr 11 2018

Well, I `git stash` in src/third_party/harfbuzz-ng/src and fixed the problem. Feel free to WontFix it. But it still feels like a bug.
Cc: alemate@chromium.org
Owner: jbudorick@chromium.org
I think this is an old bug in gclient.
I also receive this error message from time to time.

( cd third_party/libphonenumber/dist && git reset --hard)

usually helps. (This is not specific to libphonenumber, just an example.)
Components: -Blink>Fonts
alemate: why'd you assign this to me & why do you think this is a bug in gclient?
Because gclient sync sometimes fails for never-changed-locally-sources when trying to sync from some old chrome version. I believe that warx@ never changed that no-one-knows-what third-party library.

I don't know why, but if you check out and synchronize relatively old chrome (like half a year ago), and then try to switch back to ToT, it is very common for gclient sync to fail reporting unstaged changes in random third_party/ stuff.

May be it's git bug, but gclient should have workaround for that. Basically, if before synchronizing dependency there were no unstaged changes, it should probably run some git-hack to help with those git errors.
Cc: ehmaldonado@chromium.org aga...@chromium.org
Labels: -Pri-1 Pri-2
Owner: ----
Status: Available (was: Assigned)
that answers the second question, but not the first :)

I'm not the right owner for this, or the best person to say whether it's a bug. I don't think it's a P1, though, regardless.

+agable & ehmaldonado for their thoughts.
Labels: Pri-3
NextAction: 2019-07-09
Downgrading P2s that haven't been modified in more than 6 months, which have no component or owner.
Status: Untriaged (was: Available)
Available, but no owner or component? Please find a component, as no one will ever find this without one.

Sign in to add a comment