VR: Web input field cleared when keyboard is spawned |
||||
Issue descriptionWhat steps will reproduce the problem? (1) Navigate to https://rsolomakhin.github.io/autofill/ or any page with a text field (2) Enter text into a web input field (3) Enter VR (4) Click on the web input field from step 3 Expected: The cursor should show up where you clicked, and you should be able to edit text Actual: When they keyboard is spawned, the text field is cleared.
,
Apr 12 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/10ccacbd798af1b1b422b1f38166e6ded0d0b056 commit 10ccacbd798af1b1b422b1f38166e6ded0d0b056 Author: Yash Malik <ymalik@google.com> Date: Thu Apr 12 15:37:36 2018 VR: Call KeyboardDelegate::OnBeginFrame every frame regardless of visibility The gvr keyboard API requires that gvr_keyboard_advance_frame is called every time after the keyboard is initialized. This regressed in the optimization that doesn't call UiElement::OnBeginFrame for invisible elements. We add a special hook to do certain thing every frame. Bug: 831749 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I877299165dde517fab90451788de9680700666d9 Reviewed-on: https://chromium-review.googlesource.com/1009042 Commit-Queue: Yash Malik <ymalik@chromium.org> Reviewed-by: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#550215} [modify] https://crrev.com/10ccacbd798af1b1b422b1f38166e6ded0d0b056/chrome/browser/android/vr/vr_shell_gl.cc [modify] https://crrev.com/10ccacbd798af1b1b422b1f38166e6ded0d0b056/chrome/browser/vr/elements/content_element_unittest.cc [modify] https://crrev.com/10ccacbd798af1b1b422b1f38166e6ded0d0b056/chrome/browser/vr/elements/keyboard.cc [modify] https://crrev.com/10ccacbd798af1b1b422b1f38166e6ded0d0b056/chrome/browser/vr/elements/keyboard.h [modify] https://crrev.com/10ccacbd798af1b1b422b1f38166e6ded0d0b056/chrome/browser/vr/elements/ui_element.cc [modify] https://crrev.com/10ccacbd798af1b1b422b1f38166e6ded0d0b056/chrome/browser/vr/elements/ui_element.h [modify] https://crrev.com/10ccacbd798af1b1b422b1f38166e6ded0d0b056/chrome/browser/vr/ui_scene.cc [modify] https://crrev.com/10ccacbd798af1b1b422b1f38166e6ded0d0b056/chrome/browser/vr/ui_scene.h [modify] https://crrev.com/10ccacbd798af1b1b422b1f38166e6ded0d0b056/chrome/browser/vr/ui_scene_creator.cc
,
Apr 12 2018
,
Apr 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/10ccacbd798af1b1b422b1f38166e6ded0d0b056 commit 10ccacbd798af1b1b422b1f38166e6ded0d0b056 Author: Yash Malik <ymalik@google.com> Date: Thu Apr 12 15:37:36 2018 VR: Call KeyboardDelegate::OnBeginFrame every frame regardless of visibility The gvr keyboard API requires that gvr_keyboard_advance_frame is called every time after the keyboard is initialized. This regressed in the optimization that doesn't call UiElement::OnBeginFrame for invisible elements. We add a special hook to do certain thing every frame. Bug: 831749 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I877299165dde517fab90451788de9680700666d9 Reviewed-on: https://chromium-review.googlesource.com/1009042 Commit-Queue: Yash Malik <ymalik@chromium.org> Reviewed-by: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#550215} [modify] https://crrev.com/10ccacbd798af1b1b422b1f38166e6ded0d0b056/chrome/browser/android/vr/vr_shell_gl.cc [modify] https://crrev.com/10ccacbd798af1b1b422b1f38166e6ded0d0b056/chrome/browser/vr/elements/content_element_unittest.cc [modify] https://crrev.com/10ccacbd798af1b1b422b1f38166e6ded0d0b056/chrome/browser/vr/elements/keyboard.cc [modify] https://crrev.com/10ccacbd798af1b1b422b1f38166e6ded0d0b056/chrome/browser/vr/elements/keyboard.h [modify] https://crrev.com/10ccacbd798af1b1b422b1f38166e6ded0d0b056/chrome/browser/vr/elements/ui_element.cc [modify] https://crrev.com/10ccacbd798af1b1b422b1f38166e6ded0d0b056/chrome/browser/vr/elements/ui_element.h [modify] https://crrev.com/10ccacbd798af1b1b422b1f38166e6ded0d0b056/chrome/browser/vr/ui_scene.cc [modify] https://crrev.com/10ccacbd798af1b1b422b1f38166e6ded0d0b056/chrome/browser/vr/ui_scene.h [modify] https://crrev.com/10ccacbd798af1b1b422b1f38166e6ded0d0b056/chrome/browser/vr/ui_scene_creator.cc
,
May 8 2018
Fix verified in build 67.0.3396.29 beta. Looks good. |
||||
►
Sign in to add a comment |
||||
Comment 1 by ymalik@chromium.org
, Apr 11 2018