[Autofill] Section Identification based on Overall Prediction. |
|||
Issue descriptionCurrently, for identifying the sections, we rely on field types detected by heuristics. On the other hand, we have server detection and overall detection. Since the ultimate filling decisions are based on the overall detection, we should consider using overall type detections for section identification. Exp: In the cabelas.com payment section, the heuristics detect card holder name as the address name, whereas the overall type is detected correctly. The sections are thus wrong.
,
Apr 16 2018
,
Apr 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bc4ac6878647ce8e06e3defe00a8b81bb11f7e05 commit bc4ac6878647ce8e06e3defe00a8b81bb11f7e05 Author: Parastoo Geranmayeh <parastoog@google.com> Date: Mon Apr 16 19:37:01 2018 [Autofill] Determine Heuristics based on Overall Prediction Problem: On the last run to determine heuristics we do not consider the overall server type detections, and we only rely on field types detected by heuristics. Since the ultimate filling decisions are based on the overall detection, we need to use overall type detection. As in section identification this can sometimes cause an incorrect output. Exp: In the cabelas.com payment section, the heuristics detect card holder name as the address name, whereas the overall type is detected correctly. The sections are thus wrong. Solution: Update the form from the cache, before determining the heuristics for the last time. Test added. Bug: 831739 Change-Id: Ifdecfa442a21d38b53169c8dafc981ca5447629b Reviewed-on: https://chromium-review.googlesource.com/1012980 Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#551076} [modify] https://crrev.com/bc4ac6878647ce8e06e3defe00a8b81bb11f7e05/components/autofill/core/browser/autofill_manager.cc [modify] https://crrev.com/bc4ac6878647ce8e06e3defe00a8b81bb11f7e05/components/autofill/core/browser/autofill_manager.h [modify] https://crrev.com/bc4ac6878647ce8e06e3defe00a8b81bb11f7e05/components/autofill/core/browser/autofill_manager_unittest.cc |
|||
►
Sign in to add a comment |
|||
Comment 1 by bugdroid1@chromium.org
, Apr 16 2018